Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8654947imu; Tue, 4 Dec 2018 11:54:23 -0800 (PST) X-Google-Smtp-Source: AFSGD/WYbgFgb3Oax/s9dTavb5ZcL5CBXBuAymYbwav9e60leibTzgD3FvuLQYKZDgBVn8v1dO3L X-Received: by 2002:a63:ed42:: with SMTP id m2mr16684500pgk.147.1543953263578; Tue, 04 Dec 2018 11:54:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543953263; cv=none; d=google.com; s=arc-20160816; b=FUUy4U3cPwNVz01C9AM1gkQ/Aa74rNU8sPOVZdTd8dJgXgj09fMUbTPEKDB3HyLGY8 N3VhhvWs1H2P4VLzbWao6A4z8y7qydtXOUA+4l4PeamuicP7vxkcqDYzrKcM4anu+GR3 alyx+GtLxAlRNmwGPqNRq/jFr+f0fyfUau4vyTWj/6X5kqKYMnsUKmEnFue/HRTB11Ez nZCVkx1/vGyi1Y7r2VCGl11eBdQ+o6aWf5JLfJ7GQUzEM7EuZfDW3MqDdsGfDgF3PR0+ re2G7GHw+pJubovjdZSrv1g556UNwJ9v19HG8J8pK1RROeS+//LMuwZSOfcEIkPu9Koa sqnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eibZSqqt2fdedYCZEqGEWncABakoTV+JJrqQAPkEo70=; b=P1C7jPZHdcjKYRAvnCbyJHx2jvEpPshS6RC5l/vuIdUrtE4mdhMEPuC5CmFU8oYp5X /gB1HxEIqRfz3aig+gom5/NFM2ep8RDxBY7vgEvgvLZrYuzPNCFABzo/7N7Bh5Z3OvrX 5b1OiR1OlF2/bGp2o7LBFtGKKhb48+W/uuq/KHRN6kw/VaNoeF3TgBECghg0b8CQ3aiY VAoRSRVvqw1ZVuCSzPhV4eC+zSIGnqXfXmtt1Fzmweqeyt5ZC1bU1+upKN8tTOnvQPPU NtSL15pfqECxMOh21wqGSUHFjSO7U7eEw0wWbCF3ZxoGqO6iUlcLXlS6vt4053jqZgs6 2+oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=e9VoNikx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y17si17683116pll.10.2018.12.04.11.54.08; Tue, 04 Dec 2018 11:54:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=e9VoNikx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725874AbeLDTxb (ORCPT + 99 others); Tue, 4 Dec 2018 14:53:31 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:46845 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbeLDTxb (ORCPT ); Tue, 4 Dec 2018 14:53:31 -0500 Received: by mail-yb1-f193.google.com with SMTP id l126so3419908ybf.13 for ; Tue, 04 Dec 2018 11:53:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eibZSqqt2fdedYCZEqGEWncABakoTV+JJrqQAPkEo70=; b=e9VoNikxb1yKN7yTDxfP/PRQF4kY+TdUAo3Dd3k5vpDc+QARcG7zgJemnx15g8VY6p 6bhUEmuGlIKOXF6xLNjIU9HGHXoFIl/oquJXyBoaUJGHBARVys3B7pUpNG0nJEjZAcrD UN6f0n0A4jCJqVCJWi1bVL82RRNES0O87NRcvQmIY3KHj0i7zeq0eBGVxHhv/eFwMnzb 5hGdgwIZERYn9tAsQJ94snlf4ajwSFw28zvESwq1SMlEyNamlKEsca0TfjfvDUgkn/Ys wRXMuqUEWrew3IgJ7OppvojSxbs0mvrHT9hAT5LDNh21RKViLdkpnnV3JvU3uXNOav3v yV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eibZSqqt2fdedYCZEqGEWncABakoTV+JJrqQAPkEo70=; b=djsBujcwyO6AMcuRgqsfeOv5IVFnoJgDIKtb1jFgjKVbGZYUrH9TxxfqKfeOuTdZEq 2IfFb380fyVZqZaITsQQbVDu0ugbujYg0/+tUX7stE61YfXAEBbpfyI7d+XT2D38A9e3 UFVlkrzIRz+yc8rJaZAEsV0LSFXh8m7d5TY7c2ov+gttnvELhftqlc9VIzYCTF6PkT6W gMrTGxBEQlBwToSSS1S9PAhufzEcct3r1XADTmzR7Av/6tcWoWi77z/P87lMCHipp4wT 9LtbkTVewZ5JBQzlnLBKHpIrvzN6QhqXYs3wmoWuX0IUYJ071JOymVyv2X88WuBQwq80 n7mg== X-Gm-Message-State: AA+aEWZiZ4Kmxjz7YIR/rGgEZsuIqK8gw1hhww9T9plyqnplgGKLgb05 Sw9CM9o5BbauuysEw/XqQnPKyQ== X-Received: by 2002:a25:1e56:: with SMTP id e83-v6mr16986454ybe.163.1543953210567; Tue, 04 Dec 2018 11:53:30 -0800 (PST) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id b144sm8042496ywa.33.2018.12.04.11.53.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 11:53:29 -0800 (PST) Date: Tue, 4 Dec 2018 14:53:28 -0500 From: Josef Bacik To: Dennis Zhou Cc: Jens Axboe , Tejun Heo , Johannes Weiner , Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/14] blkcg: remove bio_disassociate_task() Message-ID: <20181204195327.upryhcrqaxjxgrzd@MacBook-Pro-91.local> References: <20181204183600.99746-1-dennis@kernel.org> <20181204183600.99746-13-dennis@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204183600.99746-13-dennis@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 01:35:58PM -0500, Dennis Zhou wrote: > Now that a bio only holds a blkg reference, so clean up is simply > putting back that reference. Remove bio_disassociate_task() as it just > calls bio_disassociate_blkg() and call the latter directly. > > Signed-off-by: Dennis Zhou > Acked-by: Tejun Heo Reviewed-by: Josef Bacik Thanks, Josef