Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <2341ec89691f6221bab6a9696ed0c05c3d3de663.camel@baylibre.com>
Cc:     linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20181204125839.14505-1-narmstrong@baylibre.com>
 <154394543049.88331.11854270462393390489@swboyd.mtv.corp.google.com>
 <5C06D686.50108@baylibre.com>
 <2341ec89691f6221bab6a9696ed0c05c3d3de663.camel@baylibre.com>
Message-ID: <154395650817.88331.14817295166592104160@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH] clk: meson-gxbb: switch video clocks mux tables to static
Date:   Tue, 04 Dec 2018 12:48:28 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jerome Brunet (2018-12-04 12:05:02)
> On Tue, 2018-12-04 at 20:33 +0100, Neil Armstrong wrote:
> > Le 04/12/2018 18:43, Stephen Boyd a =C3=A9crit :
> > > Quoting Neil Armstrong (2018-12-04 04:58:39)
> > > > @@ -1983,7 +1983,7 @@ static struct clk_fixed_factor gxbb_vclk2_div=
12 =3D
> > > > {
> > > >  };
> > > >  =

> > > >  static u32 mux_table_cts_sel[] =3D { 0, 1, 2, 3, 4, 8, 9, 10, 11, =
12 };
> > > =

> > > I was talking about this mux_table_cts_sel array. Can this be const?
> > > =

> > =

> > Other mux tables aren't const, Jerome so you see a reason why they aren=
't
> > const ?
> =

> I'm surpised we missed that. The PLL params tables of amlogic are all 'st=
atic
> const' but all the mux tables are just 'static' , humm
> =

> [...] 5 min later [...]
> =

> Actually the table field of clk_mux is not const, so giving it a const ta=
ble
> would produce a warning about discarding const qualifier
> =

> I guess there should no problem adding const to the table field of struct
> clk_mux. What do you think Stephen  ?

Yes it would need to be marked const in the struct clk_mux as well. Go
for it to move more things to the RO section.