Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9003579imu; Tue, 4 Dec 2018 19:02:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/UmkT9qHF2Uc0qkst1Ts9W1IdQ9UzYiNboI62/1Gg1wHdoYIaFg+y2Z4MIiIwopaMSUFbfh X-Received: by 2002:a17:902:622:: with SMTP id 31mr22094811plg.171.1543978937053; Tue, 04 Dec 2018 19:02:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543978937; cv=none; d=google.com; s=arc-20160816; b=b4dJ5m1djFCXxNHBBSH/i66GMVKIWyuSrFVgCX1V6GDl6zIueNT5IrZ6MTgliiKnaH m5cL+O1iiB3fCPTcipjlP/ZyA9Tbwn+YKe9iMgBOUJs7w2Ub2NQz6PZ4S/cGAxYuzHPi 15gvRYrSF6rXDREonPaIdk9tVci5Gkc0o49nl+9XRw+GZxX2cIvPkAWH43CjZkELUe+W HccsXFiJU4AEbNVU/2qiFxkeapP8ka2D37/cFTf9KPmKlYz2pyu1a0Gyi16Ktrg/8ffK fwtFVxhGdt2J+OXrz51kYwSWBwxPpNQONNuUqBotKXT37ozYqOohjpP0hjt4IQ9rM3Ir JVqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=T3XEqKyqB/8LE7iZPiELQPs+ckmt9K0/WHT9jmsxIiY=; b=ZdhGyqHeJjazO5oTL3niI804/4L/mE6VpzEBe9PBCwFwcasc/ihHAgNyXKh0P2SUhY XwVq6b7gEJZJ+pZ+4abXBsCWcY66aK2R7aYwrQ+0Xg5Vi0Ja7PpB9rw4K+cFAfZUkDc0 L/UUjR2Lqv/ak/g32i6zT6G+JoMNH7yjTfz/NL1qH+92HQCT3YRkh2WYSYmys1wBdKsX OIAV9JtQfOmDBmted5QTRHbxsCjXJqhqsPojdjfTwJoHO2ujRZfItn1gmshKpzXNr9fS r1jGr27tvzx31rt+XJOqgpJ/mtMzMZAhUUaOIwFgNITEzW7dUpUAVTxb++uHOYRakuM9 UGTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=CP5baTPb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si16317920pgr.252.2018.12.04.19.02.00; Tue, 04 Dec 2018 19:02:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=CP5baTPb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbeLEDBW (ORCPT + 99 others); Tue, 4 Dec 2018 22:01:22 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:37590 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbeLEDBV (ORCPT ); Tue, 4 Dec 2018 22:01:21 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB52xIAQ164993; Wed, 5 Dec 2018 03:01:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=T3XEqKyqB/8LE7iZPiELQPs+ckmt9K0/WHT9jmsxIiY=; b=CP5baTPb1dFG6AaPw4LKr35l3AmCcZIIdrvG1b29mvvt8BXNGhLjJ1xhfgkx00yciKLS uk0oaVE77LcPdUJG8HLWZ81/4TlcSMlOKO+kYDNG054IGFnjY9oKeuJ1nBSIgrxqIlVN 60cGjTHTK4NGCCNy38YShH7UF67aUUKeCX2wVJ5gEWrjKCZCgygMa17BcpUc4fMnbxq0 RFy7ExUleEKpHaPqSahdiPPnXlgte1P18ZGKmbeTj3IYzyvMIyyIZIBrioln4AdGHyYx AkUhBvJnXruFdp1cB9CUKNy4kZ6ZVQ6Hk7XQl/is5aK6I8OMUN2BU+2HSS/+5x3l+fKK 2A== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2p3hqtyy5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Dec 2018 03:01:18 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB531CVr019165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Dec 2018 03:01:13 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB531Caf008230; Wed, 5 Dec 2018 03:01:12 GMT Received: from [10.182.69.118] (/10.182.69.118) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Dec 2018 19:01:12 -0800 Subject: Re: [PATCH V8 0/3] blk-mq: refactor code of issue request directly To: Jens Axboe Cc: ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <1542251558-10517-1-git-send-email-jianchao.w.wang@oracle.com> <88fe68c6-886c-1328-009a-9c7c5fa4ebc9@kernel.dk> From: "jianchao.wang" Message-ID: <154edba0-f4dc-716f-df64-50b23db39138@oracle.com> Date: Wed, 5 Dec 2018 11:01:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <88fe68c6-886c-1328-009a-9c7c5fa4ebc9@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9097 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812050026 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/5/18 10:58 AM, Jens Axboe wrote: > On 11/14/18 8:12 PM, Jianchao Wang wrote: >> Hi Jens >> >> Please consider this patchset for 4.21. >> It refactors the code of issue request directly to unify the interface >> and make the code clearer and more readable. >> >> The 1st patch refactors the code of issue request directly to unify the >> helper interface which could handle all the cases. >> >> The 2nd patch make blk_mq_sched_insert_requests issue requests directly >> with 'bypass' false, then it needn't to handle the non-issued requests >> any more. >> >> The 3rd patch replace and kill the blk_mq_request_issue_directly. > > I'd love to get this queued up, the direct dispatch path is a mess and > it's even now been known to cause corruptions... I'm going to queue > up the direct dispatch fix shortly, and apply it to for-4.21/block > as well. Any chance you can respin this on top after that? > OK, I will do now. Thanks Jianchao