Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V8 0/3] blk-mq: refactor code of issue request directly
To:     "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc:     ming.lei@redhat.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1542251558-10517-1-git-send-email-jianchao.w.wang@oracle.com>
 <88fe68c6-886c-1328-009a-9c7c5fa4ebc9@kernel.dk>
 <154edba0-f4dc-716f-df64-50b23db39138@oracle.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <4383ef8a-4418-e341-d36d-bcbc0557c4a9@kernel.dk>
Date:   Tue, 4 Dec 2018 20:07:13 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <154edba0-f4dc-716f-df64-50b23db39138@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/4/18 8:01 PM, jianchao.wang wrote:
> 
> 
> On 12/5/18 10:58 AM, Jens Axboe wrote:
>> On 11/14/18 8:12 PM, Jianchao Wang wrote:
>>> Hi Jens
>>>
>>> Please consider this patchset for 4.21.
>>> It refactors the code of issue request directly to unify the interface
>>> and make the code clearer and more readable.
>>>
>>> The 1st patch refactors the code of issue request directly to unify the
>>> helper interface which could handle all the cases.
>>>
>>> The 2nd patch make blk_mq_sched_insert_requests issue requests directly
>>> with 'bypass' false, then it needn't to handle the non-issued requests
>>> any more.
>>>
>>> The 3rd patch replace and kill the blk_mq_request_issue_directly.
>>
>> I'd love to get this queued up, the direct dispatch path is a mess and
>> it's even now been known to cause corruptions... I'm going to queue
>> up the direct dispatch fix shortly, and apply it to for-4.21/block
>> as well. Any chance you can respin this on top after that?
>>
> 
> OK, I will do now.

Thanks!

-- 
Jens Axboe