Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9014169imu; Tue, 4 Dec 2018 19:18:56 -0800 (PST) X-Google-Smtp-Source: AFSGD/VwWwPcAYbi4WofdFW/ES4Q2sVdx839nvto4a/t6RwKGOA2TW3pmvLL/igN/WJ78isIk8QW X-Received: by 2002:a17:902:7581:: with SMTP id j1mr22766295pll.308.1543979935953; Tue, 04 Dec 2018 19:18:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543979935; cv=none; d=google.com; s=arc-20160816; b=XcdwQQS9ToQF+4GQFXyXEQ6zzJcjDdMWmDhAXWcJu6+12hlfZ2K5BK2fqHZdPwGdPE DD6UJsOJVC/nIfsLJgrHQYtTBoGlZoVMry1V4bRL0V0jGBdoobCnC/P5aJ49E64tVJh3 Doq9I/M0BlqibO3VZn4M1mFBuMvzpo3NW+QZLoBSoQ8Qz9nCBZVgnBez4Mj02fzkHhdj K8VBJnN56t5ejmHO32Uw5sobjJwH9SaxWayTV1S9zblZUROpIkdzFcACoKMh9jXjZaLc QLR5iqbONhiuJ3hjXk2gFCXzq7UWjZtot4q8hGrhTpF3jnX81N1+IhF9n3qCUUMieapT fCGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=R0DWsMZrObglW2zA0/UHdOcvbey0vSWCz623dOeNnbU=; b=CgDpER1/dcFS+GrrXbtmX3kIZ7d5C4obUCH+nfjejrU89mEk6lz2MHTBcqMx73EMNR eacPNls/wL1HhLjdWRFTaBVL/1e6CDVEN1gBrZHYNzyC0I+ck3vshW2n7g0LzKvSZz3t L3/jnu4ymwRjoqg6RtvZW7KO4YBEnGs3q13MUOUDlX/X4Pt+Ev8cYjTiNYO+97HG8x+L 7b9GsTAODjzQByFJ6lwlwP7ppXgaqVzrMCZlf/jFdhcZd0E0mxHC79XdOsxtYHk1OHeJ PNhxl9kI4vkWRbFauYnZxh6O/Yf3qvuA7yXExHSIf2o8cOIj8eXFOH5m54H92KYC97sk ZfgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=enji7Fix; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y17si18535068pll.10.2018.12.04.19.18.40; Tue, 04 Dec 2018 19:18:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=enji7Fix; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726092AbeLEDSF (ORCPT + 99 others); Tue, 4 Dec 2018 22:18:05 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33796 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbeLEDSF (ORCPT ); Tue, 4 Dec 2018 22:18:05 -0500 Received: by mail-wr1-f65.google.com with SMTP id j2so18092177wrw.1 for ; Tue, 04 Dec 2018 19:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R0DWsMZrObglW2zA0/UHdOcvbey0vSWCz623dOeNnbU=; b=enji7FixFOHWQnScPC6lRtEQ97E4xNzNAyjfKFD3NHPr6xAbHYfjfJZVXb62n3cqCF K3vPNz9ItOqDJ8jwBrv3zGAhgkH2NLsPLKYyG+AqaSTGv1ybHm8TYk5xJcAPYu1Yw4Us Ze+QKO5X7C3a4xB9FGkimYsi+Dro3xcn8x8Vs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R0DWsMZrObglW2zA0/UHdOcvbey0vSWCz623dOeNnbU=; b=p3cby2plI1mE5563SFU5uo2cq9UUTqot0bvVLIU2Sx7u19f/QZBVok4zmvJarmfcwU UXznbaLLx+fOCG8Jl0erIJVvQOYDS4lVnM/8+DjfO3juCIR5RhOa+XFr2my9s5oORE1T oXrYyjSDigjPU569+bgIk8I5+KDrZiNXHlcUSfiBj0vCVK0hpqpvGdhWRY/sERxPVPmC NIpxkIvJvdeOR0bq4lL1q/7DJ3rrhWmE22B/gzxiqNeka/n1CL6LL0LB7lqd+dXtS+wy T0XQmfWuWrlWtSsaoyZoI+LxYSuSA+bXuJXpVprYwLEKGtmfDorKfhSStqExa1oxUcqI vA4Q== X-Gm-Message-State: AA+aEWaLSAUlueuE5z7ZdI7ykDT7sVPjKis2FC1LEVfSbKmPFrynW2Jz dRe8OyiKNEx0S79uVEdPNhGbE7WIyd3ppV7tfbtA9g== X-Received: by 2002:a5d:4d88:: with SMTP id b8mr1989730wru.54.1543979883872; Tue, 04 Dec 2018 19:18:03 -0800 (PST) MIME-Version: 1.0 References: <1539702680-3746-1-git-send-email-srinath.mannam@broadcom.com> In-Reply-To: From: Srinath Mannam Date: Wed, 5 Dec 2018 08:47:52 +0530 Message-ID: Subject: Re: [PATCH v5 0/3] Stingray thermal driver support To: Florian Fainelli Cc: Daniel Lezcano , Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Linux Kernel Mailing List , BCM Kernel Feedback Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Could you please provide your feedback to this patch series? Regards, Srinath. On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli wrote: > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > These patches adds the stingray thermal driver and its > > corresponding DT nodes with documentation. > > Can we get feedback from the thermal maintains whether this is > acceptable or not? > > > > > Changes from v4 > > - Addressed Rob Herring comments on DT parameters and > > thermal driver architecture. > > - Removed brcm,max-crit-temp DT parameter > > - Changed driver to thermal sensor registration model. > > - Added trip DT properties. > > > > Changes from v3 > > - Addressed Daniel lezcano comments. > > - Elaborated commit description of thermal driver patch. > > - Added brcm,max-crit-temp DT parameter. > > > > Changes from v2: > > - All stingray TMON DT nodes are combine together into single. > > Temperature registers are combined into one mem resource. > > brcm,tmon-mask parameter has available TMONs mask value. > > - All available TMONs are initialized together in single > > instance of driver probe call. > > > > Changes from v1: > > - Fixed auto build sparce warning. > > > > Pramod Kumar (3): > > dt-bindings: thermal: Add binding document for SR thermal > > thermal: broadcom: Add Stingray thermal driver > > arm64: dts: stingray: Add Stingray Thermal DT support. > > > > .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++ > > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++ > > drivers/thermal/Kconfig | 3 +- > > drivers/thermal/broadcom/Kconfig | 9 ++ > > drivers/thermal/broadcom/Makefile | 1 + > > drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++ > > 6 files changed, 344 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > -- > Florian