Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yueyi Li <liyueyi@live.com>
To:     Wei Yang <richard.weiyang@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "mhocko@suse.com" <mhocko@suse.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] memblock: Anonotate memblock_is_reserved() with
 __init_memblock.
Thread-Topic: [PATCH v2] memblock: Anonotate memblock_is_reserved() with
 __init_memblock.
Thread-Index: AQHUiryuEY3GC2m5nk+tSrupm8LKDqVt5pqAgAG9JYA=
Date:   Wed, 5 Dec 2018 05:37:37 +0000
Message-ID: <BLUPR13MB02891C690507E91D0581E79FDFA80@BLUPR13MB0289.namprd13.prod.outlook.com>
References: <BLUPR13MB02893411BF12EACB61888E80DFAE0@BLUPR13MB0289.namprd13.prod.outlook.com>
 <20181204030415.zpcvbzh5gxz5hxc6@master>
In-Reply-To: <20181204030415.zpcvbzh5gxz5hxc6@master>
Accept-Language: en-US, zh-CN
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [CeEi051hXt7cDS7P9xY52aTnRgD6aoho]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;BY2NAM01HT032;6:a/L9r4bc5zfDE7hSL+rhBfkb3uLK7p9xa7kiTBOb44B7esFxhg2ZTMnNC9gtYVeVOGKtW6EK8Wt33xJ/uH7K5BmTod3eIfklBDZhUK5NIJIYRVVmrUf83MpEZAqXFbA4AfkrVLL3iHEuz3HQacOpeUfhi8RYEv8knUFzoCP+AelEqJ08W9BazlmvWIjMGCevTALqbeSbkiwVc/WTnjXcCGWkUeCk3/THKZAeLX+YwiGJUITE0kmItAwJ8Bt4hAWjwvmQqdGqCLads1rDGgNQWD1oZL4ZIEBVyRNts2+upEMJGce7XR1hf0YdEje6RCLCwGXFRtfDZiXG9ETEPLAyAevRrDKtI+FdQ2qftpCKBVllAIU3okyZcXX6+wIopQezaK+hoQkOHgv9NLk5lqSDNA7f1O521npITPksiWPhZyF4H8lrk7AOIgrpikAJ9O0XGDM9UIT0R2H/FxxIMYjVpA==;5:n9qpyfWtUAiZO/AgjkWPx5r3QHSzQtVMGiKCdCBHm7ILkIdFvtiCbk21P/j++P/egGUlBFeaNn7SW2auZWafbg4ttrmyqGGJKhKfysoXIIx41asrGR7NFXkCO5R6UzGCgvBen9twZFWIwdLTXi+yxxJhGpFj3OBAsS8VVcYTOgM=;7:u/4QJjB8CUcQ7LpUAKjqyufiBPYt1y6OgeKx3Ubnkd/uRsCVxVXt71YnSORrySMe7S9mnQkGDSEU8+gjsQJP+Fy0FdfJQA+dPKAoijmh2tCgcBMmYyARyKmaAwLIe5AQq/llldzMbZvICA4G3/U70g==
x-incomingheadercount: 50
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101475)(1601125500)(1701031045);SRVR:BY2NAM01HT032;
x-ms-traffictypediagnostic: BY2NAM01HT032:
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(4566010)(82015058);SRVR:BY2NAM01HT032;BCL:0;PCL:0;RULEID:;SRVR:BY2NAM01HT032;
x-microsoft-antispam-message-info: b9JYAZlNy651bcZj8I9cRWpYG4VT9JcaXIsNZv9XFGAILJ9VRCwyiICd+uKpsEYI
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <3F6DD7343CFD8C43BA08FE6D04863379@namprd13.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: live.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: f12efbb0-867f-4c93-8261-502eceebfafa
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ce09e1e-5e28-468e-3c58-08d65a73c32f
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: f12efbb0-867f-4c93-8261-502eceebfafa
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2018 05:37:37.2520
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2NAM01HT032
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2018/12/4 11:04, Wei Yang wrote:
> On Mon, Dec 03, 2018 at 04:00:08AM +0000, Yueyi Li wrote:
>> Found warning:
>>
>> WARNING: EXPORT symbol "gsi_write_channel_scratch" [vmlinux] version gen=
eration failed, symbol will not be versioned.
>> WARNING: vmlinux.o(.text+0x1e0a0): Section mismatch in reference from th=
e function valid_phys_addr_range() to the function .init.text:memblock_is_r=
eserved()
>> The function valid_phys_addr_range() references
>> the function __init memblock_is_reserved().
>> This is often because valid_phys_addr_range lacks a __init
>> annotation or the annotation of memblock_is_reserved is wrong.
>>
>> Use __init_memblock instead of __init.
> Not familiar with this error, the change looks good to me while have
> some questions.
>
> 1. I don't see valid_phys_addr_range() reference memblock_is_reserved().
>     This is in which file or arch?

Yes,  I modified valid_phys_addr_range() for some other debugging.

> 2. In case a function reference memblock_is_reserved(), should it has
>     the annotation of __init_memblock too? Or just __init is ok? If my
>     understanding is correct, annotation __init is ok. Well, I don't see
>     valid_phys_addr_range() has an annotation.
> 3. The only valid_phys_addr_range() reference some memblock function is
>     the one in arch/arm64/mm/mmap.c. Do we suppose to add an annotation t=
o
>     this?

Actually, __init_memblock is null in arch arm64, this warning is due to
CONFIG_DEBUG_SECTION_MISMATCH enabled,  the help text in lib/Kconfig.debug.


Thanks,
Yueyi