Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9222498imu; Wed, 5 Dec 2018 00:47:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/UHFpP0xR6WLYjKI4j7k+2FT4GL5JwzBOaw94sypLs+gDzWimhy8u5IE8a0yWwZuyvTtcVz X-Received: by 2002:a62:62c5:: with SMTP id w188mr23708084pfb.160.1543999631278; Wed, 05 Dec 2018 00:47:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543999631; cv=none; d=google.com; s=arc-20160816; b=BZq3WSi/h8VnaLCFktO7fOwE/QNF8wbnLBpV8REBnC0B4ZX4VJditPvBwEjXPSnjGV +pFhlnkGmP7OOtkotW6NLd+ozt2TqQ8ZzarH2JxH7+D/jgqaKPjPcHHU0BzIQwPoF40B qhM21nSAvbtDj29fuIoYtLMetxImkIobsNa60D+Yw7KcqZIYdwbPUsAau8OMcFYT/9A2 R4R90rsAfOFYEZucB/3LSD9/cWwv/xJKIp36zbIeOxfpFP0somRhtCT1MpDr+PLW5XWO I92KcaZXH4pKN0UJVrun96w7b2qqVtvY5kChjTgX7feS50YLmoUgKsWtwp6ZkNIQHLKU kwLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tSxmF107WYDjrdc+w6Ceuly74HZXqgjGqh60O+5kNjk=; b=A47D4pp8JNDPXVWOL6C5hBW+qYhnN9l0NGb4EKTeHjwonAItJoot52kwir41d2KXA8 K5+aK2NE2zUX0Dyl0BbwIZkotLBz9OqJ8uEbRlOsAcb/UmSY2J5GBbji83wBbyiIHNxC RKrrL2mANfDsl6fXXNurhaowBxHETwXgcupptgul40C+5S//ivQiWDgIgUYePAXfzuNz H75Ly4d3J2g4JBP46DZQAAQ8yNvzoN/FKT7xVD3K6ebeG7a7wqe542io6oyTAySLrzIm 7eETS0wPAVfGwfLO550ebNK6Gld9RtTWMONqsGXk0ZWWklmv1PEG/luw9mPnXqV7fz9r jauQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MgjY+yAl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d16si21849786plj.104.2018.12.05.00.46.55; Wed, 05 Dec 2018 00:47:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MgjY+yAl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbeLEIqG (ORCPT + 99 others); Wed, 5 Dec 2018 03:46:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:37658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbeLEIqG (ORCPT ); Wed, 5 Dec 2018 03:46:06 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 092DB206B7; Wed, 5 Dec 2018 08:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543999565; bh=L/68rIbG4jMAlNrx161Y2/eaqtv3L6sB0TXEJFVkv+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MgjY+yAl7yEWWL0aQUNf28EtzqPDfM9X84Octy7JZNEyImhJqrxoFUA1WMF9XMFCf ZnRBuD6djFGrNsDNFYN0ruCA6VFKFxQrLv/eK4iW8nmucADT29FycHAJ3RyqI72G2Y kM6pR0mLkOGZ67ToRdXU5wIrMDXHvfzP3PNdaST8= Date: Wed, 5 Dec 2018 09:46:03 +0100 From: Greg Kroah-Hartman To: Cristian Sicilia Cc: Bryan O Donoghue , Johan Hovold , Alex Elder , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis Message-ID: <20181205084603.GA4987@kroah.com> References: <6087f45a8a4544fa6c671d8b42928fb48194e66e.1543956271.git.sicilia.cristian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6087f45a8a4544fa6c671d8b42928fb48194e66e.1543956271.git.sicilia.cristian@gmail.com> User-Agent: Mutt/1.11.0 (2018-11-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote: > Aligned some parameters to the previous parenthesis. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/greybus/loopback.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > index e4d42c1..1085e06 100644 > --- a/drivers/staging/greybus/loopback.c > +++ b/drivers/staging/greybus/loopback.c > @@ -638,7 +638,8 @@ static int gb_loopback_async_transfer(struct gb_loopback *gb, u32 len) > retval = gb_loopback_async_operation(gb, GB_LOOPBACK_TYPE_TRANSFER, > request, len + sizeof(*request), > len + response_len, > - gb_loopback_async_transfer_complete); > + gb_loopback_async_transfer_complete > + ); Ick, why do this? That's not really needed. thanks, greg k-h