Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shuah Khan <shuah@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Johan Hovold <johan@kernel.org>,
        Jaejoong Kim <climbbb.kim@gmail.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Roger Quadros <rogerq@ti.com>,
        Manu Gautam <mgautam@codeaurora.org>,
        martin.petersen@oracle.com, Bart Van Assche <bvanassche@acm.org>,
        Mike Christie <mchristi@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Colin Ian King <colin.king@canonical.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        v.anuragkumar@gmail.com, Thinh Nguyen <thinhn@synopsys.com>,
        Tejas Joglekar <tejas.joglekar@synopsys.com>,
        Ajay Yugalkishore Pandey <APANDEY@xilinx.com>,
        Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Subject: Re: [PATCH v7 05/10] usb: dwc3: make controller clear transfer resources after complete
In-Reply-To: <1543662811-5194-6-git-send-email-anurag.kumar.vulisha@xilinx.com>
References: <1543662811-5194-1-git-send-email-anurag.kumar.vulisha@xilinx.com> <1543662811-5194-6-git-send-email-anurag.kumar.vulisha@xilinx.com>
Date:   Wed, 05 Dec 2018 11:01:37 +0200
Message-ID: <878t142vpq.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> writes:
> @@ -2487,6 +2497,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *d=
wc,
>  	}
>=20=20
>  	switch (event->endpoint_event) {
> +	case DWC3_DEPEVT_XFERCOMPLETE:
> +		if (!dep->stream_capable)
> +			break;
> +		dep->flags &=3D ~DWC3_EP_TRANSFER_STARTED;
> +		/* Fall Through */

instead, let's add a proper handler for this:

dwc3_gadget_endpoint_transfer_complete(dep, event);

That handler should be "self-sufficient". IOW, we shouldn't have this
fall through here. This means that the other patch where you modify
dwc3_gadget_transfer_in_progress() shouldn't be necessary, since that
event shouldn't run for stream capable endpoints.

While rewriting the patches, please rebase on my testing/next as I have
applied a few of the patches in this series.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlwHk/EACgkQzL64meEa
mQZUHg/+PRlIWWGQLUO9kDDrS7skRCVrHgyE3hR6y3QggB0XgQj2F7+soB1TlxRC
BJdjXDQiiJtFm69Du80UbD4XMDre/2EGiv8JHIIigvVjkHENzF5cNu4nzBfjpEbF
keb17zVbkXK5ffDq/KemVag+a0uu5DNp1JYOVL3jqD1EJhkYiVFFfoL4/uAICgw9
bk5TuoZiWtoLKiXpeAa5Bx8ZEAB7lgw6GFkNsUQRvchO/7uyidmRv99J4Hm9l2Ld
q6CU2izuswPyzepiRuZzvdNJPd3gQvsIfpyjsR7poMm6gEdCCgruOgT2r4eawX41
1t1Kzf0BigyG27nkoRgK7YYVZ3GvefGiA3ybnEut+qY+pEJ4+oIFYWkYXf9mILON
KpG4lYxk0F7ItGZWm+/86DflGTJl4UIjWcdnmcd3DXjME+cTuOr4g+70HYZfrw56
F4Sh+scpOOwMRAiJ4XbwIuj78VyFykpWi4zTpKkgkWtey9I3e9sFFABOzMuOo0yW
SyAufcpXZhU5qUSAPInU0CoF0rexZzcWTJuamvVnlL53AImZmxNTxRb8bRsq3unD
/AiMlI+XMSFoBK4238NSCN8D4FFtAkYculLyg71G6DhrwQyyYzRodcqHusLqA6Va
uw61Z08aH+nnc/Fq7jHy3mvc2WuAqnmKxNSo0A2l62CwIQO6jJU=
=PHEt
-----END PGP SIGNATURE-----
--=-=-=--