Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265681AbUAQQ6p (ORCPT ); Sat, 17 Jan 2004 11:58:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266072AbUAQQ6o (ORCPT ); Sat, 17 Jan 2004 11:58:44 -0500 Received: from phoenix.infradead.org ([213.86.99.234]:14094 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S265681AbUAQQ6m (ORCPT ); Sat, 17 Jan 2004 11:58:42 -0500 Date: Sat, 17 Jan 2004 16:58:28 +0000 From: Christoph Hellwig To: Doug Ledford Cc: Marcelo Tosatti , Arjan Van de Ven , Martin Peschke3 , Jens Axboe , Peter Yao , linux-kernel@vger.kernel.org, linux-scsi mailing list , ihno@suse.de Subject: Re: smp dead lock of io_request_lock/queue_lock patch Message-ID: <20040117165828.A4977@infradead.org> Mail-Followup-To: Christoph Hellwig , Doug Ledford , Marcelo Tosatti , Arjan Van de Ven , Martin Peschke3 , Jens Axboe , Peter Yao , linux-kernel@vger.kernel.org, linux-scsi mailing list , ihno@suse.de References: <20040112151230.GB5844@devserv.devel.redhat.com> <20040112194829.A7078@infradead.org> <1073937102.3114.300.camel@compaq.xsintricity.com> <1074345000.13198.25.camel@compaq.xsintricity.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <1074345000.13198.25.camel@compaq.xsintricity.com>; from dledford@redhat.com on Sat, Jan 17, 2004 at 08:10:00AM -0500 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 21 On Sat, Jan 17, 2004 at 08:10:00AM -0500, Doug Ledford wrote: > 4) The last issue. 2.6 already has individual host locks for drivers. > The iorl patch for 2.4 adds the same thing. So, adding the iorl patch > to 2.4 makes it easier to have drivers be the same between 2.4 and 2.6. > Right now it takes some fairly convoluted #ifdef statements to get the > locking right in a driver that supports both 2.4 and 2.6. Adding the > iorl patch allows driver authors to basically state that they don't > support anything prior to whatever version of 2.4 it goes into and > remove a bunch of #ifdef crap. Well, no. For one thing all the iorl patches miss the scsi_assign_lock interface from 2.6 which makes drivers a big ifdef hell (especially as the AS2.1 patch uses a different name for the lock as 3.0), and even if it was there the use of that function is strongly discuraged in 2.6 in favour of just using the host_lock. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/