Subject: Re: [RFC] kill sleep_on
From: David Woodhouse <dwmw2@infradead.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <40098251.2040009@colorfullife.com>
References: <40098251.2040009@colorfullife.com>
Content-Type: text/plain
Message-Id: <1074367701.9965.2.camel@imladris.demon.co.uk>
Mime-Version: 1.0
Date: Sat, 17 Jan 2004 19:28:21 +0000
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 22

On Sat, 2004-01-17 at 19:43 +0100, Manfred Spraul wrote:
> Virtually all sleep_on / interruptible_sleep_on users are racy. Actually
> there is only one safe case: if both wakeup and sleep happen under
> lock_kernel.
> Any objections against killing it entirely? Or what about marking it as
> deprecated, as the first step towards killing it?
> 
> I'll follow with two patches that remove it from shaper and sunrpc/sched
> - shaper is racy, rpciod_down is only safe if called with lock_kernel.

Deprecate it in 2.7.0 and add BUG_ON(BKL not held) to it. Not before
time.

-- 
dwmw2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/