Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181204194044.9506-1-anders.roxell@linaro.org> <20181204173258.6de70c66@vmware.local.home>
In-Reply-To: <20181204173258.6de70c66@vmware.local.home>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Wed, 5 Dec 2018 11:50:40 +0100
Message-ID: <CADYN=9JVZ0vRbon9DkxuUx4sYNMuCYyoYL1gydCLrdjRJGS4+g@mail.gmail.com>
Subject: Re: [PATCH v3] tracing: add cond_resched to ftrace_replace_code()
To:     rostedt@goodmis.org
Cc:     mingo@redhat.com, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Kees Cook <keescook@chromium.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 4 Dec 2018 at 23:33, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue,  4 Dec 2018 20:40:44 +0100
> Anders Roxell <anders.roxell@linaro.org> wrote:
>
> > When running in qemu on an kernel built with allmodconfig and debug
> > options (in particular kcov and ubsan) enabled, ftrace_replace_code
> > function call take minutes. The ftrace selftest calls
> > ftrace_replace_code to look >40000 through
> > ftrace_make_call/ftrace_make_nop, and these end up calling
> > __aarch64_insn_write/aarch64_insn_patch_text_nosync.
> >
> > Microseconds add up because this is called in a loop for each dyn_ftrace
> > record, and this triggers the softlockup watchdog unless we let it sleep
> > occasionally.
> >
> > Rework so that we call cond_resched() if !irqs_disabled() && !preempt_count().
>
> This isn't urgent is it?

No, it is not urgent. I'm trying to get allmodconfig to boot on arm64.

> That is, it doesn't need a stable tag?

Also I don't think its a regression, since clearly nobody has ever been
able to boot an arm64 allmodconfig kernel or anything close to that.

Cheers,
Anders