Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9363674imu; Wed, 5 Dec 2018 03:41:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/WYuxrEkSKtuEaR8soPkYf31gCuwT+ABg2njotb4gTQ9vUa1k6/b3h3Ea4nbqMsmLwziUi8 X-Received: by 2002:a63:334a:: with SMTP id z71mr20325239pgz.400.1544010065235; Wed, 05 Dec 2018 03:41:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544010065; cv=none; d=google.com; s=arc-20160816; b=KUCH8q5VF0ckaAKPYAUyti3OOwwD84A0M/vouPQHuBhiRyiwdnNK/3RmIy9B1MtoLw if4lgNK8ImXHadaJerilhRss9fWfjiLk0ru83bx2LN6eqNoZnMuKvIJTooyuDWo1TAkP X8d8Od6rAgXfpCbihG/e4qaAS2egZgk2OG9Bz1azsDNOC5wk4XHNI+6Yt+AOugMYiQ0P vyWaJWN7WOMIXLqP+usAzbR2QehqUxFzXJGUkysjiw6OZq1zZGMgT6vYfQ69I3lk06wP wlAdfzXUJpYkQ5fDGAAE1fIew+7b5pHrbbzVsvHVeeCYv9jjqWHr3tdkU7QJk4q1fj8O XA+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zttyRNqDSDS+94i6XcCb2sqXfb3rZ8CFxKW0D8ClFX0=; b=Gvuo1ugBOWTDqwx0UX8Qq24vtcQjvx4riMbxM2brOLpPDdEE0IUALQTUddS+pUrVTf aNvZPKxfuiJP4HGm0wXPovAhnTXgAZ52Ae+GEUo3bhw7+9aOutY2liUvr+YbLra3D/9m /lR40O0YIq4I+HZmojLT91OjtnMzzn6GkjZ0VORq75Ur1UzFCY7P3uhFcROdZ2KpYkEG AAKTQREC0N/iyrJOzQFdUVSyZ6E7se/4q/zrbDHI+88jUXVP9DGvoINe4X2CA9FJUOci J7pSCDVbFhAkp3Ox1ucHS0JH6gcp9lNlaltUfM9DoXFxwjJRresc6MuWrqkclCnAAXyq KZww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h6si20567420plk.231.2018.12.05.03.40.50; Wed, 05 Dec 2018 03:41:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727758AbeLELkC (ORCPT + 99 others); Wed, 5 Dec 2018 06:40:02 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:53256 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726866AbeLELkB (ORCPT ); Wed, 5 Dec 2018 06:40:01 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wB5BdYcL003371; Wed, 5 Dec 2018 05:40:00 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail3.cirrus.com ([87.246.76.56]) by mx0a-001ae601.pphosted.com with ESMTP id 2p3rk7ffqf-1; Wed, 05 Dec 2018 05:40:00 -0600 Received: from EX17.ad.cirrus.com (ex17.ad.cirrus.com [172.20.9.81]) by mail3.cirrus.com (Postfix) with ESMTP id 6AA21611C8B0; Wed, 5 Dec 2018 05:42:52 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 5 Dec 2018 11:39:59 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wB5BdxxA006410; Wed, 5 Dec 2018 11:39:59 GMT Date: Wed, 5 Dec 2018 11:39:59 +0000 From: Charles Keepax To: Paul Gortmaker CC: Lee Jones , , Linus Walleij , Subject: Re: [PATCH 21/22] mfd: wm8350-core: drop unused MODULE_ tags from non-modular code Message-ID: <20181205113959.GB16508@imbe.wolfsonmicro.main> References: <1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com> <1543811009-15112-22-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1543811009-15112-22-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812050108 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 02, 2018 at 11:23:28PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM8350 > drivers/mfd/Kconfig: bool > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the driver there is no doubt it is builtin-only. > > We delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > We replace module.h with init.h and export.h ; the latter since the > file does export some symbols. > > Cc: Linus Walleij > Cc: Lee Jones > Cc: patches@opensource.cirrus.com > Signed-off-by: Paul Gortmaker > --- Acked-by: Charles Keepax Thanks, Charles