Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9411692imu; Wed, 5 Dec 2018 04:31:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uw8LKvoRDLtErTfoDn34DA2RAlBk1ENxyKOe0bIks2YCooHG1hBDnQ0dgLbiYnodTfTyMF X-Received: by 2002:a62:5716:: with SMTP id l22mr24851369pfb.16.1544013067465; Wed, 05 Dec 2018 04:31:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544013067; cv=none; d=google.com; s=arc-20160816; b=TdLPitw538ziDpRv8v8IBAF6E1S18nv3HLD8QkdqEXens8D0xME0ONndvZWTXTBc3o PS1wC0b+EnChl5gCjOfhe0HZUyHmlCtj15Hz2pVDxsxE4VcegD56jQzOeZ+wwsqalbvD 7shW9wWgNqiOIIG0jZ7CQhg4y2YpzlxHn1bb7nv3ciwYdSCBRA/xmLyhNhFGfwP95rHj 56DZ5V1hJ4PAlnB20WxxiL8ptaa3FKoV/wfSSfKWWZJjB+OdbYTxbHqjxt/owzjwRrV4 JeoekaElJEWdBKMNwJsOdhREDLaINsD93c3v3q0YONcZ6o9AnmCBZfzVpR8bkRKrCyrw mRJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=5f1RX8PgtIxd6340o2+u9UfUNpwJ2JR8T6eBwDHn5iE=; b=tuUF/dLEpaNjtD32iej7pf+Fyn0yHmhcUIzHe8cRf8Qgg5xvJx5R++pQmWyWPTHag2 nRK2nBQiX/7McWjTi5bwNTNZoQFfs7ZwWxP6OkkCj9wkb6iJivmMwdpAG9KPw4hRwW2Z 9RUQ0ggy3j1WEKCO9eZjK3dsL0ARXNQWZEnI1sYj0Xg7P8Z4tBvdzs2V0f819vFHA8/F Ouz9b5x3q2eqAqATKKoG/A6nIO5ipwXMq47gcp5xzoFmRMcBfUY1g+xJBrMnmf7YxjTL uDIo88fy/2qahFEZ9jLM5m/qlNVsalMTTc2SaiL8V142Kt4n2WKwTBi5hj78lMYc5E/9 GEeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l185si18262152pgd.253.2018.12.05.04.30.52; Wed, 05 Dec 2018 04:31:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727868AbeLEM36 (ORCPT + 99 others); Wed, 5 Dec 2018 07:29:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48512 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727267AbeLEM36 (ORCPT ); Wed, 5 Dec 2018 07:29:58 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F33E2307EAA1; Wed, 5 Dec 2018 12:29:57 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-65.ams2.redhat.com [10.36.117.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4DF582789; Wed, 5 Dec 2018 12:29:11 +0000 (UTC) From: David Hildenbrand To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-mediatek@lists.infradead.org, David Hildenbrand , David Airlie , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Michal Hocko , Matthew Wilcox Subject: [PATCH RFC 1/7] agp: efficeon: no need to set PG_reserved on GATT tables Date: Wed, 5 Dec 2018 13:28:45 +0100 Message-Id: <20181205122851.5891-2-david@redhat.com> In-Reply-To: <20181205122851.5891-1-david@redhat.com> References: <20181205122851.5891-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 05 Dec 2018 12:29:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The l1 GATT page table is kept in a special on-chip page with 64 entries. We allocate the l2 page table pages via get_zeroed_page() and enter them into the table. These l2 pages are modified accordingly when inserting/removing memory via efficeon_insert_memory and efficeon_remove_memory. Apart from that, these pages are not exposed or ioremap'ed. We can stop setting them reserved (propably copied from generic code). Cc: David Airlie Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Michal Hocko Cc: Matthew Wilcox Signed-off-by: David Hildenbrand --- drivers/char/agp/efficeon-agp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c index 7f88490b5479..c53f0f9ef5b0 100644 --- a/drivers/char/agp/efficeon-agp.c +++ b/drivers/char/agp/efficeon-agp.c @@ -163,7 +163,6 @@ static int efficeon_free_gatt_table(struct agp_bridge_data *bridge) unsigned long page = efficeon_private.l1_table[index]; if (page) { efficeon_private.l1_table[index] = 0; - ClearPageReserved(virt_to_page((char *)page)); free_page(page); freed++; } @@ -219,7 +218,6 @@ static int efficeon_create_gatt_table(struct agp_bridge_data *bridge) efficeon_free_gatt_table(agp_bridge); return -ENOMEM; } - SetPageReserved(virt_to_page((char *)page)); for (offset = 0; offset < PAGE_SIZE; offset += clflush_chunk) clflush((char *)page+offset); -- 2.17.2