Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20181201154428epcas4p3a1a5c9c576027b1c56f8dd1510b32187@epcas4p3.samsung.com>
 <20181201154151.14890-1-linus.walleij@linaro.org> <d6b5f384-51aa-0e99-7e88-a1debcf5eca3@samsung.com>
 <CACRpkdYQ5cy1-8wu--deF0kdzrRGVJ_teNh2LRF7tr9vyh+oHw@mail.gmail.com>
 <455ced52-e444-66f2-7dec-9d37bdd5116c@samsung.com> <CACRpkdbVSEYJpSb6Uzji158gL7WHu_Bfpw2gK-qo2s66dWjY7Q@mail.gmail.com>
 <b1ecf322-92bd-79e9-9c8c-b87a534afc11@samsung.com>
In-Reply-To: <b1ecf322-92bd-79e9-9c8c-b87a534afc11@samsung.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 5 Dec 2018 15:32:19 +0100
Message-ID: <CACRpkdbJEYBQYF2T+UT-t0OYGs1Dj5M7AMEXJWdE282njXfcFw@mail.gmail.com>
Subject: Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Dec 5, 2018 at 3:30 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:

> > I just sent a fix for that, subject:
> > "gpio: devres: Handle nonexclusive GPIOs"
> > you could perhaps try it on top of this
> > series? I intend to merge that separately as a fix for current,
> > as it is a bug.
>
> Those 2 warnings were worrying me and I finally found! devres_*
> functions require to pass a pointer to the pointer as match_data, so
> desc must be passed as &desc to devres_find() and devres_destroy()
> functions, otherwise they always return -ENOENT. I will comment
> respective lines in your patches then.

Ah thanks so much Marek!

I will follow up with a v4 patch set immediately once I have it nailed
down. Devres is tricky, and I'm not the smartest...

Yours,
Linus Walleij