Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 5 Dec 2018 15:35:34 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 1/1] regmap: irq: handle HW using separate mask bits for
 edges
Message-ID: <20181205153534.GF6205@sirena.org.uk>
References: <20181204181550.29122-1-brgl@bgdev.pl>
 <20181204181550.29122-2-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Y1L3PTX8QE8cb2T+"
Content-Disposition: inline
In-Reply-To: <20181204181550.29122-2-brgl@bgdev.pl>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Y1L3PTX8QE8cb2T+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 04, 2018 at 07:15:50PM +0100, Bartosz Golaszewski wrote:

> Let's reuse the existing type fields in struct regmap_irq to make
> regmap_irq_chip available to such HW.

I'm not sure this is ideal, it makes the interface less clear for users
especially since there's nothing in the comments in the header that
users will look at which mentions the feature.

> If the type_base and mask_base offsets are the same - assume there
> are separate bits for falling and rising edge interrupts and use
> the value previously written to the type buffer by the set_type()
> callback instead of the entire mask specified for this interrupt
> so that we only enable the requested edge interrupts.

This feels like it's very strongly tied to a specific implementation of
the feature and TBH I'm somewhat unclear on what this ends up concretely
meaning.  It sounds like this hardware represents the two edges as
separate interrupts but you want to combine them into one but I can't
see exactly how the interrupt number gets mapped with your change.

--Y1L3PTX8QE8cb2T+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlwH8EUACgkQJNaLcl1U
h9CysAf/T8OMx17dmpEeG9+TJkFq7jreKtDyE30h8Q6yzJo5br3qYq/PUr2nO4a+
pil0dxTuZpl13uE5RKmZkD/YF3PP4QBTQMXE09yd8iMOe/HDHUbQh6yYzGpHmtir
DCQ0Q5VutgY3MqotuG6lUbeKxAHTRcrQeYzoeIecP/xsa68U+WmnOYtWg6sP9Goh
pcdWGSPAw5EOtGtwToGPBgdgv163GavsnFjxYzq7jBgsMWXxkqRfkE83Za015FN0
cMf6nJ7n9kk55KRrLsNXDbFNOxJKdRRCAK8jH+xiKQJ+QLUqUUu/qs3OtvG01JPO
bs9jew7H1mGCj1zmTClLHwg3E8Lbfw==
=UeUq
-----END PGP SIGNATURE-----

--Y1L3PTX8QE8cb2T+--