Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9633263imu; Wed, 5 Dec 2018 07:56:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/UHbYcUEzfZ2cZFMmrbP+FfZb9NmxPP3/06D1uTyxgEckWqKeXDs+L+rYzJjk2NIm83/D1x X-Received: by 2002:a63:e5c:: with SMTP id 28mr8278025pgo.369.1544025368340; Wed, 05 Dec 2018 07:56:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544025368; cv=none; d=google.com; s=arc-20160816; b=WConDLx7Q3o5CQPP81+S9U+O83FM098gh99eBPpmMgSd6/vs1D3cutO8C5uMrW3a1A PinXDGsp2F3BvqasPgXSfGpy1ng6Tr9ihHESBut+K9JpkMj1yfeXt/6HBSAXcrs8tkWP tEfCYKkN5Avt823BhJH8jEqqvUQUoeXNjPhFCRwS0Tqbb4UpOeIeQo3XmQELbyXXQNtf CLOGQQSFZylaOCXSME/PUrhwbIDBZDDKyajGgsa4yl8q4tzoUBfUkoni1MU6HenKEbEc k+pKoVag1QDca19InksseyQdXVBQxfx1X54Sr+aWoHgIZxSk3DZbPOXkfKM8VGCB2/x6 yHUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=392UV8beoUasC1QsWmvdHjNMQmpl1CoCyfHmO/0uTmo=; b=QxL8S3aKbtyd91fIMJwM1PWadb66cfL7/CuEhYDSJOzUViVShQZ5s4rXzxzFGGzWMT XoLdC7SNZ+Am6mj3fy7m22MLXniO5+8nBOQtPIW67nkf/2L5R/J2Wcj9qgYcAee6jJ84 PxxS05dKREUAO6dkceYrShlprAnE1aMOiSEfwgUgYGdJ0lL6/iaWnV2RCSlMJ4jjDk3Z nHUrzSADOeDXndxYQHM66RoznwtPuXUPu7SzetcRihQ5BzWCZ2X/nWHCQXLYiVUe9M4d o0ZPvhbs4BVW58jL65JOgmgECVvEdVt+r/a2cv/l9nbE1X0LbsTqZHJLAjPmWEXQUO4P XEbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amacapital-net.20150623.gappssmtp.com header.s=20150623 header.b=ylyQcqMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 44si20662225plb.57.2018.12.05.07.55.53; Wed, 05 Dec 2018 07:56:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amacapital-net.20150623.gappssmtp.com header.s=20150623 header.b=ylyQcqMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728158AbeLEPyR (ORCPT + 99 others); Wed, 5 Dec 2018 10:54:17 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38070 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728115AbeLEPyP (ORCPT ); Wed, 5 Dec 2018 10:54:15 -0500 Received: by mail-pl1-f194.google.com with SMTP id e5so10259973plb.5 for ; Wed, 05 Dec 2018 07:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=392UV8beoUasC1QsWmvdHjNMQmpl1CoCyfHmO/0uTmo=; b=ylyQcqMw9j+b4BL38Wg1nZB76lTbCWoe3t6/bCr363B6z5lcq/DVpqFpzyrArmY4QY Lqe8Hn4o8ENQOrPLyxh+w9/BtbmhzMtwjsVm91TcnPnKxc4GRN00FCeLiBvNbIMNVA8H KbxhlTvNUpshXXYdVjZZPzuiF4ldoSZ7lQfp8PN3lASdtNDob+HGUELCZGSdueNxHywV a95U9p50JQgWrJ/OShmk2+tKvuFl31AGk4ysROQ926UA4NxdnmH2P3mCNv1/7VaBW2FH wvLGiMF5xVMwwN0o6G7Pg8TWaCiGC744rseRJuq91WCyddNRfqNFatNvktWoS+FoTcU9 EKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=392UV8beoUasC1QsWmvdHjNMQmpl1CoCyfHmO/0uTmo=; b=JDgX6Tg7rtEnVPiu7UBt+Dpa835LzlyQXG3VAsGxcaHWB1z0hZvQqjvmkv8tYdDHDH /1MCVoGBnA5x49VtOm1sKR9cRHzdD5ceG87+Md+PMx+GRyXwLwRgqN09hxXm09H2U5Bu bDygS70WodNKYtyj10Hkn3G4Dopha8HFkTe7AA4MePJIiWRz9g1BAl6y5WfzDBG9jqHy I6aAJ81p+MeegERPUE1OM7rfdMd72ei0LoBnIWwYLgn3rfJd/f6smRMNQRaLUCXfxDGN sHtyJzvTv/CAjFiYXrjj8th4+Jvvbk02Z7azGKhXFb8mHrpQRDC2t5zmKmycyXjg7k1l /02w== X-Gm-Message-State: AA+aEWbH8XPh6aE9Cy1KU/42DDoaqJ+22+wAk5Tq5XyM+QGSbLCLWnkX QD+3oRxpw4DvxGwgIxobLLDHPQ== X-Received: by 2002:a17:902:820d:: with SMTP id x13mr25460830pln.229.1544025254174; Wed, 05 Dec 2018 07:54:14 -0800 (PST) Received: from ?IPv6:2601:646:c200:7429:683f:7a90:8a4d:4c99? ([2601:646:c200:7429:683f:7a90:8a4d:4c99]) by smtp.gmail.com with ESMTPSA id w184sm22949391pgd.34.2018.12.05.07.54.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 07:54:13 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit From: Andy Lutomirski X-Mailer: iPhone Mail (16B92) In-Reply-To: <20181205152336.GA31197@linux.intel.com> Date: Wed, 5 Dec 2018 07:54:11 -0800 Cc: Andy Lutomirski , Ingo Molnar , X86 ML , LKML , Yu-cheng Yu , Dave Hansen , Peter Zijlstra , Borislav Petkov Content-Transfer-Encoding: quoted-printable Message-Id: References: <11212acb25980cd1b3030875cd9502414fbb214d.1542841400.git.luto@kernel.org> <20181122084119.GA44720@gmail.com> <20181127153202.GA27075@linux.intel.com> <20181205152336.GA31197@linux.intel.com> To: Sean Christopherson Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + err_str_append(error_code, err_txt, X86_PF_INSTR, "[INSTR]", NULL)= ; > + err_str_append(error_code, err_txt, X86_PF_PK, "[PK]" , NULL)= ; > + err_str_append(error_code, err_txt, X86_PF_WRITE | X86_PF_INSTR, N= ULL, > + "[READ]"); Ah, I see the issue. OTOH, printing [READ] [INSTR] wouldn=E2=80=99t be so b= ad, either.