Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9676522imu; Wed, 5 Dec 2018 08:31:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/XvtWbHJrYni+9JPuX4NK3YV1+bqZeTR7/QeDGkDwqz9A6L0uen7V+ORiqSMDRBjzOnuf6b X-Received: by 2002:a17:902:45:: with SMTP id 63mr23825450pla.272.1544027517589; Wed, 05 Dec 2018 08:31:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544027517; cv=none; d=google.com; s=arc-20160816; b=FxhGoB4SE2P+D99Dzu9dsEAJcyb/EXKV5wp9qt00PRrlDIyPPzc3FoEVNLuZl+WXJh MYUux4/wBqS33iWapqdHcyZ6j/2kX7p5Pwyz5HMemGrivh+cdiLQYTK4qLwdes4cjJ3z 8Kj/H4Pn8xa1n1DrmQ7WTpGrXNR7Nj/Sb0OknsRLLtedlmKr0xtQVBgopUnK89blEi5J Fu/l2w5mAOSsw7XdXqeJQSBVCCEX5Rpy02ON9FwodI2pp/DAD9Fm6kSDz2ukXk1wRYjS IYX5ruf2VgK6gY7TIS9AK1IA8XasZ5v9ueltjbkYlcmY8wKo9VnbGQ2tjxZ3GMThTX0g KOGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2VncPMatIYdVunX35wqsj2eqkHPjPyrgw31yAL/VEvA=; b=anZroISV0e2YrGYptjhjZI5mSo+qp/n5F5tLNFQrZrDaFguXWWH+jUz8ip2uRMRb1W eRmUKyOOAtnBOo+Q7QyEL1etVZZXV/tY7fSzLNJ1aLr3rVE4QHA+5Gzvd5BQNTd3WyBG uB8G/nDVfdpgXCxpwCPR+oM7cenRVwUt1ePi2Q5b9B+MIww6wgO7YPhGEhQ/rcY3jaWy vaV61lIcSu42Rm9wTBAvIpTTOtvv+RnktoWX/Qx8e5FjfrLQuF5UryZvbjTInlx2aLW0 vcKPTFyXFJFBbKrYNszqXWCPGbaEgc3iza0exzZS2HUn/JG/q7YYfbo28bnNIvFgJR5q 3LXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d8wBItGF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si18064536pgi.260.2018.12.05.08.31.42; Wed, 05 Dec 2018 08:31:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d8wBItGF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728147AbeLEQ3a (ORCPT + 99 others); Wed, 5 Dec 2018 11:29:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:42126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727195AbeLEQ33 (ORCPT ); Wed, 5 Dec 2018 11:29:29 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B53AE2064D; Wed, 5 Dec 2018 16:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544027369; bh=ORsivgG4NppBhrv/ogSzDyTdA+RRYLk22016rnWWrMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d8wBItGFIdwaFl5BVgUHWxovtNZH2EH9jSiGOzHukqwhkONKzYWgIk3fFAHLIfJWx Ruq4zmVyeOj8E/TOZCyqI1Zo+CLceiKYOLPTUINSudb5z7b/asT+kvCVBR/gkVr2Sd 5UnxUHZo3ZASWUXm1It4xTuYWhhP3R+/NT4TuF3Q= Date: Wed, 5 Dec 2018 17:29:26 +0100 From: Greg Kroah-Hartman To: Todd Kjos Cc: Todd Kjos , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , "open list:ANDROID DRIVERS" , LKML , Martijn Coenen , joel@joelfernandes.org, Android Kernel Team Subject: Re: [PATCH] binder: fix sparse warnings on locking context Message-ID: <20181205162926.GA7185@kroah.com> References: <20181203202457.228972-1-tkjos@google.com> <20181205105746.GA16376@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.0 (2018-11-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 05, 2018 at 06:02:22AM -0800, Todd Kjos wrote: > On Wed, Dec 5, 2018 at 2:57 AM Greg KH wrote: > > > On Mon, Dec 03, 2018 at 12:24:54PM -0800, Todd Kjos wrote: > > > Add __acquire()/__release() annnotations to fix warnings > > > in sparse context checking > > > > > > There is one case where the warning was due to a lack of > > > a "default:" case in a switch statement where a lock was > > > being released in each of the cases, so the default > > > case was added. > > > > > > Signed-off-by: Todd Kjos > > > > You sent out 4 patches here, as a series, but with no numbering so I > > don't know what order to put them in :( > > > > Can you resend them properly numbered so I have a chance to get it > > right? > > > > I didn't number them because they are independent and can go in any order. Ah, that wasn't obvious :) > They are not really a series. I can resend with numbers though if you want > to reflect the order I sent them in. Ok, no need for numbering them, but they do need to be resent based on the feedback I gave. I've dropped them all from my queue because of that. thanks, greg k-h