Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9757908imu; Wed, 5 Dec 2018 09:44:42 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uta7HmhdZTRlPNNI0hE6IHHlyiQj3x8WsWXRiYV8UF7UhQQqZYe1hvAiTapczT3EcP2Y4c X-Received: by 2002:a63:94:: with SMTP id 142mr20909031pga.74.1544031882203; Wed, 05 Dec 2018 09:44:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544031882; cv=none; d=google.com; s=arc-20160816; b=rT25bTVCCztZoq+nxs+h7nOEu49i8KCkG6VKj3fNQE/KNp5wwtlDlodt5psswWf/yz C3ztt+mMbaiecD3COiI9e83q+usR6QmjFEokkQZhj/TZpatol01yivgaViq2uB4M2S8b ZUuAD4jj9BHuUjaC3STacyixcXkJx1iIkkrs9nreh+OEFz9O7BGw/Aw/vTlZdW54u/aV vmqrAcTbI8Rp+0hT4hVdd9WqxKrFVrOPO1tUina7y+0O9TU6/RnPHsyLdkoAFQaapBxu SAs4r0c3w8cqVo9RFE4cuTF6QHbEeIkEhnoiJQh7TWQif2kE3yWsq4es8C7wT9FT5Qb5 aW3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=AGh1BzcmtSDuqtE3ubwanNok0UEm/hNsSUho9oGgVpc=; b=ejzsNHoD2xMcdJj1mlV3kK2gO87jAPJ0m9BCJ9LtAhcgZdmfV3h28Or3/utrPSO19F Vg1VUSh8DV+ebD75PkjM4tXotqu+fcaerofThEfrknRT2sPA1FMa8NzJEq+jVoj89wKs rtzLZ2OWzOHKGQ2L2tBL8HHiiOhX/djXPNmJFM9Y89FinZP8Vse3e4Z77FET0vPtX7Hg iYxxrdpIXDWOE5qDgMFHqJ5CuqbLNzeyxjy3/6SsAj78ISfbv0Y9IgMRFPCJd43vSfKy yAe3UTRqNU01DxIeyfAKGmD56UJbf0XCBRfbHU2QaKacHLkCZ3AqKsDddYly8Ipu60/A h7kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b24si18996364pgi.308.2018.12.05.09.44.26; Wed, 05 Dec 2018 09:44:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727924AbeLERno (ORCPT + 99 others); Wed, 5 Dec 2018 12:43:44 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:50500 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727402AbeLERno (ORCPT ); Wed, 5 Dec 2018 12:43:44 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id ADBB927ED19 Received: by earth.universe (Postfix, from userid 1000) id 8C41B3C08D6; Wed, 5 Dec 2018 18:43:39 +0100 (CET) Date: Wed, 5 Dec 2018 18:43:39 +0100 From: Sebastian Reichel To: Priit Laes Cc: Lee Jones , Rob Herring , Mark Rutland , Chen-Yu Tsai , Maxime Ripard , Hans de Goede , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Olliver Schinagl Subject: Re: [PATCH 14/14] power: supply: axp288: use the BIT() macro Message-ID: <20181205174339.veqr63rdzdm6afjt@earth.universe> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fnxsdv5gg3qmvdqi" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fnxsdv5gg3qmvdqi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Nov 26, 2018 at 05:27:55PM +0200, Priit Laes wrote: > From: Olliver Schinagl >=20 > Make use of the recommended BIT() macro for bit defines. >=20 > Signed-off-by: Olliver Schinagl > Signed-off-by: Priit Laes > --- Thanks, queued to power-supply-next. -- Sebastian > drivers/power/supply/axp288_charger.c | 35 ++++++++++++++-------------- > 1 file changed, 18 insertions(+), 17 deletions(-) >=20 > diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply= /axp288_charger.c > index 735658e..f8c6da9 100644 > --- a/drivers/power/supply/axp288_charger.c > +++ b/drivers/power/supply/axp288_charger.c > @@ -16,6 +16,7 @@ > */ > =20 > #include > +#include > #include > #include > #include > @@ -29,17 +30,17 @@ > #include > #include > =20 > -#define PS_STAT_VBUS_TRIGGER (1 << 0) > -#define PS_STAT_BAT_CHRG_DIR (1 << 2) > -#define PS_STAT_VBAT_ABOVE_VHOLD (1 << 3) > -#define PS_STAT_VBUS_VALID (1 << 4) > -#define PS_STAT_VBUS_PRESENT (1 << 5) > +#define PS_STAT_VBUS_TRIGGER BIT(0) > +#define PS_STAT_BAT_CHRG_DIR BIT(2) > +#define PS_STAT_VBAT_ABOVE_VHOLD BIT(3) > +#define PS_STAT_VBUS_VALID BIT(4) > +#define PS_STAT_VBUS_PRESENT BIT(5) > =20 > -#define CHRG_STAT_BAT_SAFE_MODE (1 << 3) > -#define CHRG_STAT_BAT_VALID (1 << 4) > -#define CHRG_STAT_BAT_PRESENT (1 << 5) > -#define CHRG_STAT_CHARGING (1 << 6) > -#define CHRG_STAT_PMIC_OTP (1 << 7) > +#define CHRG_STAT_BAT_SAFE_MODE BIT(3) > +#define CHRG_STAT_BAT_VALID BIT(4) > +#define CHRG_STAT_BAT_PRESENT BIT(5) > +#define CHRG_STAT_CHARGING BIT(6) > +#define CHRG_STAT_PMIC_OTP BIT(7) > =20 > #define VBUS_ISPOUT_CUR_LIM_MASK 0x03 > #define VBUS_ISPOUT_CUR_LIM_BIT_POS 0 > @@ -52,33 +53,33 @@ > #define VBUS_ISPOUT_VHOLD_SET_OFFSET 4000 /* 4000mV */ > #define VBUS_ISPOUT_VHOLD_SET_LSB_RES 100 /* 100mV */ > #define VBUS_ISPOUT_VHOLD_SET_4300MV 0x3 /* 4300mV */ > -#define VBUS_ISPOUT_VBUS_PATH_DIS (1 << 7) > +#define VBUS_ISPOUT_VBUS_PATH_DIS BIT(7) > =20 > #define CHRG_CCCV_CC_MASK 0xf /* 4 bits */ > #define CHRG_CCCV_CC_BIT_POS 0 > #define CHRG_CCCV_CC_OFFSET 200 /* 200mA */ > #define CHRG_CCCV_CC_LSB_RES 200 /* 200mA */ > -#define CHRG_CCCV_ITERM_20P (1 << 4) /* 20% of CC */ > +#define CHRG_CCCV_ITERM_20P BIT(4) /* 20% of CC */ > #define CHRG_CCCV_CV_MASK 0x60 /* 2 bits */ > #define CHRG_CCCV_CV_BIT_POS 5 > #define CHRG_CCCV_CV_4100MV 0x0 /* 4.10V */ > #define CHRG_CCCV_CV_4150MV 0x1 /* 4.15V */ > #define CHRG_CCCV_CV_4200MV 0x2 /* 4.20V */ > #define CHRG_CCCV_CV_4350MV 0x3 /* 4.35V */ > -#define CHRG_CCCV_CHG_EN (1 << 7) > +#define CHRG_CCCV_CHG_EN BIT(7) > =20 > #define CNTL2_CC_TIMEOUT_MASK 0x3 /* 2 bits */ > #define CNTL2_CC_TIMEOUT_OFFSET 6 /* 6 Hrs */ > #define CNTL2_CC_TIMEOUT_LSB_RES 2 /* 2 Hrs */ > #define CNTL2_CC_TIMEOUT_12HRS 0x3 /* 12 Hrs */ > -#define CNTL2_CHGLED_TYPEB (1 << 4) > -#define CNTL2_CHG_OUT_TURNON (1 << 5) > +#define CNTL2_CHGLED_TYPEB BIT(4) > +#define CNTL2_CHG_OUT_TURNON BIT(5) > #define CNTL2_PC_TIMEOUT_MASK 0xC0 > #define CNTL2_PC_TIMEOUT_OFFSET 40 /* 40 mins */ > #define CNTL2_PC_TIMEOUT_LSB_RES 10 /* 10 mins */ > #define CNTL2_PC_TIMEOUT_70MINS 0x3 > =20 > -#define CHRG_ILIM_TEMP_LOOP_EN (1 << 3) > +#define CHRG_ILIM_TEMP_LOOP_EN BIT(3) > #define CHRG_VBUS_ILIM_MASK 0xf0 > #define CHRG_VBUS_ILIM_BIT_POS 4 > #define CHRG_VBUS_ILIM_100MA 0x0 /* 100mA */ > @@ -94,7 +95,7 @@ > #define CHRG_VLTFC_0C 0xA5 /* 0 DegC */ > #define CHRG_VHTFC_45C 0x1F /* 45 DegC */ > =20 > -#define FG_CNTL_OCV_ADJ_EN (1 << 3) > +#define FG_CNTL_OCV_ADJ_EN BIT(3) > =20 > #define CV_4100MV 4100 /* 4100mV */ > #define CV_4150MV 4150 /* 4150mV */ > --=20 > git-series 0.9.1 --fnxsdv5gg3qmvdqi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlwIDksACgkQ2O7X88g7 +ppOgw/8CPrpspeCER5Q+WfWnTQG6yDH1TqgkbMFikTYq1dBjw/pfjL5Jm0gqcF3 Ud05K4OOtpNwh/+FMRdeX5dbMRWHyUGycB/+99KoN1Wvf75KZoMCEf+U7vePHCNT 6wVlS1OiZ2A0Qz9AbnMSRUIA1cB4snil046epU78Tk5X+aG6KPMdBf3UhwViBhVG y8bHopdrdmjUzXypBidcEkV8YZE+ABCkVjex3+BaanVXTpB7b5cYUXqxIEGoyImL sjKB0OfeFRygr3YDMmfFGlRx06fccBkc/Mvq1AK5j3o2O9pFPiWVXLFfbjWwXxG4 MEQOSBP+FOnnIzlFQTpnXpArxtn1xVM91U+tCeTDAo1QpUKLYwxdehKJM6gwrhha L4yylZbYpjCeOhs8bYYcbuGd6MRw3W1Jjk8r+9hKmQKkyjz+K47l7VK6bvFmLAw5 NsyhQ3EXiH7bHEgyxDYCNy7sJgIszzREBb/y9/aeTVidTiahr0Hcb3aGD26LRJ1V bYJEgsfyfmmIeXq4hl6yuwspZQi+r79rv+lzLCPWYt8Dh64Yb62qq7FWwk9paF/G EJaLaDHNIcq4zHtQBO5Z4+aieU4rIgGSPw+sorTQtWWTgcTjiUsPDueZWpRqZvO7 Qt1H7hUj1DHls7ReN2uYd8XphVfmYoQI+47NrMCIf7QWpxrpZew= =cKtS -----END PGP SIGNATURE----- --fnxsdv5gg3qmvdqi--