Date: Sat, 17 Jan 2004 22:41:39 -0800
From: Andrew Morton <akpm@osdl.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: viro@parcelfarce.linux.theplanet.co.uk, manfred@colorfullife.com,
       linux-kernel@vger.kernel.org
Subject: Re: [RFC] kill sleep_on
Message-Id: <20040117224139.5585fb9c.akpm@osdl.org>
In-Reply-To: <1074383111.9965.4.camel@imladris.demon.co.uk>
References: <40098251.2040009@colorfullife.com>
	<1074367701.9965.2.camel@imladris.demon.co.uk>
	<20040117201000.GL21151@parcelfarce.linux.theplanet.co.uk>
	<1074383111.9965.4.camel@imladris.demon.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 835
Lines: 21

David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Sat, 2004-01-17 at 20:10 +0000,
> viro@parcelfarce.linux.theplanet.co.uk wrote:
> > AFAICS, _all_ uses of sleep_on() in drivers are broken in one way or another
> > and BKL won't help them.
> 
> I think ext3 and nfs get away with it at the moment by using the BKL. It
> does want fixing though.

ext3 had all its sleep_on()s and lock_kernel()s eradicated ages ago.  In
2.4 it uses sleep_on()s and lock_kernel() makes that safe.

It would be nice to fix up the lock_kernel()s in the NFS client: SMP lock
contention is quite high in there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/