Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9833309imu; Wed, 5 Dec 2018 11:02:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uufqq4kWvA9OgcIni1NSpeYHLozKKzQei6TJnPbASy0tDKXUEktCIYoZhWoM+e5f+1yAXm X-Received: by 2002:a63:e545:: with SMTP id z5mr21472390pgj.195.1544036557741; Wed, 05 Dec 2018 11:02:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544036557; cv=none; d=google.com; s=arc-20160816; b=WTEkbGEQerfS2ySVnAEnildRcSKELZfaRHER4eKT4mj9NqLBBiOT7gYav5eG9JEKtU 6ZHBd44s5pVugwvsqW/1t5BP1Qqc/rRsbs7nKwXSHN+yL2tl0/LOGHoIrqD478/rSld1 +sRc7MgkEnfL1jn5A5igKO7d+ngj3YXTA0j0Go9QMZrGoZ3qBkGqNMxkBDOSJyuWcrjI 2ykMBMetdCVHMUqzhUmsLzzGnRgA2i+aP0IP4Hctp1C4kzOvJmE3lHwMqeLtDeIdWzXb 0nd/RTHzmGXTLxeYRQf0Qdcodsbz660nk1RAT7yjZQAwBQ0G4vvyIIAsUhqA/zbpSK+f ripA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=3t/93saH7cFdXWSMTIAz5V0rKKd/CEFRQG0Vb9mVVm8=; b=eMqSrglV5tksTBscL2vIQTV6G4i6DsG/EislGEa3u4dJBWr84/odIryNFf3951zcnb OEuH4jsr47v9MzJ72xA6R2BU/ej/105cwFMeEo4mdd6Ce2PYtEZqXB8jsQ7mUf7tZKGz rbYrJftpaDId3EsJWT8c7pl6v44lJD3av8/kZ/DCoZ8B0gpDSnH8JHq+YsCQzRSJ/Me+ P8h44FxCD1gzY+Lo6bVcOZIDDFPIHmfR4fM11xzXZvZ+T6saaBAggtHL8KKFC9+vbazq KK97OWPSMcL3C0T8FYt7V9/kEy1P6i7vmX9m/YkIE1bEzp2AtvjGQsrbH0M0GSNF+wqk 7PMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector1-xilinx-com header.b=qJyC1z8Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3si20091446pfh.58.2018.12.05.11.02.21; Wed, 05 Dec 2018 11:02:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector1-xilinx-com header.b=qJyC1z8Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728269AbeLETB1 (ORCPT + 99 others); Wed, 5 Dec 2018 14:01:27 -0500 Received: from mail-eopbgr780082.outbound.protection.outlook.com ([40.107.78.82]:9324 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727257AbeLETB1 (ORCPT ); Wed, 5 Dec 2018 14:01:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3t/93saH7cFdXWSMTIAz5V0rKKd/CEFRQG0Vb9mVVm8=; b=qJyC1z8YMO6X5KRh0hrjY6zQ/vaY0W0prZ+gJUKNVBpXk4aLvALgTXq7DhFHSQ1otLnSFTOXhA5qXMWsOcFAZ0CzazzvDxZNmq0BMIoY/aqDQ8d2E9QR7KuozcyNGovkbGaHvKrKPpC9MVDEtPHFUtUrAHw3tSvgTObqt98Ntzk= Received: from BL0PR02MB5633.namprd02.prod.outlook.com (20.177.241.80) by BL0PR02MB4964.namprd02.prod.outlook.com (52.132.14.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.22; Wed, 5 Dec 2018 19:01:13 +0000 Received: from BL0PR02MB5633.namprd02.prod.outlook.com ([fe80::68ed:9ca9:c7da:d76d]) by BL0PR02MB5633.namprd02.prod.outlook.com ([fe80::68ed:9ca9:c7da:d76d%2]) with mapi id 15.20.1404.019; Wed, 5 Dec 2018 19:01:12 +0000 From: Anurag Kumar Vulisha To: Felipe Balbi , Greg Kroah-Hartman , Shuah Khan , Alan Stern , Johan Hovold , Jaejoong Kim , Benjamin Herrenschmidt , Roger Quadros , Manu Gautam , "martin.petersen@oracle.com" , Bart Van Assche , Mike Christie , Matthew Wilcox , Colin Ian King CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "v.anuragkumar@gmail.com" , Thinh Nguyen , Tejas Joglekar , Ajay Yugalkishore Pandey Subject: RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields Thread-Topic: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields Thread-Index: AQHUiWbqDI9WfI74TEmPyd+V2NlqDqVv4SkAgACgrWA= Date: Wed, 5 Dec 2018 19:01:12 +0000 Message-ID: References: <1543662811-5194-1-git-send-email-anurag.kumar.vulisha@xilinx.com> <1543662811-5194-10-git-send-email-anurag.kumar.vulisha@xilinx.com> <875zw82vfj.fsf@linux.intel.com> In-Reply-To: <875zw82vfj.fsf@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anuragku@xilinx.com; x-originating-ip: [182.18.177.170] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BL0PR02MB4964;6:wWpvqMkuUxkJjxw70njNAYKfGODYs31zAgAy+H1/XORnfKvS3Mu/hC9/mSoVwq7QFMZoe/axyKUzx95zUetKtNSyFUTJNSyt7gdWSkkGDOSdFU4Y+NJ57VpHUEACDvgm0BV0FAKwe8nhfbNHnapZvbZXZeGGtfgxdim3b2X7c3nhYvtwQDqFwykSn44UVzcMSSg56FdPO0xhwmBuv+UgG7MM42GukYz2yin1zswSEfGKx54ujg+5FFwIR+UidyVphOd1IzcWiL5NyxLHdv0Km+haeOcMi3IhCANw3Xntzs0137GtvLr+E8wZxKPiW16dI99c8pM5rCUZW1ww0Rue2TilockD07U4cSafInnu71HD4ezSf4Ni4i4xJ5EymiLv6sbmVwqCWNz8wj/uRZHIu1ynAjZd88wJu2ytbiNUQP8PG8ay8tAJWKzMpPmp/y2rFkRD+aoBdRfMgnOLFAuWPQ==;5:0uJk40TtgI+4RylwOgbxKyrPjkTEpJ03yvSHAnuGiBqbf7DxUy8QlBa1B7eFKrKYQs6gv0I754oMMEN9swmXYw8uGTzTK6sAqqUNWuo3nT86KubGbUiv7+05ijh28ypYZCXD1MOjb0Yt059ziGbnpIQLrfUo5p7XRLnSoB3Onhg=;7:BMYhOG/LC9/IJ+SX64o4Y0FZUuW9NU6Os1X2DMOM9EAyw9aapDH+ecFzDUcxI17VDmBpaBcI5tXLCXLeHLdGtqh2Pytm8s8n7iXoWGbP0dAux+B82pGi6dJvwkNZ2HoeA0bnQxb1ejWIZWVguB1TKg== x-ms-office365-filtering-correlation-id: 1b58e590-74db-4711-816a-08d65ae4069f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:BL0PR02MB4964; x-ms-traffictypediagnostic: BL0PR02MB4964: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231455)(999002)(944501520)(52105112)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095);SRVR:BL0PR02MB4964;BCL:0;PCL:0;RULEID:;SRVR:BL0PR02MB4964; x-forefront-prvs: 08770259B4 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(136003)(366004)(376002)(346002)(39860400002)(13464003)(52084003)(199004)(189003)(6246003)(39060400002)(229853002)(5660300001)(81156014)(7696005)(53936002)(2171002)(99286004)(33656002)(4326008)(7416002)(54906003)(9686003)(25786009)(2906002)(102836004)(81166006)(105586002)(106356001)(6506007)(26005)(186003)(8676002)(8936002)(71200400001)(71190400001)(107886003)(76176011)(68736007)(305945005)(256004)(486006)(11346002)(74316002)(55016002)(86362001)(446003)(476003)(66066001)(110136005)(2501003)(7736002)(14444005)(478600001)(316002)(3846002)(97736004)(14454004)(6116002)(6436002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR02MB4964;H:BL0PR02MB5633.namprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: xilinx.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: X5oSukz1tEeZQLr8aqEdSjOQqi0j3A4vBaASCoTR0PxWMwLFcuva9Ze7sdMqpU7tOsbiXWeYQ/zirbpy4E9g2DGCQ8hT2pY73mz6IDIWEKqSiOVcAK5p/5CyQY30zFM8BlELQ90SsMTM2aKJXLyQxZZtRdlGBUa32TBRmvjlOqujtYrbtrtQ9Xfn68x6huJzEgvKDayOReoZEamCWCHzpihWBh5jBj5rOUKWcT5h+GCAS6NZN1oaCfDfZtBuCuVqwnnAscM4KPbAbZ5UZF2l8DN5E8Bq3P/4R+98c185ZqNjqueQ5Hr4//yTfj7PzSI1Z9Pc00SFxQGcgzYUcuRkdtXiQXURVkuBvsTSyFzbAo0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b58e590-74db-4711-816a-08d65ae4069f X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2018 19:01:12.7682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4964 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, >-----Original Message----- >From: Felipe Balbi [mailto:balbi@kernel.org] >Sent: Wednesday, December 05, 2018 2:38 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman >; Shuah Khan ; Alan Stern >; Johan Hovold ; Jaejoong Kim >; Benjamin Herrenschmidt = ; >Roger Quadros ; Manu Gautam ; >martin.petersen@oracle.com; Bart Van Assche ; Mike >Christie ; Matthew Wilcox ; Coli= n Ian >King >Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; >v.anuragkumar@gmail.com; Thinh Nguyen ; Tejas Jogleka= r >; Ajay Yugalkishore Pandey ; >Anurag Kumar Vulisha >Subject: Re: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both eve= nt->status >and TRB->ctrl fields > > >Hi, > >Anurag Kumar Vulisha writes: >> The present code in dwc3_gadget_ep_reclaim_completed_trb() will check >> for IOC/LST bit in the event->status and returns if IOC/LST bit is >> set. This logic doesn't work if multiple TRBs are queued per >> request and the IOC/LST bit is set on the last TRB of that request. >> Consider an example where a queued request has multiple queued TRBs >> and IOC/LST bit is set only for the last TRB. In this case, the Core >> generates XferComplete/XferInProgress events only for the last TRB >> (since IOC/LST are set only for the last TRB). As per the logic in >> dwc3_gadget_ep_reclaim_completed_trb() event->status is checked for >> IOC/LST bit and returns on the first TRB. This makes the remaining >> TRBs left unhandled. >> To aviod this, changed the code to check for IOC/LST bits in both >> event->status & TRB->ctrl. This patch does the same. >> >> Signed-off-by: Anurag Kumar Vulisha >> Reviewed-by: Thinh Nguyen >> Tested-by: Tejas Joglekar >> --- >> Changes in v7: >> 1. None >> >> Changes in v6: >> 1. None >> >> Changes in v5: >> 1. None >> >> Changes in v4: >> 1. None >> >> Changes in v3: >> 1. None >> >> Changes in v2: >> 1. None >> --- >> drivers/usb/dwc3/gadget.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 9ddc9fd..216179e 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -2286,7 +2286,12 @@ static int >dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep, >> if (event->status & DEPEVT_STATUS_SHORT && !chain) >> return 1; >> >> - if (event->status & (DEPEVT_STATUS_IOC | DEPEVT_STATUS_LST)) >> + if ((event->status & DEPEVT_STATUS_IOC) && >> + (trb->ctrl & DWC3_TRB_CTRL_IOC)) >> + return 1; > >this shouldn't be necessary. According to databook, event->status >contains the bits from the completed TRB. Which means that >event->status & IOC will always be equal to trb->ctrl & IOC. > Thanks for reviewing this patch. Lets consider an example where a request has num_sgs > 0 and each sg is mapped to a TRB and the last TRB has the IOC bit set. Once the controller is done with the transfer, it generates=20 XferInProgress for the last TRB (since IOC bit is set). As a part of trb re= claim process dwc3_gadget_ep_reclaim_trb_sg() calls dwc3_gadget_ep_reclaim_completed_trb() for req->num_sgs times. Since the event already has the IOC bit set, the loop is exited from the loop at = the very first TRB and the remaining TRBs (mapped to the sglist) are left unhan= dled. To avoid this we modified the code to exit only if both TRB & event has the= IOC bit set. =20 >Can you further describe the situation here? Perhaps share tracepoints >exposing the problem? Sure, will capture the traces and reply back Thanks, Anurag Kumar Vulisha