Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9925537imu; Wed, 5 Dec 2018 12:44:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/VbAH1kGW1JzDgVZ6H+YV7EoXb9Xrd6CQqJVkW3q38Pv5KSEHB+ItVly0UuEf4MKiRmBxE+ X-Received: by 2002:a17:902:66e6:: with SMTP id e93mr25105279plk.92.1544042640967; Wed, 05 Dec 2018 12:44:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544042640; cv=none; d=google.com; s=arc-20160816; b=ssZKQyUS1r+OstnnlsNW7mONp9RahfJCHq2ePOq+82pTyw8U0yupUA/uKZKezEQapF N82QexfwVSAcGsdlG3MLwGheEVGuTxobb1LCjWiTljhgwL7qWvKE4ivSTcRDgBuLKYgz 7elQJuK6jer8aeP9cYv6gRoTn6nxYcTU0shPIZusNdXqUWqbEfczSiQcEoPXuHxlF41Y gOW90Bj+Sqy4JBjDfjkNrhgKlJX3HozXzLkBu50MzJ0e1Ly14/WwcFbi27f+Hp9cGInt 4GxT3/1a3SSGebVrtrquzH0W1FKz6L5jlutrdsTLUpNwfMo0fka0VBCpXA4Hv4GMPngm N6jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=S94F7oTW79NEXFVi0G+XjW7HN7D2P8gNBHZP4W31C+Q=; b=QLDd9W6615wnCv5V+7AZrgJY8O9a5O6eyf4XNVakGmBzoR+v27thAOAlaNn9YNkI15 EMMyTsqBs4aiRTKXXf16FUjlQI5yPqXXm84/89Lj4txdnpXlxraHm+pICnNmifv2kIa7 j1X6dLqEiV2Jtmnm0mczAGtW0sJhARWIehhhU8xybQTb/KQ6n1i4tc+cJk/Tam9wU1Q1 IuI8S1LBi5A66mLWobs73rZXOjEqekfBm0ahzSSsHmnq+cD1YvHsANd03G9BOf5DHDeB lE4jUr0z1YBO9f5ikt7JLb/cmG1i8Jk+seUDL0U3wgUdLsx1Vld0XLbmhINT0kbe4zj4 jK9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1si18597036pgy.174.2018.12.05.12.43.45; Wed, 05 Dec 2018 12:44:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728521AbeLEUmh (ORCPT + 99 others); Wed, 5 Dec 2018 15:42:37 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:51082 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727592AbeLEUmg (ORCPT ); Wed, 5 Dec 2018 15:42:36 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id B3618263BF7 Received: by earth.universe (Postfix, from userid 1000) id E3B313C08D6; Wed, 5 Dec 2018 21:36:34 +0100 (CET) Date: Wed, 5 Dec 2018 21:36:34 +0100 From: Sebastian Reichel To: Baolin Wang Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, yuanjiang.yu@unisoc.com, broonie@kernel.org, linus.walleij@linaro.org Subject: Re: [PATCH 3/6] power: supply: charger-manager: Fix incorrect return value Message-ID: <20181205203634.f6u2yo7v3gonv2cm@earth.universe> References: <4ea9eaf85d780afb190cb45da2df8ff5fd86d449.1542362262.git.baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4k54tp3efjptzhvg" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4k54tp3efjptzhvg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Nov 16, 2018 at 07:01:10PM +0800, Baolin Wang wrote: > Fix incorrect return value. >=20 > Signed-off-by: Baolin Wang > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/suppl= y/charger-manager.c > index bd6c450..a52bc77 100644 > --- a/drivers/power/supply/charger-manager.c > +++ b/drivers/power/supply/charger-manager.c > @@ -1212,7 +1212,6 @@ static int charger_extcon_init(struct charger_manag= er *cm, > if (ret < 0) { > pr_info("Cannot register extcon_dev for %s(cable: %s)\n", > cable->extcon_name, cable->name); > - ret =3D -EINVAL; > } > =20 > return ret; > @@ -1633,7 +1632,7 @@ static int charger_manager_probe(struct platform_de= vice *pdev) > =20 > if (IS_ERR(desc)) { > dev_err(&pdev->dev, "No platform data (desc) found\n"); > - return -ENODEV; > + return PTR_ERR(desc); > } > =20 > cm =3D devm_kzalloc(&pdev->dev, sizeof(*cm), GFP_KERNEL); > --=20 > 1.7.9.5 >=20 --4k54tp3efjptzhvg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlwINtIACgkQ2O7X88g7 +prn7g//SmzLat8wABBr5Pe64cyPtuFqBq29DMkaowLjuLJSdjI29GGpA6OKn5AO sHT26tZA88SMB23WDwPVpubaMwrQdATNvNQtcS1zjdXdyk8F6RcUBJ0cCeP5IAXc QlX211xAKByDHie1tjHbJk73cn32WvhpwBMbV8EO2V3r0NaSBE327C/YmdksTVXt t1KmdHHJm9B2e8vYGGCblI0+saVPZxcXLbxsOh12Eo/puqnrrzpmxm2N0ThdcMuR 8aWZhA0kXgDmoiS3cYtMoUTDuBoO3BMY3fOmiJdawFQwNkF4OWiBrj+4XiCbzKRR 6Ej/bPXLOJsqkR/iySFdrsZC+7+jjByDVRhL0X/fpcNVW9LMI7slYcjd1FmN5B/2 Qm1AEloya8/aXvdqxd7C76zCmXTLcLWg2OQsvxyMNbrdqHm/YWtMRoRM2IVTyi0s 9wcLwCpjPYLrbAlRaT8UIq07u/dj83uTzI4YwXZ5ScjKddA0I1oTjk7sn38JrzGm Zc+YSU/VsytB2bOHALpcDwZ3n9sNfxzgW9xOq/eYFtBDjr7Cd8Yhn2U9YXAfY4Nw 6NyGgOKU/ZDs2iIpDktX4XwOet8Xc8rbLKKbI+zqzseJbLFodAYg5ixQOctk0z7u jKsJ7q1GuzVtOHB60hnVVfQdatUV0hSgR18+0psiQ2wXj/RJdzE= =3iHH -----END PGP SIGNATURE----- --4k54tp3efjptzhvg--