Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 5 Dec 2018 22:00:34 +0100
From:   Sicilia Cristian <sicilia.cristian@gmail.com>
To:     Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc:     Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: greybus: Added space between string
 concatenated
Message-ID: <20181205210034.GA24054@peano>
References: <cover.1543956271.git.sicilia.cristian@gmail.com>
 <5b215b50d4da9a7730450a83fb5e3a167b65e03a.1543956271.git.sicilia.cristian@gmail.com>
 <42632636-9b08-bd75-b789-88ef82f52c2c@nexus-software.ie>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW"
Content-Disposition: inline
In-Reply-To: <42632636-9b08-bd75-b789-88ef82f52c2c@nexus-software.ie>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--0F1p//8PRICkK4MW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 05, 2018 at 10:12:24AM +0000, Bryan O'Donoghue wrote:
> On 04/12/2018 20:58, Cristian Sicilia wrote:
> >Some concatenated strings are now spaced.
> >
> >Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
> >---
> >  drivers/staging/greybus/loopback.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybu=
s/loopback.c
> >index 1085e06..acfa392 100644
> >--- a/drivers/staging/greybus/loopback.c
> >+++ b/drivers/staging/greybus/loopback.c
> >@@ -141,7 +141,7 @@ static ssize_t name##_##field##_show(struct device *=
dev,	\
> >  	/* Report 0 for min and max if no transfer successed */		\
> >  	if (!gb->requests_completed)					\
> >  		return sprintf(buf, "0\n");				\
> >-	return sprintf(buf, "%"#type"\n", gb->name.field);	\
> >+	return sprintf(buf, "%" #type "\n", gb->name.field);		\
> >  }									\
> >  static DEVICE_ATTR_RO(name##_##field)
> >@@ -176,7 +176,7 @@ static ssize_t field##_show(struct device *dev,				\
> >  			    char *buf)					\
> >  {									\
> >  	struct gb_loopback *gb =3D dev_get_drvdata(dev);			\
> >-	return sprintf(buf, "%"#type"\n", gb->field);			\
> >+	return sprintf(buf, "%" #type "\n", gb->field);			\
> >  }									\
> >  static ssize_t field##_store(struct device *dev,			\
> >  			    struct device_attribute *attr,		\
> >@@ -212,7 +212,7 @@ static ssize_t field##_show(struct device *dev,				\
> >  			    char *buf)					\
> >  {									\
> >  	struct gb_loopback *gb =3D dev_get_drvdata(dev);			\
> >-	return sprintf(buf, "%"#type"\n", gb->field);			\
> >+	return sprintf(buf, "%" #type "\n", gb->field);			\
> >  }									\
> >  static ssize_t field##_store(struct device *dev,			\
> >  			    struct device_attribute *attr,		\
> >
> Eh.
>=20
> But doesn't all of this add an extra two space to the resultant string ?
>=20
> Not what we want.

It doesn't change the result string, if I well understand the question your
doubt is if there are some space between % and type or between type and
end of line:

This (supposing type=3Du and field=3Dmin):
 return sprintf(buf, "%"#type"\n", gb->field);
Will expanded in this
 return sprintf(buf, "%""u""\n", gb->min);
That's is like:
 return sprintf(buf, "%u\n", gb->min);

This (supposing type=3Du and field=3Dmin):
return sprintf(buf, "%" #type "\n", gb->field);
Will expanded in this
 return sprintf(buf, "%" "u" "\n", gb->min);
That's is like:
 return sprintf(buf, "%u\n", gb->min);

>=20
> ---
> bod

--0F1p//8PRICkK4MW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJcCDxuAAoJEAnJ2Lo5pAXyE7kQAI9hw/akm2KI6P37qIEWhcHe
H4dsIjB7/uMB79462NZ6dbgktuhRxCqWvXmfRHgHzV3khGmQ+PXH8kj5LoknTOOV
I8TpT/vPzxjQuXsDSesvXhLKYeRyCXIIKMFTVzpVnpl57qUQnZZieyixFpGn5Q91
k9iiZPjpLvcZaS4hltsG/makwSdLbzd6xHrnO9TUet8KErd8UCsHUczGpFFL6Awq
pCk9Yy+oImIVoRNklJciUF6qeZs4+gBHrEhCX2H36SPfCS2GnCec7ugv/WX4HDtQ
rHes5lx/f8PIsG7zkneay5f8Jgp0+WvnJzqZM/sQRLJDznEio66rdVs3oGl8YSyD
3zLRkvmS6q1aXZetKOStwqkF9ntb/l/FMPR9qjIPlL4KHdOfv45k6W3QnAADO66j
QTfYU++6cRZfuOsLEbfDDmZWB1Ik/UDKyDS4dU7mGnnmfrh1HyUdMjIVMmcL/BoR
WfbGoZOdsGlc4GC8V3JgilzkvRcRwHFshsR2gAGcp5vr9Ot/El69hm8ZzVKTgiKX
Ub4utnXit5hsUL9O8RiJHaLHw0V9Z5b/RKJYXQEG7m+HMiSQ1JiL6ZSsNqNqkSW5
+huP39+CnjHcleGMnkqXgNQdkq7QsBXwzsvbbBCa8mdycmCAaOPLPQb6Hwd7Lsg1
TK74teYQGQBt04DLkVn6
=mbVF
-----END PGP SIGNATURE-----

--0F1p//8PRICkK4MW--