Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9954286imu; Wed, 5 Dec 2018 13:14:49 -0800 (PST) X-Google-Smtp-Source: AFSGD/U/LwvgIuTDCfyjwiHdH0lsSDKcRnLL9syGIRIZ02LVPupNR25dcWKnSKSknNfn1ozsdvol X-Received: by 2002:a63:fc49:: with SMTP id r9mr21319213pgk.209.1544044489086; Wed, 05 Dec 2018 13:14:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544044489; cv=none; d=google.com; s=arc-20160816; b=GC0gpM4x7Km84vusZkEZICwHETyY7VPKydaiPkV9MB85ZhQ0cPC8auKfLx1AxvFMnq 6Vm1m1eVr9JZ8PCGfgsbMzbwqbyTRc1jTxvPILrjBnq3CXHj2CVAD/xz1JnjxxQ/K6bV slbBMS062I1xRf52cIsB+tIsTfuEAgBIAftYqzeaGWzrCMeg6a1An5jsGVUgsH2V6cJQ LctTOChldDejuehyIAZky7yOuHK9TKDTUaKB+tsCbT1y1j8l/LJ7I+Nf8LTyJXYY2vU8 6bjUXfeL9B/rHKtVPlHHWL/vzrurO48OESL4AaZjpMg+limP8vjsDVMwQHo5ubqMDP/E meTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=IMLARoIa3Yz+W3sDU4jz4bfmx64s4C98F6yoB/esx1g=; b=eUw/k38acX/bs6AzZhkoYuzaIFxM2cZISCHDNSJqsoLiiKIzTkMRuzGtN/a7gE3B7E lm9KNdMMJ2QXgDYKMXGs1myFa9qVXxhU2FWGwPAP+B1zQJE8BvBNqH4qsd+SpBwAoxMP 0r1PqSxyZdMtYuU31Uwncya+Ic30ZKqIJWMdsjxTjopuXe1E4CUki21YiguaspBSubrX aA0Fj1o8/ebZKJll4wFig/YDTiaxGJzJ+MVxyCGgkpSaS16DLV1xLWoL2OIsNTWK438d h298bOGj3ylDvNPvqIgk7Ya88bBdNdKTJD4gBm2Z5xZds4gJfLiG5xET4siLrDmHHNyA Mn9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=JYe9eSxC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si20601557pfh.229.2018.12.05.13.14.33; Wed, 05 Dec 2018 13:14:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=JYe9eSxC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728398AbeLEVN6 (ORCPT + 99 others); Wed, 5 Dec 2018 16:13:58 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34360 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728238AbeLEVN5 (ORCPT ); Wed, 5 Dec 2018 16:13:57 -0500 Received: by mail-ed1-f66.google.com with SMTP id b3so18285264ede.1 for ; Wed, 05 Dec 2018 13:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=IMLARoIa3Yz+W3sDU4jz4bfmx64s4C98F6yoB/esx1g=; b=JYe9eSxCbW1H8LYRDJvcG5LXg+Xamr0KV/5cUaOTNe/nWiWnJUYaw7A9NM/j/FRsFX YRznBTlnKD0hq24syuDouULehUZjZ2IXuB8g6aom0B0nhyD2ong05INBF4+ENYYiNPyJ ahpnH4AG/n12a5h3kmIOk/xTuBkEGJ+zs4CRhpuwH7yfkgRGSkUYPwNqwDr8aSbnbsUM BDmGuUiPQQ1Jxm6QyBd+m9aWn9KSegj1SpYrYMxdOFjH7YZzLGeS7UACMD0uQMvRpa/X lNm3BcyGGG+sWfLWffLbxLSVHsJp8zghZWTUTqKof4Jo5bPDGAMt7PVZUVxEk6UPN39Y vODQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=IMLARoIa3Yz+W3sDU4jz4bfmx64s4C98F6yoB/esx1g=; b=l5P3Nh/XcfY/HRjBIbN9a5t/V8yd1SUgOJski9nesj6dDKvmwtR/ndM4iM1gYbgYZU reiSUF8LsI1+aARht6UbWfOboNqb/t8mhMXEUfAto/jvFomJr+9cTQ4rfSXJHBH4l3iO tU8rAZr471QxJ4uZKAj5BR2dRDLIHjUhwLnMVuYwQ1Mk6M40OQFoZew4ORvejCK6K8oz h1cBbDhCwmvF77suwuA1UWOfC1mLqKib42IvHUi9eSLdc0v4RX2FGCLn+PPatK5F52go AZ13282a5JbYB7juo58oNf+KGomOfAZ6rGEtXPcfw/bgivO075iw1iEWWRoSIunBu9tA zMvg== X-Gm-Message-State: AA+aEWZfRGg5h5cRCtO1k6on8RZX0DNY0wau2dfzYJKQep2tn+65Lmiu dCPEhCAo1WTQ6AlijHJzihA= X-Received: by 2002:a17:906:3ce9:: with SMTP id d9-v6mr20098676ejh.236.1544044435971; Wed, 05 Dec 2018 13:13:55 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id c11-v6sm3252924ejz.70.2018.12.05.13.13.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Dec 2018 13:13:54 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gUeUU-0001Ot-44; Wed, 05 Dec 2018 22:13:54 +0100 From: Peter Korsgaard To: Jean Delvare , linux-kernel@vger.kernel.org Cc: Peter Korsgaard Subject: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID" Date: Wed, 5 Dec 2018 22:13:51 +0100 Message-Id: <20181205211351.5309-1-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. The output of dmi_save_uuid() is exposed to user space as /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility, E.G. I have systems that include the content of dmi/id/product_uuid as part of the keyphrase for cryptsetup luksOpen. As the change was purely cosmetical, revert it to fix such breakage. Signed-off-by: Peter Korsgaard --- drivers/firmware/dmi_scan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 099d83e4e910..2ed51651565f 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -211,9 +211,9 @@ static void __init dmi_save_uuid(const struct dmi_header *dm, int slot, * says that this is the defacto standard. */ if (dmi_ver >= 0x020600) - sprintf(s, "%pUl", d); + sprintf(s, "%pUL", d); else - sprintf(s, "%pUb", d); + sprintf(s, "%pUB", d); dmi_ident[slot] = s; } -- 2.11.0