Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?utf-8?B?UGF3ZcWC?= Chmiel <pawel.mikolaj.chmiel@gmail.com>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        linux-kernel@vger.kernel.org, Jonathan Bakker <xc-racer2@live.ca>
Subject: Re: [PATCH] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading
Date:   Wed, 05 Dec 2018 22:24:39 +0100
Message-ID: <73529966.IuFOuslu9h@acerlaptop>
In-Reply-To: <BBB949C2-B1CB-478E-9BBF-E39FCA7271EF@holtmann.org>
References: <20181205194538.8074-1-pawel.mikolaj.chmiel@gmail.com> <BBB949C2-B1CB-478E-9BBF-E39FCA7271EF@holtmann.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dnia =C5=9Broda, 5 grudnia 2018 22:02:30 CET Marcel Holtmann pisze:
> Hi Pawel,
>=20
> > The Broadcom controller on aries S5PV210 boards sends out a couple of
> > unknown packets after the firmware is loaded.  This will cause
> > logging of errors such as:
> > 	Bluetooth: hci0: Frame reassembly failed (-84)
> >=20
> > This is probably also the case with other boards, as there are related
> > Android userspace patches for custom ROMs such as
> > https://review.lineageos.org/#/c/LineageOS/android_system_bt/+/142721/
> > Since this appears to be intended behaviour, treated them as diagnostic
> > packets.
> >=20
> > Note that this is another variant of commit 01d5e44ace8a=20
> > ("Bluetooth: hci_bcm: Handle empty packet after firmware loading")
> >=20
> > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> > Signed-off-by: Pawe=C5=82 Chmiel <pawel.mikolaj.chmiel@gmail.com>
> > ---
> > drivers/bluetooth/hci_bcm.c | 32 +++++++++++++++++++++++++++-----
> > 1 file changed, 27 insertions(+), 5 deletions(-)
> >=20
> > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> > index ddbd8c6a0ceb..ae271836dc26 100644
> > --- a/drivers/bluetooth/hci_bcm.c
> > +++ b/drivers/bluetooth/hci_bcm.c
> > @@ -51,6 +51,12 @@
> > #define BCM_LM_DIAG_PKT 0x07
> > #define BCM_LM_DIAG_SIZE 63
> >=20
> > +#define BCM_UNKNOWN_PKT 0x31
> > +#define BCM_UNKNOWN_SIZE 0
> > +
> > +#define BCM_UNKNOWN2_PKT 0x34
> > +#define BCM_UNKNOWN2_SIZE 0
> > +
>=20
> lets use BCM_TYPE49_ and BCM_TYPE52_
>=20
> > #define BCM_AUTOSUSPEND_DELAY	5000 /* default autosleep delay */
> >=20
> > /**
> > @@ -561,12 +567,28 @@ static int bcm_setup(struct hci_uart *hu)
> > 	.lsize =3D 0, \
> > 	.maxlen =3D BCM_NULL_SIZE
> >=20
> > +#define BCM_RECV_UNKNOWN \
> > +	.type =3D BCM_UNKNOWN_PKT, \
> > +	.hlen =3D BCM_UNKNOWN_SIZE, \
> > +	.loff =3D 0, \
> > +	.lsize =3D 0, \
> > +	.maxlen =3D BCM_UNKNOWN_SIZE
> > +
> > +#define BCM_RECV_UNKNOWN2 \
> > +	.type =3D BCM_UNKNOWN2_PKT, \
> > +	.hlen =3D BCM_UNKNOWN2_SIZE, \
> > +	.loff =3D 0, \
> > +	.lsize =3D 0, \
> > +	.maxlen =3D BCM_UNKNOWN2_SIZE
>=20
> Same here, BCM_RECV_TYPE49 and BCM_RECV_TYPE52.
>=20
> > +
> > static const struct h4_recv_pkt bcm_recv_pkts[] =3D {
> > -	{ H4_RECV_ACL,      .recv =3D hci_recv_frame },
> > -	{ H4_RECV_SCO,      .recv =3D hci_recv_frame },
> > -	{ H4_RECV_EVENT,    .recv =3D hci_recv_frame },
> > -	{ BCM_RECV_LM_DIAG, .recv =3D hci_recv_diag  },
> > -	{ BCM_RECV_NULL,    .recv =3D hci_recv_diag  },
> > +	{ H4_RECV_ACL,       .recv =3D hci_recv_frame },
> > +	{ H4_RECV_SCO,       .recv =3D hci_recv_frame },
> > +	{ H4_RECV_EVENT,     .recv =3D hci_recv_frame },
> > +	{ BCM_RECV_LM_DIAG,  .recv =3D hci_recv_diag  },
> > +	{ BCM_RECV_NULL,     .recv =3D hci_recv_diag  },
> > +	{ BCM_RECV_UNKNOWN,  .recv =3D hci_recv_diag  },
> > +	{ BCM_RECV_UNKNOWN2, .recv =3D hci_recv_diag  },
> > };
> >=20
> > static int bcm_recv(struct hci_uart *hu, const void *data, int count)
>=20
> Regards
>=20
> Marcel
>=20
Hi
=46ixed in v2 version of patch.

Thanks for review.