Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Korsgaard <peter@korsgaard.com>
To:     Jean Delvare <jdelvare@suse.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"
References: <20181205211351.5309-1-peter@korsgaard.com>
Date:   Wed, 05 Dec 2018 22:36:46 +0100
In-Reply-To: <20181205211351.5309-1-peter@korsgaard.com> (Peter Korsgaard's
        message of "Wed, 5 Dec 2018 22:13:51 +0100")
Message-ID: <87mupjzmdt.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7.
 > The output of dmi_save_uuid() is exposed to user space as
 > /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility,
 > E.G.  I have systems that include the content of dmi/id/product_uuid as part
 > of the keyphrase for cryptsetup luksOpen.

 > As the change was purely cosmetical, revert it to fix such breakage.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Sorry, this should have had a:

Cc: stable@vger.kernel.org

As 4.19 is affected. Jean, can you add that when committing?


> ---
 >  drivers/firmware/dmi_scan.c | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
 > index 099d83e4e910..2ed51651565f 100644
 > --- a/drivers/firmware/dmi_scan.c
 > +++ b/drivers/firmware/dmi_scan.c
 > @@ -211,9 +211,9 @@ static void __init dmi_save_uuid(const struct dmi_header *dm, int slot,
 >  	 * says that this is the defacto standard.
 >  	 */
 >  	if (dmi_ver >= 0x020600)
 > -		sprintf(s, "%pUl", d);
 > +		sprintf(s, "%pUL", d);
 >  	else
 > -		sprintf(s, "%pUb", d);
 > +		sprintf(s, "%pUB", d);
 
 >  	dmi_ident[slot] = s;
 >  }
 > -- 
 > 2.11.0


-- 
Bye, Peter Korsgaard