Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181016214659.22362-1-daniel.diaz@linaro.org> <CACRpkda1i_NDnBGgrEoY2ewdSvSnJFVLWWvmSGCu0sNS0hLyiQ@mail.gmail.com>
In-Reply-To: <CACRpkda1i_NDnBGgrEoY2ewdSvSnJFVLWWvmSGCu0sNS0hLyiQ@mail.gmail.com>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Thu, 6 Dec 2018 00:15:13 +0100
Message-ID: <CADYN=9LEVUgz_ou6kWrXZGBpUZ5Ti7BB+0Uxp1NtP18BJDVHCg@mail.gmail.com>
Subject: Re: [PATCH] selftests: gpio: Find libmount with pkg-config if available
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     =?UTF-8?B?RGFuaWVsIETDrWF6?= <daniel.diaz@linaro.org>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Bamvor Zhang <bamv2005@gmail.com>, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 5 Dec 2018 at 22:50, Linus Walleij <linus.walleij@linaro.org> wrote=
:
>
> Sorry for top-posting,
>
> I don't understand the selftest environment very well so I do not know
> if this is the right thing to do.
>
> I can merge the patch through the GPIO tree but I need a nod from
> someone wise, like Shuah Khan or Anders Roxell (Anders has been
> using the GPIO selftests) that this is the direction we want to go.

Yes this makes sense and its already in linux-next.

Cheers,
Anders

>
> Yours,
> Linus Walleij
>
> On Tue, Oct 16, 2018 at 11:47 PM Daniel D=C3=ADaz <daniel.diaz@linaro.org=
> wrote:
>
> > If pkg-config is available, use it to define the CFLAGS and
> > LDLIBS needed for libmount; else, use the current hard-coded
> > paths and options.
> >
> > Using pkg-config is very helpful for cross-compilation
> > environments, and is sometimes readily available on developer
> > boxes to ensure we get the right compiler/linker options for
> > the given package.
> >
> > Signed-off-by: Daniel D=C3=ADaz <daniel.diaz@linaro.org>
> > ---
> >  tools/testing/selftests/gpio/Makefile | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/self=
tests/gpio/Makefile
> > index 46648427d537..f22b22aef7bf 100644
> > --- a/tools/testing/selftests/gpio/Makefile
> > +++ b/tools/testing/selftests/gpio/Makefile
> > @@ -1,7 +1,13 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >
> > -CFLAGS +=3D -O2 -g -std=3Dgnu99 -Wall -I../../../../usr/include/
> > -LDLIBS +=3D -lmount -I/usr/include/libmount
> > +MOUNT_CFLAGS :=3D $(shell pkg-config --cflags mount 2>/dev/null)
> > +MOUNT_LDLIBS :=3D $(shell pkg-config --libs mount 2>/dev/null)
> > +ifeq ($(MOUNT_LDLIBS),)
> > +MOUNT_LDLIBS :=3D -lmount -I/usr/include/libmount
> > +endif
> > +
> > +CFLAGS +=3D -O2 -g -std=3Dgnu99 -Wall -I../../../../usr/include/ $(MOU=
NT_CFLAGS)
> > +LDLIBS +=3D $(MOUNT_LDLIBS)
> >
> >  TEST_PROGS :=3D gpio-mockup.sh
> >  TEST_FILES :=3D gpio-mockup-sysfs.sh
> > --
> > 2.17.1
> >