Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>
Cc:     ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
        zhong.weidong@zte.com.cn, Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH] ocfs2: fix memdup.cocci warnings
Date:   Thu, 6 Dec 2018 16:43:25 +0800
Message-Id: <20181206084325.20773-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

fs/ocfs2/localalloc.c:1289:14-21: WARNING opportunity for kmemdup
fs/ocfs2/localalloc.c:441:14-21: WARNING opportunity for kmemdup

Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Mark Fasheh <mark@fasheh.com>
CC: Joel Becker <jlbec@evilplan.org>
CC: ocfs2-devel@oss.oracle.com
CC: linux-kernel@vger.kernel.org
---
 fs/ocfs2/localalloc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
index 58973e4d2471..3f3047fb934b 100644
--- a/fs/ocfs2/localalloc.c
+++ b/fs/ocfs2/localalloc.c
@@ -438,12 +438,11 @@ void ocfs2=5Fshutdown=5Flocal=5Falloc(struct ocfs2=5F=
super *osb)
 	bh =3D osb->local=5Falloc=5Fbh;
 	alloc =3D (struct ocfs2=5Fdinode *) bh->b=5Fdata;
=20
-	alloc=5Fcopy =3D kmalloc(bh->b=5Fsize, GFP=5FNOFS);
+	alloc=5Fcopy =3D kmemdup(alloc, bh->b=5Fsize, GFP=5FNOFS);
 	if (!alloc=5Fcopy) {
 		status =3D -ENOMEM;
 		goto out=5Fcommit;
 	}
-	memcpy(alloc=5Fcopy, alloc, bh->b=5Fsize);
=20
 	status =3D ocfs2=5Fjournal=5Faccess=5Fdi(handle, INODE=5FCACHE(local=5Fal=
loc=5Finode),
 					 bh, OCFS2=5FJOURNAL=5FACCESS=5FWRITE);
@@ -1286,13 +1285,12 @@ static int ocfs2=5Flocal=5Falloc=5Fslide=5Fwindow(s=
truct ocfs2=5Fsuper *osb,
 	 * local alloc shutdown won't try to double free main bitmap
 	 * bits. Make a copy so the sync function knows which bits to
 	 * free. */
-	alloc=5Fcopy =3D kmalloc(osb->local=5Falloc=5Fbh->b=5Fsize, GFP=5FNOFS);
+	alloc=5Fcopy =3D kmemdup(alloc, osb->local=5Falloc=5Fbh->b=5Fsize, GFP=5F=
NOFS);
 	if (!alloc=5Fcopy) {
 		status =3D -ENOMEM;
 		mlog=5Ferrno(status);
 		goto bail;
 	}
-	memcpy(alloc=5Fcopy, alloc, osb->local=5Falloc=5Fbh->b=5Fsize);
=20
 	status =3D ocfs2=5Fjournal=5Faccess=5Fdi(handle,
 					 INODE=5FCACHE(local=5Falloc=5Finode),
--=20
2.19.1