Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     Bob Copeland <me@bobcopeland.com>
Cc:     linux-karma-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
        Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH] omfs: Use kmemdup instead of duplicating its function
Date:   Thu, 6 Dec 2018 17:02:10 +0800
Message-Id: <20181206090210.39624-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.

This issue was detected with the help of coccinelle.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Bob Copeland <me@bobcopeland.com>
CC: linux-karma-devel@lists.sourceforge.net
CC: linux-kernel@vger.kernel.org
---
 fs/omfs/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index e5258fefcd2b..195c6baa3c8e 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,11 @@ static int omfs=5Fget=5Fimap(struct super=5Fblock *sb)
 		bh =3D sb=5Fbread(sb, block++);
 		if (!bh)
 			goto nomem=5Ffree;
-		*ptr =3D kmalloc(sb->s=5Fblocksize, GFP=5FKERNEL);
+		*ptr =3D kmemdup(bh->b=5Fdata, sb->s=5Fblocksize, GFP=5FKERNEL);
 		if (!*ptr) {
 			brelse(bh);
 			goto nomem=5Ffree;
 		}
-		memcpy(*ptr, bh->b=5Fdata, sb->s=5Fblocksize);
 		if (count < sb->s=5Fblocksize)
 			memset((void *)*ptr + count, 0xff,
 				sb->s=5Fblocksize - count);
--=20
2.19.1