Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10493815imu; Thu, 6 Dec 2018 01:59:55 -0800 (PST) X-Google-Smtp-Source: AFSGD/VpMYFbl2pMQ0CYo2YeK8FDUz7DyKXT/uIvORi29AEcu4dc5vwyTrsHHYmWd8WIDDDgvmpe X-Received: by 2002:a63:5455:: with SMTP id e21mr23719860pgm.316.1544090395119; Thu, 06 Dec 2018 01:59:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544090395; cv=none; d=google.com; s=arc-20160816; b=OWHj3azaOGYK9mJ9KaahB882fcNITpsy2gzcEunDTE+pTK3c9/QzUubTx4McndKs6r 42CUkjZJdxliPMcVSE+r0SKWh0eL2ygYhxMmPWPs2z+O1ImKdgRjRImhHzUjauMKJ/Qh kjvx/hwplKHtsdgk6fIW4wvLTGYBk+ShuDU+wqbJ4aPPfrdY2sXExrNrmVI+jun4UaH5 PdexDzWoI1WxRiG5yh8LNyMkZD1XupDwoSTqkn7gsbbM1+tzVmHml1hD2ZIn8QdGQXNG F1GuDmjHh26VKnZXUPoBbjGT/JtURdPfXPeuwRS9Gj6RxuFO7FP3OdrnAmTQwSHIDB+L m78w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pphfmW7d0SKARFYi8RfqJI9+aTtVREWwtRPx6ZqaDk8=; b=joH+ol8tH2bqJ3+bbpAtpVPzInnzOOd1ejcMtWt5xf0MQ2qcEc2xsF14LYvgxtxKn/ 9f211EYs4JCcVmiopW9+4yOEzMVNSVUY8T0wnpKUprv8LD1hcjlx9KPFyBBo3sADDU25 Ru5Cooy8zitLvWyUi6k4XVfYobKvon2AigpUhAIj4tqMklbI9N9vf9qwfBgjNohNwqcX TYdwYbDJQVCg8xMIQs5WR3Lp0863+ZytTWrkkFHj1r5bmhv+tzmFbCwoVjqcW452CB42 yDLnQIAXFgC6ZDh6Ep77JHS3W5AcTMQk77OKZEHYJSUhLopOtwxliWxjum9c4qdJgxQ8 LqYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=hR5Ub0E4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f35si18784849pgf.449.2018.12.06.01.59.39; Thu, 06 Dec 2018 01:59:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=hR5Ub0E4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729336AbeLFJ5e (ORCPT + 99 others); Thu, 6 Dec 2018 04:57:34 -0500 Received: from merlin.infradead.org ([205.233.59.134]:46902 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbeLFJ5d (ORCPT ); Thu, 6 Dec 2018 04:57:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pphfmW7d0SKARFYi8RfqJI9+aTtVREWwtRPx6ZqaDk8=; b=hR5Ub0E4lm2kuUbuuX+YKzBiP Dtuj+kdDan5VDeZ5y6FiBUHhqA+DWbQPhlSLPwth2VCOq50deoS1KMXl/xxe1nlGVaXqBJ6UlRjVx Ctw/Ph99rEGP5fWmw3ddJyyaaWE6PL42ghSqdklytXLl1A6R1FV4LTG+5hmeUjMdQLLTnmrnwWHoJ qLrX0wboFlsfRuhj/f8ytWyDSIVLvn7agsLdRBZtXeBOXpohqHjzOehbcnkIPJxgxsxVxJBDzdhBQ wsK4+tvd++M6JzV2lIOSJ4gc+SDGeY/+EGIPlWZOLdpWmtjdsTO2gECbfPYQnirLRGNHm1wEQTB9C amHynOdvQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUqPE-0005Mw-Ag; Thu, 06 Dec 2018 09:57:16 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1EC27200FBC3D; Thu, 6 Dec 2018 10:57:15 +0100 (CET) Date: Thu, 6 Dec 2018 10:57:15 +0100 From: Peter Zijlstra To: Nadav Amit Cc: Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Borislav Petkov , Andy Lutomirski , Nadav Amit , Dave Hansen , linux_dti@icloud.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Rick P Edgecombe , Will Deacon Subject: Re: [PATCH v7 13/14] module: Do not set nx for module memory before freeing Message-ID: <20181206095715.GD13538@hirez.programming.kicks-ass.net> References: <20181205013408.47725-1-namit@vmware.com> <20181205013408.47725-14-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181205013408.47725-14-namit@vmware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 05:34:07PM -0800, Nadav Amit wrote: > So let's remove it. Andy suggested that the changes of the PTEs can be > avoided (excluding the direct-mapping alias), which is true. However, > in x86 it requires some cleanup of the contiguous page allocator, which > is outside of the scope of this patch-set. I think x86-cpa stands for change_page_attr() :-)