Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10499100imu; Thu, 6 Dec 2018 02:05:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/UlwQYHqIVIvBfFpg4MWkbNvw5AEbV4OcQsMf3jbNubZI0KbfokK81PJEtFvISNCEb2Ex83 X-Received: by 2002:a63:f444:: with SMTP id p4mr23232564pgk.124.1544090720759; Thu, 06 Dec 2018 02:05:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544090720; cv=none; d=google.com; s=arc-20160816; b=ku7Xr87qoVwK9/2kKI7XxfMzfwHKN25ql9Ak/FPYvrIBzO+CdaqA/wnm0EJGJAhTnK SxpK/I3TLvMmJbI9E+FWWWTqXQbInZEZ3+6vSX3pksQ9OElNOQgDAqGmz0xWbbYSCBiq zwukvF9YUXRCMbdwk+Opyu3SC+eqlt4CBA33LA0AnLxjP3/X7HKtjky5ieh982M7M5cc 8TEUVPOhaHz9/Pz4gxcMOSUA2TzKsphYRW9ENyQe4DLdT6JBs2+RWJ9kpqkwL5Ge90oj ZC3B5/s/mMTK2Xo3ZCPlJuAiHh5pzRZ0mD1OurJQS6toJbSBhNJGptFdpj34Ebn6pqre HQ8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HlaGWWi8LkZfqvCi2OdFYWS0HdAJJvaQ0rex+PNIDyo=; b=W7asrJtkN8skPNCC2p/lNOon7NAqrpTn+XQaAiSgGPLpvh1qXlwaWfNQ6unF9JhPJ5 4Z2cWpa0d3WxIr8A6UUZSJ31rO7jH5FGoF1gTZfLt9W7eRqsn800BuX2Ph7I+l+f046G JgiferJm486eYPTKllQKXpXrZCuV240puIOJIiqNl8edeot/n71Zf5SmoeNfuJ7qfW33 PmnNHTtJuOGohUaRw4DFbnA5p9xx0+pWIzF1TKELst5winWDZAHakscL0eel3CxV+YGG Lj22jHgn/qZ0tSd/JLpHbis87c0V/lkEEc/ssFKLVukP/Ic+f1F8hAP2JLIQ0S8qRE+Z un4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=V2UEIS5Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k38si20109208pgi.235.2018.12.06.02.05.03; Thu, 06 Dec 2018 02:05:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=V2UEIS5Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729259AbeLFKDn (ORCPT + 99 others); Thu, 6 Dec 2018 05:03:43 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:51198 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727575AbeLFKDn (ORCPT ); Thu, 6 Dec 2018 05:03:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HlaGWWi8LkZfqvCi2OdFYWS0HdAJJvaQ0rex+PNIDyo=; b=V2UEIS5YF021vFI58ictaGnxp g5HPOaY9rAtn8EMcbq4NWDAomLwowHYsDcgR+Z7w2zySR87q7bKO4IRiCGiL7f69kXd6xDRq9UyUp Mg/+chWT2r5dzN13N8WfVY6/5pgv+GqJJeYR2kegSYGUGYVJlV77iQumfCeQrn77Ry1AduIfFeFPs s5+7CPj4d386BrDajQ8cquyLMdemoP+4uprDFqhPIwBatkyntaAk77JIw0MtabfCEWeI75ChVO3so KhPKq2Ix1wsGZ205AAw1V/LohZYt5fdxaxZofnQhL5FT3jH+WJ2DK7QYhb9qA/N9L6LipNCVMUtQJ ZrLaoruzg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUqVO-0007bk-Pl; Thu, 06 Dec 2018 10:03:38 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4D26C200FBC3D; Thu, 6 Dec 2018 11:03:37 +0100 (CET) Date: Thu, 6 Dec 2018 11:03:37 +0100 From: Peter Zijlstra To: Nadav Amit Cc: Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Borislav Petkov , Andy Lutomirski , Nadav Amit , Dave Hansen , linux_dti@icloud.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v7 00/14] x86/alternative: text_poke() enhancements Message-ID: <20181206100337.GF13538@hirez.programming.kicks-ass.net> References: <20181205013408.47725-1-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181205013408.47725-1-namit@vmware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 05:33:54PM -0800, Nadav Amit wrote: > Which leads me to (b) - the patch-set is big "enough" IMHO. Indeed, > there are open security issues in the kernel when it comes to W^X. But > some people would want to use Andy's temporary mm-struct for other uses. > So additional security hardening may be left for future patches. Yes, at the very least we should get the first 7 patches merged, since they work and clean up the text poking irrespective of all that W^X munging. (also, I think you lost my ACK)