Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 6 Dec 2018 11:15:55 +0100
From:   Petr Mladek <pmladek@suse.com>
To:     Miroslav Benes <mbenes@suse.cz>
Cc:     Joe Lawrence <joe.lawrence@redhat.com>,
        Jiri Kosina <jikos@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jason Baron <jbaron@akamai.com>,
        Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 00/11] livepatch: Atomic replace feature
Message-ID: <20181206101555.cydbzb7smubzsavn@pathway.suse.cz>
References: <20181129094431.7801-1-pmladek@suse.com>
 <176e592d-6e9c-8e1c-abe6-d07ba9b10d54@redhat.com>
 <20181206075404.rv4qyw2u5auvfiuz@pathway.suse.cz>
 <alpine.LSU.2.21.1812061031030.17628@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.21.1812061031030.17628@pobox.suse.cz>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu 2018-12-06 10:32:00, Miroslav Benes wrote:
> 
> > > I don't have many code comments as the changes appear to safely and
> > > correctly do what the say.  (We are at v14 after all :)  I mainly
> > > compared the text and comments to the implementation and noted typos
> > > (marked by substitution s/old/new) and awkward wordings (marked by
> > > "re-wording suggestion").  That said, I ack'd each patch as I wouldn't
> > > want these to hold up the patchset.
> > 
> > Thanks a lot both you and Miroslav for the review.
> > 
> > I'll give it some more days before I prepare v15. I wonder if Josh
> > could find some cycle to look at it at least from the top level.
> 
> For what is worth, I'm fine with all the changes Joe proposed and you can 
> preserve my acks there.

We need enough time for bikeshedding about comments and documentation.
I need some time to recover. And I still hope that Josh can give it
a spin.

Best Regards,
Petr