Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 6 Dec 2018 20:08:25 +0900
From:   Alice Ferrazzi <alice.ferrazzi@gmail.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Jason Baron <jbaron@akamai.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 01/11] livepatch: Change unsigned long old_addr ->
 void *old_func in struct klp_func
Message-ID: <20181206110817.GA14038@gmail.com>
References: <20181129094431.7801-1-pmladek@suse.com>
 <20181129094431.7801-2-pmladek@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU"
Content-Disposition: inline
In-Reply-To: <20181129094431.7801-2-pmladek@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The 11/29/2018 10:44, Petr Mladek wrote:
> The address of the to be patched function and new function is stored
s/new/the new/
> in struct klp_func as:
>=20
> 	void *new_func;
> 	unsigned long old_addr;
>=20
> The different naming scheme and type is derived from the way how
s/is/are/
> the addresses are set. @old_addr is assigned at runtime using
> kallsyms-based search. @new_func is statically initialized,
> for example:
>=20
>   static struct klp_func funcs[] =3D {
> 	{
> 		.old_name =3D "cmdline_proc_show",
> 		.new_func =3D livepatch_cmdline_proc_show,
> 	}, { }
>   };
>=20
> This patch changes unsigned log old_addr -> void *old_func. It removes
> some confusion when these address are later used in the code. It is
> motivated by a followup patch that adds special NOP struct klp_func
> where we want to assign func->new_func =3D func->old_addr respectively
> func->new_func =3D func->old_func.
>=20
> This patch does not modify the existing behavior.
>=20
> Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Petr Mladek <pmladek@suse.com>

Acked-by: Alice Ferrazzi <alice.ferrazzi@gmail.com>
--=20
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Alice Ferrazzi
PGP: 2E4E 0856 461C 0585 1336 F496 5621 A6B2 8638 781A
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

--azLHFNyN32YCQGCU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE+h5loMdcUfRgx4r+1IFYAAgoofkFAlwJAyAACgkQ1IFYAAgo
ofleMQ//a5bAaJIVa7d2BY/vSKA3JMe4dW1vXNu+wDI9msj+uFr7ECBmacvdoIsy
xZVentWe336ewwinsCS5IQ2MLWk8wDYWWnpaO3CNnCL1p9cmTiLrG6jvHI2Q1rL9
ac9aYD9d60HofN2RO6aaznh4KPlajXa8ceJftSJAbwZ2PMNX2L+dAZV+myRRC5q5
YTRIC6uvwkCqdXbZzd0HlBGYaK1gARDXqCZPna2RRS9yiOGVo194tY98m+cyHo5s
QVQndYvBbo1zJDFEcrSnNKQhdYhxQJ7EZBli8KMhn8NlwM7MVj4cqr+Ii6/tX5vO
Old1h5U/J3TI8aUkh30R4m2cJNEZnV0//ROmFGHfdsmg5/S+o4idxOLeeX0UsERM
2QU0zhMd631iWty1RWUb+p7MuAeLzKvlCO2oNIrK7TIno459U+y9RbJiDWpR9oZz
AMdxyBAtuU9sURMnD9HKGSXK2D7pOz/xtmSvyEHokBmqt2qu/CVM0HjH3EO+9oGr
GC2Y0ftsY5K61L5b3gOqVoQpt8EKhQC9vArbR54W3ggRt7oXWWi8ce6G7kuuNSA4
7jGnPLS744i2tsMYKLKzMTQRcpDvb+svghiIWi2ZCPdrAxr4Y2oN69ljJE2CmHgY
KpBfGB8xQd7BXPOhd/Bh95ypMAtd5TMEAlzHck6EaEnf5cmtCpE=
=25iN
-----END PGP SIGNATURE-----

--azLHFNyN32YCQGCU--