Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181205124721.26624-1-linus.walleij@linaro.org>
 <20181205124721.26624-7-linus.walleij@linaro.org> <20181205134345.GF16508@imbe.wolfsonmicro.main>
 <CACRpkdbJsTc2tAyTriz33a75d-1tJdcvdock0fxi7HdJ+EH_Dw@mail.gmail.com>
 <20181205153331.GG16508@imbe.wolfsonmicro.main> <CACRpkdaSuU+v1yZm-GXBH693JbVZysXm6_1939ct50arKJn2qw@mail.gmail.com>
 <20181206103430.GH16508@imbe.wolfsonmicro.main>
In-Reply-To: <20181206103430.GH16508@imbe.wolfsonmicro.main>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 6 Dec 2018 12:47:46 +0100
Message-ID: <CACRpkdaO6-ak74zudmNy1G5rXC0G6UVxOJ8Du82X6bZTPoJhpA@mail.gmail.com>
Subject: Re: [PATCH 06/15 v3] regulator: max8973: Let core handle GPIO descriptor
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 6, 2018 at 11:34 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
> On Thu, Dec 06, 2018 at 09:58:30AM +0100, Linus Walleij wrote:
> > On Wed, Dec 5, 2018 at 4:33 PM Charles Keepax
> > <ckeepax@opensource.cirrus.com> wrote:
> > > On Wed, Dec 05, 2018 at 03:42:06PM +0100, Linus Walleij wrote:
> > > > On Wed, Dec 5, 2018 at 2:43 PM Charles Keepax
> > > > <ckeepax@opensource.cirrus.com> wrote:
> > > > > On Wed, Dec 05, 2018 at 01:47:12PM +0100, Linus Walleij wrote:
> > > > > > @@ -775,10 +779,13 @@ static int max8973_probe(struct i2c_client *client,
> > > > > >               /*
> > > > > >                * We do not let the core switch this regulator on/off,
> > > > > >                * we just leave it on.
> > > > > > +              *
> > > > > > +              * Do not use devm* here: the regulator core takes over the
> > > > > > +              * lifecycle management of the GPIO descriptor.
> > > > > >                */
> > > > > > -             gpiod = devm_gpiod_get_optional(&client->dev,
> > > > > > -                                             "maxim,enable",
> > > > > > -                                             GPIOD_OUT_HIGH);
> > > > > > +             gpiod = gpiod_get_optional(&client->dev,
> > > > > > +                                        "maxim,enable",
> > > > > > +                                        GPIOD_OUT_HIGH);
> > > > >
> > > > > My comment on v2 still stands here, the GPIO is not passed to
> > > > > the regulator core on this path.
> > > >
> > > > Patch 01 should take care of that, did you check it?
> > >
> > > Yeah, patch 1 makes the regulator core consistently handle GPIOs
> > > that are passed into it.
> >
> > Sorry. I confused this patch for the max77686 patch. That
> > one was fixed with patch 01...
> >
> > > However, on the MAX77621 path in this
> > > switch statement the GPIO is never passed into the regulator
> > > core, so the core never takes ownership of it, so the driver still
> > > needs to manage the lifetime.
> > >
> > > It should be a pretty easy fix though as commented on v2, again
> > > apologies for the slow review.
> >
> > OK I switch it to devm_ as you suggested, as we implemented
> > gpiod_unhinge it's a piece of cake nowadays.
> >
>
> You shouldn't really need to use unhinge, you can just use devm
> on the path that doesn't pass it to the core and not on the
> one that does. You just need to update the error case below it to
> use config->ena_gpiod rather than gpiod.

Indeed I just think it will be confusing when people read the code.

It's better consistency if its just devm_* and the  we unhinge the
one we pass to the regulator core IMO.

Yours,
Linus Walleij