Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263851AbUARU5P (ORCPT ); Sun, 18 Jan 2004 15:57:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263893AbUARU5O (ORCPT ); Sun, 18 Jan 2004 15:57:14 -0500 Received: from colin2.muc.de ([193.149.48.15]:33042 "HELO colin2.muc.de") by vger.kernel.org with SMTP id S263851AbUARU5M (ORCPT ); Sun, 18 Jan 2004 15:57:12 -0500 Date: 18 Jan 2004 21:58:00 +0100 Date: Sun, 18 Jan 2004 21:58:00 +0100 From: Andi Kleen To: Linus Torvalds , Andi Kleen , Andrew Morton , jh@suse.cz, Kernel Mailing List Subject: Re: [PATCH] Add noinline attribute Message-ID: <20040118205800.GA68521@colin2.muc.de> References: <20040114083114.GA1784@averell> <20040115074834.GA38796@colin2.muc.de> <20040116101345.GA96037@colin2.muc.de> <20040118204700.GA31601@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040118204700.GA31601@twiddle.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 23 On Sun, Jan 18, 2004 at 12:47:00PM -0800, Richard Henderson wrote: > On Fri, Jan 16, 2004 at 11:13:45AM +0100, Andi Kleen wrote: > > Ok, here is a new patch that does the whole thing in generic code and for > > modules too. I didn't bother to change the sort algorithm because the > > existing one works well enough. > > One, you've still got the function marked __init. Already fixed. > > Two, the format of struct exception_table_entry is arch specific. > That comparison won't work on Alpha, because "insn" is encoded > pc-relative. Hmpf. Would an extable_compare() function in an asm-*/ file work ? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/