Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhong.weidong@zte.com.cn, Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH] media: siano: Use kmemdup instead of duplicating its function
Date:   Thu, 6 Dec 2018 20:29:10 +0800
Message-Id: <20181206122910.50908-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.

This issue was detected with the help of coccinelle.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
CC: linux-media@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 drivers/media/usb/siano/smsusb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/sms=
usb.c
index be3634407f1f..2ffded08407b 100644
--- a/drivers/media/usb/siano/smsusb.c
+++ b/drivers/media/usb/siano/smsusb.c
@@ -225,10 +225,9 @@ static int smsusb=5Fsendrequest(void *context, void *b=
uffer, size=5Ft size)
 		return -ENOENT;
 	}
=20
-	phdr =3D kmalloc(size, GFP=5FKERNEL);
+	phdr =3D kmemdup(buffer, size, GFP=5FKERNEL);
 	if (!phdr)
 		return -ENOMEM;
-	memcpy(phdr, buffer, size);
=20
 	pr=5Fdebug("sending %s(%d) size: %d\n",
 		  smscore=5Ftranslate=5Fmsg(phdr->msg=5Ftype), phdr->msg=5Ftype,
--=20
2.19.1