Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10679983imu; Thu, 6 Dec 2018 05:12:40 -0800 (PST) X-Google-Smtp-Source: AFSGD/W0sxvXEgoNG0eKj2XPcUcCdTMrwGOiGXYtDvI4UZDuQfu/Db/9ndXDdgKpwSOX2MBVo62f X-Received: by 2002:a63:d157:: with SMTP id c23mr23834551pgj.170.1544101960744; Thu, 06 Dec 2018 05:12:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544101960; cv=none; d=google.com; s=arc-20160816; b=dYLtqTLssq4gvuZczqOiL2oS6q3H6MntayvrHs8NGjLAhw9A4T6XZQjSS6MFLv3aoj NI1mbqeo9uBGQyAwprkRwzZ033Ayz75z/3smgBvBzf+yU2yXaGdjz40pL3qoQek6L3oY pceDPQnkjIbgspFHkxcTyDKzfLDpES7gQlLSDZ1Qrd0nhP1Krdx+afkWS/zu4I8Yyf8v krRixzFu8+B0Pzubhipffgj1UaIqlOGCX3G6eHuKOIQawupVfkS1ZoCbwYhLraYxcLnR tCJXxC4LDU8sEzPDaUmuc0i4s/tKx1Jn4nOx8T397t6WtP7XIxaTR7Ue9WPmfPer3g+p zB8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jgaJdCR8YgTdXD4rT+Ph6dUiNSduVqiAkm4fNEkzkdk=; b=cjq8iFMIu3yDKM3ed4zSsw/6IergfevUQF+z4kmlDUdqC6LsiRewIbdNlzclF5UUPG rILF76/qclLzboCFuA/2DMK/bL1q18a+ZJEwu8DKMWfvu20q57XIp3jsAZK8AuwUdJby cDBbDfmOcZE8aPdq4dPdPKzj1IJQZqvPsmI+vaNF8pd7qyXoCyB/IZbZZzNcgEqIKlR3 SY2MdbZMyJgpTcIEwhBFbnXUiXo5seFzzc/f6SBxKsxPHdJJAGjCHfhsM4hTGDZkUp5Z WqJL+BxlruFh+qBhBbxSnw0VzQ1s+rBc8etplchagXo+wUB2P/Q8AB5DVwgiWLsBhZj+ CJpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si278581plg.62.2018.12.06.05.12.21; Thu, 06 Dec 2018 05:12:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729543AbeLFNLK (ORCPT + 99 others); Thu, 6 Dec 2018 08:11:10 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:50136 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728482AbeLFNLK (ORCPT ); Thu, 6 Dec 2018 08:11:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1859DA78; Thu, 6 Dec 2018 05:11:10 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DBEDF3F575; Thu, 6 Dec 2018 05:11:09 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id EEE3A1AE0BAD; Thu, 6 Dec 2018 13:11:30 +0000 (GMT) Date: Thu, 6 Dec 2018 13:11:30 +0000 From: Will Deacon To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, Robin Murphy , linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH 3/9] iommu/arm-smmu: Use helper functions to access dev->iommu_fwspec Message-ID: <20181206131130.GA27744@arm.com> References: <20181204163002.15800-1-joro@8bytes.org> <20181204163002.15800-4-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204163002.15800-4-joro@8bytes.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 05:29:56PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the new helpers dev_iommu_fwspec_get()/set() to access > the dev->iommu_fwspec pointer. This makes it easier to move > that pointer later into another struct. > > Cc: Will Deacon > Cc: Robin Murphy > Signed-off-by: Joerg Roedel > --- > drivers/iommu/arm-smmu-v3.c | 16 +++++++++------- > drivers/iommu/arm-smmu.c | 12 ++++++------ > 2 files changed, 15 insertions(+), 13 deletions(-) Looks straighforward enough to me: Acked-by: Will Deacon Will