Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10721138imu; Thu, 6 Dec 2018 05:50:09 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wi2Sa01UDSNzZSOr8RWJ+FNQYtMtGuhCQXv55p9akfrke7vDiPbQdM8ygyc9YDNlD8EuF2 X-Received: by 2002:a17:902:2887:: with SMTP id f7mr27367490plb.176.1544104209856; Thu, 06 Dec 2018 05:50:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544104209; cv=none; d=google.com; s=arc-20160816; b=rMvrO+duFe21sR0C+sk/gzN1P2XGHOwXgGXC3tOAhbTFNWjwgf9IZALqSAwCPq449a TxvJRo85JU/Z3qz2Lr24am968eG+MDqhr10wqosl5Ye8r4C9hwJXbeXFXe1ucLAZddaC dWSS/5eAmzKNQ/ISlI75tk0IlAMieUl4G2bvGzm/3LvYnLjBVbo7HJl5xchnGyLV++Uk JXCVUuwF+pevsCiqcBtgyj/ZRcj7Jx5s5v+7GodAz5qOWkma0ldt8E+2VgdWt4yZbpDs LVsYJmAFbgN/SRpS+juVvL+TCsWE6/2TvIGQZUw63Q3duC/iyTEm6SZf29ID2hs+kiNl FieA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WsQM2a29/cPrnnCvboH8MWxZUKu5Uz5cJ0JG4n0fhTM=; b=EwsBMhNlmea6TCIJAvogsQtAUk4WFw18RCKZtXb3KOv7GCRRKQwQD3c4fJ+ijVxoVv DQBQDZ8F5tJcxAdcmkSoiNJpWoT/iUAkxKp8a+EkCcqmZlMd5L3wFiYSvlMorqUmFGGL rDc/fFKulnWFecBNSoMCGpiXBcGevORuiV2/gOl0JkxyqiHalNHpCJ7mJUT/8yUjsQK1 aMCQRsblu749mkP9v9nLWqpiWsNGpVporXG+3PtCMV6YYcKJUVt5iQVfpxMR0546XAob /eUKEDZPbJUqMfMM5NPX+PtgvItNtHgdBY0tOnNzt0jmsntYAQQDEhAburOjmBEaIxH5 EUJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x186si330857pgb.33.2018.12.06.05.49.51; Thu, 06 Dec 2018 05:50:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728695AbeLFNtO (ORCPT + 99 others); Thu, 6 Dec 2018 08:49:14 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:34660 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727704AbeLFNtO (ORCPT ); Thu, 6 Dec 2018 08:49:14 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wB6DcaWp015939; Thu, 6 Dec 2018 07:49:03 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0b-001ae601.pphosted.com with ESMTP id 2p3qktrvbc-1; Thu, 06 Dec 2018 07:49:03 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id DC46F611C8B5; Thu, 6 Dec 2018 07:52:40 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Thu, 6 Dec 2018 13:49:02 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wB6Dn1eR005988; Thu, 6 Dec 2018 13:49:02 GMT Date: Thu, 6 Dec 2018 13:49:01 +0000 From: Charles Keepax To: Marek Szyprowski CC: Linus Walleij , Liam Girdwood , Mark Brown , , Bartosz Golaszewski Subject: Re: [PATCH 00/15 v4] Regulator ena_gpiod fixups Message-ID: <20181206134901.GJ16508@imbe.wolfsonmicro.main> References: <20181206124351.10155-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=639 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812060119 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2018 at 02:27:03PM +0100, Marek Szyprowski wrote: > On 2018-12-06 13:43, Linus Walleij wrote: > One more thing - if I got everything right, gpiod_put() in > *regulator_register() error path has to be removed also in > wm8994-regulator.c and arizona-ldo1.c. Indeed yes, good spot. But apart from those additional two patches, series also looks good to me: Reviewed-by: Charles Keepax Thanks, Charles