Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10747345imu; Thu, 6 Dec 2018 06:13:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/WvzXFw5+NuaQV7uqP3BbFogB+JVI1Vb2YRQo4kV+os7cFHZ26rw4nU+FaD05sWZrU5A1GY X-Received: by 2002:a17:902:d891:: with SMTP id b17mr29026076plz.80.1544105583509; Thu, 06 Dec 2018 06:13:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544105583; cv=none; d=google.com; s=arc-20160816; b=lTKr4FsP+ZQ7WxEUeTrHeEl3Y7APDa1XRxtCnnynvt5t8k8pfVmzl5TdqLywGHspb7 26RXSyPkLUJRE69AUoKT6hF2447ncPyOICPjlAwH1AuJ9U8Qo1ZhIPk+ME3nTQ+GskqI vZx3e112q6EfxwpbguK1pfXdxVacVIHhUcUO3j8ITkEpVVkMzHmw2dkScl8Pp9HWs1mO tboAxzP1B6G2R1Y5BtmXFjzo/uO1ic87LX0GlTtfQzFT9aLaA+uhk5rh3O6YMa0/w378 U3Obzj55T9h6GtAZ4Gd3OAh+iq6YVAxIFEVrBQqcg7yGpOnr5w+vzsUoUjDmITaqKyoW nXKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8549A00OoBNGcGb2UherC8bfDxuBRh/wuw4HZS5ufQA=; b=wHfI7F3xIvJlUi+BHztVSMRjPLUXDnWUi9Z8yNDFvRg6D+zs1atbml3P41kEoX+jjs SSxGgGXarr0L7V0BBknHZLM1QwoGN0FePSXNj2Y6KUBkM3xKwwhr3AmezX0VQxZUWCNO DTgDJ07iSs+cwAhFhgXmlW2+ADuL1Wt0cnLGs1gbrn2oj+mGvU6EXr3DExufq6XxbLf+ dk/XyfYiE/WO5IqIu6s8vOyVjq+asdYG6hvmC5QTbajkpJTHpDH8OxujY8nsNPFfYvFa S0SxVRUeT85b442Zd1SqKmJV3IQ49rQEFro/g63uNnH6BlrbwGsnKr2dRATHLsh8lIAP UFNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="FXsk21Q/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce19si386559plb.13.2018.12.06.06.12.47; Thu, 06 Dec 2018 06:13:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="FXsk21Q/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729814AbeLFOKo (ORCPT + 99 others); Thu, 6 Dec 2018 09:10:44 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42376 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbeLFOKo (ORCPT ); Thu, 6 Dec 2018 09:10:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8549A00OoBNGcGb2UherC8bfDxuBRh/wuw4HZS5ufQA=; b=FXsk21Q/B1ffr7DvVgMUyaWlr EbSLJVCeT6zFckd6sIKJUxxCS+GGWCgAip0J9t5ehmMovwQ1E1qxqZQ53WDQBfLpkqti5mlkag+aN 60OwcDzxySVikQkGG4KTw4hDeKhW3JLfaKL42eXOFD6wjanW0VoQy1dmL86bEzpoIK/RRQxARV28z aMI2sFW9HwxOr32xNOGjR/wGVevxV/qvJsYW2ppgwtvg+L+Mf8xr02k3pF/gzOzPLXPZYevijczsg TGqf2+SVATJqEkO73t9e4+R5RyVruFLCEgXyu8IQ6NoZ2qq2NapsZMUDZYNwY5uZnha7gxLGTYeNX QKYLVLvqg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUuMA-0001Bv-GF; Thu, 06 Dec 2018 14:10:22 +0000 Date: Thu, 6 Dec 2018 06:10:22 -0800 From: Christoph Hellwig To: Christoph Hellwig Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/34] powerpc/dma: split the two __dma_alloc_coherent implementations Message-ID: <20181206141022.GG29741@infradead.org> References: <20181114082314.8965-1-hch@lst.de> <20181114082314.8965-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181114082314.8965-7-hch@lst.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping? On Wed, Nov 14, 2018 at 09:22:46AM +0100, Christoph Hellwig wrote: > The implemementation for the CONFIG_NOT_COHERENT_CACHE case doesn't share > any code with the one for systems with coherent caches. Split it off > and merge it with the helpers in dma-noncoherent.c that have no other > callers. > > Signed-off-by: Christoph Hellwig > Acked-by: Benjamin Herrenschmidt > --- > arch/powerpc/include/asm/dma-mapping.h | 5 ----- > arch/powerpc/kernel/dma.c | 14 ++------------ > arch/powerpc/mm/dma-noncoherent.c | 15 +++++++-------- > arch/powerpc/platforms/44x/warp.c | 2 +- > 4 files changed, 10 insertions(+), 26 deletions(-) > > diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h > index f2a4a7142b1e..dacd0f93f2b2 100644 > --- a/arch/powerpc/include/asm/dma-mapping.h > +++ b/arch/powerpc/include/asm/dma-mapping.h > @@ -39,9 +39,6 @@ extern int dma_nommu_mmap_coherent(struct device *dev, > * to ensure it is consistent. > */ > struct device; > -extern void *__dma_alloc_coherent(struct device *dev, size_t size, > - dma_addr_t *handle, gfp_t gfp); > -extern void __dma_free_coherent(size_t size, void *vaddr); > extern void __dma_sync(void *vaddr, size_t size, int direction); > extern void __dma_sync_page(struct page *page, unsigned long offset, > size_t size, int direction); > @@ -52,8 +49,6 @@ extern unsigned long __dma_get_coherent_pfn(unsigned long cpu_addr); > * Cache coherent cores. > */ > > -#define __dma_alloc_coherent(dev, gfp, size, handle) NULL > -#define __dma_free_coherent(size, addr) ((void)0) > #define __dma_sync(addr, size, rw) ((void)0) > #define __dma_sync_page(pg, off, sz, rw) ((void)0) > > diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c > index 6551685a4ed0..d6deb458bb91 100644 > --- a/arch/powerpc/kernel/dma.c > +++ b/arch/powerpc/kernel/dma.c > @@ -62,18 +62,12 @@ static int dma_nommu_dma_supported(struct device *dev, u64 mask) > #endif > } > > +#ifndef CONFIG_NOT_COHERENT_CACHE > void *__dma_nommu_alloc_coherent(struct device *dev, size_t size, > dma_addr_t *dma_handle, gfp_t flag, > unsigned long attrs) > { > void *ret; > -#ifdef CONFIG_NOT_COHERENT_CACHE > - ret = __dma_alloc_coherent(dev, size, dma_handle, flag); > - if (ret == NULL) > - return NULL; > - *dma_handle += get_dma_offset(dev); > - return ret; > -#else > struct page *page; > int node = dev_to_node(dev); > #ifdef CONFIG_FSL_SOC > @@ -110,19 +104,15 @@ void *__dma_nommu_alloc_coherent(struct device *dev, size_t size, > *dma_handle = __pa(ret) + get_dma_offset(dev); > > return ret; > -#endif > } > > void __dma_nommu_free_coherent(struct device *dev, size_t size, > void *vaddr, dma_addr_t dma_handle, > unsigned long attrs) > { > -#ifdef CONFIG_NOT_COHERENT_CACHE > - __dma_free_coherent(size, vaddr); > -#else > free_pages((unsigned long)vaddr, get_order(size)); > -#endif > } > +#endif /* !CONFIG_NOT_COHERENT_CACHE */ > > static void *dma_nommu_alloc_coherent(struct device *dev, size_t size, > dma_addr_t *dma_handle, gfp_t flag, > diff --git a/arch/powerpc/mm/dma-noncoherent.c b/arch/powerpc/mm/dma-noncoherent.c > index b6e7b5952ab5..e955539686a4 100644 > --- a/arch/powerpc/mm/dma-noncoherent.c > +++ b/arch/powerpc/mm/dma-noncoherent.c > @@ -29,7 +29,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include > @@ -151,8 +151,8 @@ static struct ppc_vm_region *ppc_vm_region_find(struct ppc_vm_region *head, unsi > * Allocate DMA-coherent memory space and return both the kernel remapped > * virtual and bus address for that space. > */ > -void * > -__dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *handle, gfp_t gfp) > +void *__dma_nommu_alloc_coherent(struct device *dev, size_t size, > + dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs) > { > struct page *page; > struct ppc_vm_region *c; > @@ -223,7 +223,7 @@ __dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *handle, gfp_t > /* > * Set the "dma handle" > */ > - *handle = page_to_phys(page); > + *dma_handle = phys_to_dma(dev, page_to_phys(page)); > > do { > SetPageReserved(page); > @@ -249,12 +249,12 @@ __dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *handle, gfp_t > no_page: > return NULL; > } > -EXPORT_SYMBOL(__dma_alloc_coherent); > > /* > * free a page as defined by the above mapping. > */ > -void __dma_free_coherent(size_t size, void *vaddr) > +void __dma_nommu_free_coherent(struct device *dev, size_t size, void *vaddr, > + dma_addr_t dma_handle, unsigned long attrs) > { > struct ppc_vm_region *c; > unsigned long flags, addr; > @@ -309,7 +309,6 @@ void __dma_free_coherent(size_t size, void *vaddr) > __func__, vaddr); > dump_stack(); > } > -EXPORT_SYMBOL(__dma_free_coherent); > > /* > * make an area consistent. > @@ -401,7 +400,7 @@ EXPORT_SYMBOL(__dma_sync_page); > > /* > * Return the PFN for a given cpu virtual address returned by > - * __dma_alloc_coherent. This is used by dma_mmap_coherent() > + * __dma_nommu_alloc_coherent. This is used by dma_mmap_coherent() > */ > unsigned long __dma_get_coherent_pfn(unsigned long cpu_addr) > { > diff --git a/arch/powerpc/platforms/44x/warp.c b/arch/powerpc/platforms/44x/warp.c > index a886c2c22097..7e4f8ca19ce8 100644 > --- a/arch/powerpc/platforms/44x/warp.c > +++ b/arch/powerpc/platforms/44x/warp.c > @@ -47,7 +47,7 @@ static int __init warp_probe(void) > if (!of_machine_is_compatible("pika,warp")) > return 0; > > - /* For __dma_alloc_coherent */ > + /* For __dma_nommu_alloc_coherent */ > ISA_DMA_THRESHOLD = ~0L; > > return 1; > -- > 2.19.1 > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text---