Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10747776imu; Thu, 6 Dec 2018 06:13:24 -0800 (PST) X-Google-Smtp-Source: AFSGD/VVjFcHgQVXARrm0xyf7d6IceQzOL646ULNwrbPIyFWR/uI6cuwjZK6sUxeFK/X2HMwcJxp X-Received: by 2002:a17:902:7e44:: with SMTP id a4mr28524415pln.338.1544105604744; Thu, 06 Dec 2018 06:13:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544105604; cv=none; d=google.com; s=arc-20160816; b=MmpLrQtluUHDrdY+1YR5ekyxFFQhHJ5kPXqofdfMLBVHGI7VgIS6e4dAQh8IsKhZei fq4Vl2oriM7oFnaYqmm2NjVSrgz78Hsbq9JdHiFfxW81zOcbre00V63phef5K533lHnn 9wF/MQeT2Ye7HpfMn8uInHxm0YFWgR/cmBL32q3M0KPk+RMUrfkF+Y8nSxxv9ypxI7yR v2Ww7dbjk4o6oj+HitThKK83EPQUVkzSBnkOFoeZqs+R0HfAdnNrxpopBKWw3YYnJsBJ u0Lp0qpBIubAxltJ3h+G7/gmNswZ7BYNfLXQu2HxiqGXLN+kWtV9ma2/Z37fa+feRdTC gPzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=viiDVyzJaB3rTVvtO4TYkza+OHah/1wsa4lbl2vkAOQ=; b=rPEezw8MLZcpsbaF7PXHqMA1RO3fJrTnZ4w4Se9EeA0O/YYaJKx6wjbKdUHbAvUJhm PJCnUbu8bA/euU3j+tLnhOeCnzaimrU9U5SEZ9Zq7pu/KKD05p601sYjOIB30PlXcuqb cWFlEfGPxUQR5FKj/DK0U2y4KBKwyqpbIR96Az65sxB1SK+eZCbDnk2WU6bqhiraXL/C k/w891Bu+wreTPgPRanUAMkdbL/iChhaGte4Q896OOVIWnIpfSdMicX1AARB9z9ax10G Jt2Jtc/QLvXXD5gXZfhcJOBHRoC/uj7V7Q2/LtG+kJBlN7BoipkaK0FCoGrdDbc2My4w 3SZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Mce0Y3Ry; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1si361687pld.324.2018.12.06.06.13.09; Thu, 06 Dec 2018 06:13:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Mce0Y3Ry; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729826AbeLFOLK (ORCPT + 99 others); Thu, 6 Dec 2018 09:11:10 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42420 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728209AbeLFOLK (ORCPT ); Thu, 6 Dec 2018 09:11:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=viiDVyzJaB3rTVvtO4TYkza+OHah/1wsa4lbl2vkAOQ=; b=Mce0Y3RynLAIwbdsnD5nCW1c5 RBNWyOxdVM8V2/hG1XWAQ+zvEp0vKaj3EVpxxG3P7FhEdkIaVjmRxtN5pARszU0nx3y5zm40DSyts d0gSe4OWGLtpTcAp/78lyLw0US4RkXGC1GNENUZz/Y/HT795Q/OfiHlf837TnsLcv84hG+h2k0Ljo 99FGbo63qPlICiCCfX2SicOpqceiDW83QDrsU5kA+14BhW5YljJYClaD6BeUVBiZ6TbWCoNkYhXHd w8YPoIgxvHpY9GJ7h+vQ0IVUa8Zlu/7Om6O3rEdeoM/4XYXwXdyxLE7NERgO5yj8uex1jrI3EQqlz AOCJHUeLQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUuMY-0001DL-32; Thu, 06 Dec 2018 14:10:46 +0000 Date: Thu, 6 Dec 2018 06:10:45 -0800 From: Christoph Hellwig To: Christoph Hellwig Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/34] cxl: drop the dma_set_mask callback from vphb Message-ID: <20181206141045.GI29741@infradead.org> References: <20181114082314.8965-1-hch@lst.de> <20181114082314.8965-20-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181114082314.8965-20-hch@lst.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping? On Wed, Nov 14, 2018 at 09:22:59AM +0100, Christoph Hellwig wrote: > The CXL code never even looks at the dma mask, so there is no good > reason for this sanity check. Remove it because it gets in the way > of the dma ops refactoring. > > Signed-off-by: Christoph Hellwig > --- > drivers/misc/cxl/vphb.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c > index 7908633d9204..49da2f744bbf 100644 > --- a/drivers/misc/cxl/vphb.c > +++ b/drivers/misc/cxl/vphb.c > @@ -11,17 +11,6 @@ > #include > #include "cxl.h" > > -static int cxl_dma_set_mask(struct pci_dev *pdev, u64 dma_mask) > -{ > - if (dma_mask < DMA_BIT_MASK(64)) { > - pr_info("%s only 64bit DMA supported on CXL", __func__); > - return -EIO; > - } > - > - *(pdev->dev.dma_mask) = dma_mask; > - return 0; > -} > - > static int cxl_pci_probe_mode(struct pci_bus *bus) > { > return PCI_PROBE_NORMAL; > @@ -220,7 +209,6 @@ static struct pci_controller_ops cxl_pci_controller_ops = > .reset_secondary_bus = cxl_pci_reset_secondary_bus, > .setup_msi_irqs = cxl_setup_msi_irqs, > .teardown_msi_irqs = cxl_teardown_msi_irqs, > - .dma_set_mask = cxl_dma_set_mask, > }; > > int cxl_pci_vphb_add(struct cxl_afu *afu) > -- > 2.19.1 > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text---