Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10787802imu; Thu, 6 Dec 2018 06:50:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/VNDxj5UgNPTjdibU24tx7cFS8nNV4WFi2Fvr43klIrxdM9xWSpXvaWmL/VdHnS27lg4Lcg X-Received: by 2002:a17:902:f20b:: with SMTP id gn11mr27256602plb.274.1544107819979; Thu, 06 Dec 2018 06:50:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544107819; cv=none; d=google.com; s=arc-20160816; b=L7X0+5pshPhXVIvGihh4DGnu0wt1l+5bfUcI862gDfCkg/7kZzKpyFiIJm+qiqWzKN o95IWLQOTZUvx1VqtFl3DMR9wgchkch8kOD4zYj1dJzn3R7YiM8ArN/Tl59/KfpqVpZp eSGvkSwXYpmQYioVZR3C3HVBpbgA0zOreo2zefwpX/KwnfAM1kA6k2D/ACdyOdhd41he xg8m6IZ1ddedW4/UfQ078aR2mr9EHwlEbYEgUtFDCeImKTqVRX1W8XugRf1QdRGH6Nqx 9BaJfH7TgfvapgNAoCWJQvgcTyXDiSrwQFjxIqLACA3T2LOJvMsUvaJsOYHT5jYm1C9s oBWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l4c2FCxRj/OHI2Y5XaafyZ6hg3MEYcWV9aB5G26GCMc=; b=zPbeHAWshhksX58fAPlyqGK6gf+r5ufBHf420yruJAdx1OFZDqSscA1aHRkiN8y2pA NGho74fDRBo+dz1L55xZ03vpzPH9+redXgCat1OAoGH8IjERQuRc8yzY7siNn/YR0WwM RskcvJ93eIv3ag9rax7z5MDLUHleeQgS/ftJHXZJL3D5iNYd11Nj662lastobM3eclLm IRSDHl4qZHRQOow1vfL502G62GY6jofUDumrhHvxQ/xztKo2psXcsegyQy3/tOJRmxNJ 9Yco69UxmILSnwD3vEEAe2t5LC6+iLOuOxi373dmZmgUvlmxaZiUgBy2wTTZZvL4BvEo qlfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nyduSHP+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si398625plr.96.2018.12.06.06.50.04; Thu, 06 Dec 2018 06:50:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nyduSHP+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731384AbeLFOrM (ORCPT + 99 others); Thu, 6 Dec 2018 09:47:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:51998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730925AbeLFOrK (ORCPT ); Thu, 6 Dec 2018 09:47:10 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2B0A2082B; Thu, 6 Dec 2018 14:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544107629; bh=s2xG0Tadx/hz4glOB9bzWyqJz0xTWGrpT/nLk6EuF5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nyduSHP+bKWOBTfasOdMCixAAy/GvFhx+DxibjlC3/F+NgvXMa/z+pZfVhlHS3T3R kNDjLynmEno/t6fjfjS8kb9l5NOEvIAR28rjgYhyd136k4TNsXMectvqakKQuZK/rf w8A81204PISm33z2LChhdtPs4q6ZSW9WSqvhe2J8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Philipp Zabel , Dinh Nguyen Subject: [PATCH 4.9 043/101] reset: remove remaining WARN_ON() in Date: Thu, 6 Dec 2018 15:38:42 +0100 Message-Id: <20181206143013.996684444@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181206143011.174892052@linuxfoundation.org> References: <20181206143011.174892052@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Masahiro Yamada commit bb6c7768385b200063a14d6615cc1246c3d00760 upstream. Commit bb475230b8e5 ("reset: make optional functions really optional") gave a new meaning to _get_optional variants. The differentiation by WARN_ON() is not needed any more. We already have inconsistency about this; (devm_)reset_control_get_exclusive() has WARN_ON() check, but of_reset_control_get_exclusive() does not. Signed-off-by: Masahiro Yamada Signed-off-by: Philipp Zabel Cc: Dinh Nguyen Signed-off-by: Greg Kroah-Hartman --- include/linux/reset.h | 6 ------ 1 file changed, 6 deletions(-) --- a/include/linux/reset.h +++ b/include/linux/reset.h @@ -107,9 +107,6 @@ static inline int device_reset_optional( static inline struct reset_control * __must_check reset_control_get_exclusive(struct device *dev, const char *id) { -#ifndef CONFIG_RESET_CONTROLLER - WARN_ON(1); -#endif return __reset_control_get(dev, id, 0, false, false); } @@ -255,9 +252,6 @@ static inline struct reset_control * __must_check devm_reset_control_get_exclusive(struct device *dev, const char *id) { -#ifndef CONFIG_RESET_CONTROLLER - WARN_ON(1); -#endif return __devm_reset_control_get(dev, id, 0, false, false); }