Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10788833imu; Thu, 6 Dec 2018 06:51:23 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uw+9goN0RAOGpxU2OacB+DXvftUitbGB4FkNxa3nocwvNSf5XOjQF7tJo+Xp1ISNjMz0Pn X-Received: by 2002:a62:e0d8:: with SMTP id d85mr28313437pfm.214.1544107883376; Thu, 06 Dec 2018 06:51:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544107883; cv=none; d=google.com; s=arc-20160816; b=xb16ebQ0pSqvjzESrbSs0HXWnqxjQHVn1k8bzwPkxNAbg0ZOFziN63jhEv3JSGpbdp YYW6zjKqQIDAGDxWF8Zln4WOyzZlufDy4Cjz9cDyDLwuFZ9fD+eYDjg8ITcWcg5VF2wE 1vsgobOt0aTt14JfX7VFv7T1EhTTnRBC6QYfJPlE4+o/DCExZqCqNs2inAVF5aaeZ5hQ ABrlyJONS6esWXefGhVNMQMEHC3LwTwP63aBS2UO1vUxVLFcd5NLWAQyEBOl4qcLeheB I5o5VT9e2UzGDirQle2lGiCASvsfUP0cP3z0/EoGi8qiBUs4qQU3HDuZaWTQO9IQfiC1 iHcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J6IENYDkGnpdGIiCK/WaNP4Y1Lguwh35mWK1XJ7XhH8=; b=XHg60dhZtKGGx/ZeUvDT5JcWGetilWGBVO1ZeQErQajD7IpW0A+ID8qKTwOFpM1+4r JnU9NvIXvOdr4xEMCpLRDn6rwcPNs+jU+DDxArYZVq3CkNMXT5do1W0QUuWUXvK9AjZe C6LQLwCu0FSBMIgDU16hE7Xqg3U75V2njnhFpmw0V65d6vhVBLQf3wwW5Ql993+gfkac W02tPr+ZtKN2kU7v4lIYiJEuHfcQd5bp4ra5NLz04EXUP4EusVJX0Cb9L4KjxZ2sAFcQ yvckQykgzprXf1c4A9UkSxq8vdl7J1nR2MFFOKlQqs4LmWwpEWbKmz7Yb3nP9mr+BFqr OX8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Hr+1ubME; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i189si417745pfg.265.2018.12.06.06.51.07; Thu, 06 Dec 2018 06:51:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Hr+1ubME; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730474AbeLFOrg (ORCPT + 99 others); Thu, 6 Dec 2018 09:47:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:52588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731434AbeLFOrd (ORCPT ); Thu, 6 Dec 2018 09:47:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACBE420892; Thu, 6 Dec 2018 14:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544107652; bh=A1InfrY3F3+CD3cv81T3UaMIOYFm0qMjS9tGYpinHBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hr+1ubME5/ZmxEScGQxw825d3+6UPW5RoBf5QRUUYOuC+1QKaz8zh3d37OvEYlD6j XOdKaxzoMbcgLLYz8cyQIBWOdgJ1PI3JBU0vVheZv3exq5SIXTmEJ5kTSEMA8RJUp0 KyynisgO3+nDSoglZogqjfQZggFnqY99ccl6ELxg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+83699adeb2d13579c31e@syzkaller.appspotmail.com, Chao Yu , Jaegeuk Kim , Ben Hutchings Subject: [PATCH 4.9 088/101] f2fs: sanity check on sit entry Date: Thu, 6 Dec 2018 15:39:27 +0100 Message-Id: <20181206143017.799132958@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181206143011.174892052@linuxfoundation.org> References: <20181206143011.174892052@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jaegeuk Kim commit b2ca374f33bd33fd822eb871876e4888cf79dc97 upstream. syzbot hit the following crash on upstream commit 87ef12027b9b1dd0e0b12cf311fbcb19f9d92539 (Wed Apr 18 19:48:17 2018 +0000) Merge tag 'ceph-for-4.17-rc2' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=83699adeb2d13579c31e C reproducer: https://syzkaller.appspot.com/x/repro.c?id=5805208181407744 syzkaller reproducer: https://syzkaller.appspot.com/x/repro.syz?id=6005073343676416 Raw console output: https://syzkaller.appspot.com/x/log.txt?id=6555047731134464 Kernel config: https://syzkaller.appspot.com/x/.config?id=1808800213120130118 compiler: gcc (GCC) 8.0.1 20180413 (experimental) IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+83699adeb2d13579c31e@syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. F2FS-fs (loop0): Magic Mismatch, valid(0xf2f52010) - read(0x0) F2FS-fs (loop0): Can't find valid F2FS filesystem in 1th superblock F2FS-fs (loop0): invalid crc value BUG: unable to handle kernel paging request at ffffed006b2a50c0 PGD 21ffee067 P4D 21ffee067 PUD 21fbeb067 PMD 0 Oops: 0000 [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 4514 Comm: syzkaller989480 Not tainted 4.17.0-rc1+ #8 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:build_sit_entries fs/f2fs/segment.c:3653 [inline] RIP: 0010:build_segment_manager+0x7ef7/0xbf70 fs/f2fs/segment.c:3852 RSP: 0018:ffff8801b102e5b0 EFLAGS: 00010a06 RAX: 1ffff1006b2a50c0 RBX: 0000000000000004 RCX: 0000000000000001 RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff8801ac74243e RBP: ffff8801b102f410 R08: ffff8801acbd46c0 R09: fffffbfff14d9af8 R10: fffffbfff14d9af8 R11: ffff8801acbd46c0 R12: ffff8801ac742a80 R13: ffff8801d9519100 R14: dffffc0000000000 R15: ffff880359528600 FS: 0000000001e04880(0000) GS:ffff8801dae00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffed006b2a50c0 CR3: 00000001ac6ac000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: f2fs_fill_super+0x4095/0x7bf0 fs/f2fs/super.c:2803 mount_bdev+0x30c/0x3e0 fs/super.c:1165 f2fs_mount+0x34/0x40 fs/f2fs/super.c:3020 mount_fs+0xae/0x328 fs/super.c:1268 vfs_kern_mount.part.34+0xd4/0x4d0 fs/namespace.c:1037 vfs_kern_mount fs/namespace.c:1027 [inline] do_new_mount fs/namespace.c:2517 [inline] do_mount+0x564/0x3070 fs/namespace.c:2847 ksys_mount+0x12d/0x140 fs/namespace.c:3063 __do_sys_mount fs/namespace.c:3077 [inline] __se_sys_mount fs/namespace.c:3074 [inline] __x64_sys_mount+0xbe/0x150 fs/namespace.c:3074 do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x443d6a RSP: 002b:00007ffd312813c8 EFLAGS: 00000297 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 0000000020000c00 RCX: 0000000000443d6a RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007ffd312813d0 RBP: 0000000000000003 R08: 0000000020016a00 R09: 000000000000000a R10: 0000000000000000 R11: 0000000000000297 R12: 0000000000000004 R13: 0000000000402c60 R14: 0000000000000000 R15: 0000000000000000 RIP: build_sit_entries fs/f2fs/segment.c:3653 [inline] RSP: ffff8801b102e5b0 RIP: build_segment_manager+0x7ef7/0xbf70 fs/f2fs/segment.c:3852 RSP: ffff8801b102e5b0 CR2: ffffed006b2a50c0 ---[ end trace a2034989e196ff17 ]--- Reported-and-tested-by: syzbot+83699adeb2d13579c31e@syzkaller.appspotmail.com Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/segment.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -2376,6 +2376,15 @@ static int build_sit_entries(struct f2fs unsigned int old_valid_blocks; start = le32_to_cpu(segno_in_journal(journal, i)); + if (start >= MAIN_SEGS(sbi)) { + f2fs_msg(sbi->sb, KERN_ERR, + "Wrong journal entry on segno %u", + start); + set_sbi_flag(sbi, SBI_NEED_FSCK); + err = -EINVAL; + break; + } + se = &sit_i->sentries[start]; sit = sit_in_journal(journal, i);