Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10793298imu; Thu, 6 Dec 2018 06:55:41 -0800 (PST) X-Google-Smtp-Source: AFSGD/UxfQQcjSgGzZ+3/calt05GQ3J7RLSTQtZYDlsOxJuOHBVTVch+jywCgg5xbSULOINawsMS X-Received: by 2002:a63:8149:: with SMTP id t70mr24938788pgd.172.1544108141858; Thu, 06 Dec 2018 06:55:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544108141; cv=none; d=google.com; s=arc-20160816; b=te4RDu8SuGZAD07+oQRPWjx9IxKx4+K8yF3ggd1PXZGk1TUYscRmSq9Jxyky1Y8Fhb R1htKMpzLswV0gJERPwoE3TThstA0RbURnXa8yZTYUbn3Nt0Vjpqscr6TN2+0MMqcdKN nF61Tq45vOo5YnVu1ulSRr5KpA9N9uuYArgdg4ynS6iTe0ib6QF0xjBjose+in6LpVmw MzaV91eZ24KLSpIOIy517AEOTQk4L/+S6vy5v3LLfcuGAk2EtBYL3++CVhtClSyu10Ms 4arHqVRmDsx4wXwejkyOtUVN9laUjx01r9sDOR/f/DfhdRykCuG3iWHqw0ZQrkNwowFo HMSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JNR1tyn1LqYAImmb2BHqBukemTzAOP9uiulyAtt5NGc=; b=c+RgWnAYtqCjUglPuB8HjIBEyheuCan88d0zESgRN9UfOq4IzP8Xf1op/j8Q9hT3i0 bDtj+AdRIn0w5enwFqHgI71ViYQuwz5i8jG0NXOrL29K2ww0aKDv2XyBi636DpiuiQZ1 1nE3vZ8rPhb/G4lEZVjB+d20EPTMje99d5AutSE0AM2eHRDjiZ2DG1nY2UPSDaXf87Wl O8z4HCnhGzgPBZaDD0sCpw4+hhYI6bKwHL9NKaHNnexHlwTH/zEpUYkSl9JdRY1PVlD/ +ZVotFBE9KZHcE7iYCNYMENCfv06rpnWiHiUNqOov7RrY69ZrYO6Q8cHZ8J8t8G14muC WK/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=SYzUyOYo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si349840pgq.207.2018.12.06.06.55.26; Thu, 06 Dec 2018 06:55:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=SYzUyOYo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbeLFOwy (ORCPT + 99 others); Thu, 6 Dec 2018 09:52:54 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:56016 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbeLFOww (ORCPT ); Thu, 6 Dec 2018 09:52:52 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB6EioI9013135; Thu, 6 Dec 2018 14:52:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=JNR1tyn1LqYAImmb2BHqBukemTzAOP9uiulyAtt5NGc=; b=SYzUyOYo5NXpmcY+vnyo+2DXIq31x+ZcrvGIUp+tr9pZVXOZmuaC4LzZ4d3FjmYTBOxM nFIsxpG445if9uHUr027zd0lipxDsbcWWIviwbfdYxNT3NoSuJMcmZW3JcQF/f2rw6Pp KoTtbiIqZXkZDZifbUB5LQ12DeKQWEKZ8Plh+N/HfoRNrM0s5dOSdEZ6HXZZo4nKoBWP 28QmxDPL7/eafDCr3f5NpyL2wDY5wTr74i7i7smALeS0IYJGf8G5h+Z3FlroIO2o5ZcA OGamE+Bq3xwPXP+hka2bUf4EY79uDHMnS9+9+59rJ0fPtODzPte7wSVFebLcVWHx9H6g XA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2p3ftfck8w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Dec 2018 14:52:38 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB6EqWOE022841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Dec 2018 14:52:32 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB6EqVt0027404; Thu, 6 Dec 2018 14:52:31 GMT Received: from unbuntlaptop (/10.175.27.171) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 Dec 2018 06:52:30 -0800 Date: Thu, 6 Dec 2018 17:52:18 +0300 From: Dan Carpenter To: Marek Szyprowski Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Greg Kroah-Hartman , Minas Harutyunyan , Felipe Balbi , Geert Uytterhoeven , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect" Message-ID: <20181206145218.GQ3073@unbuntlaptop> References: <20181121154504.13052-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121154504.13052-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9098 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=519 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812060127 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, I'm surprised you don't get deadlocks when you apply this patch. On Wed, Nov 21, 2018 at 04:45:04PM +0100, Marek Szyprowski wrote: > @@ -4020,9 +4008,7 @@ static int dwc2_hsotg_ep_disable(struct usb_ep *ep) > > epctrl_reg = dir_in ? DIEPCTL(index) : DOEPCTL(index); > > - locked = spin_is_locked(&hsotg->lock); > - if (!locked) > - spin_lock_irqsave(&hsotg->lock, flags); > + spin_lock_irqsave(&hsotg->lock, flags); > One of the callers is already holding the hsotg->log. The spin_is_locked() test would avoid the deadlock. regards, dan carpenter