Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10797774imu; Thu, 6 Dec 2018 07:00:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wn+mYpZdd/C4eO+IZ73m1HmsMSyOah0BCr9pk5b0EuZ9ah1mCq2Qs6oVlIRIkdQS12aVzD X-Received: by 2002:a62:824c:: with SMTP id w73mr28654188pfd.150.1544108413940; Thu, 06 Dec 2018 07:00:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544108413; cv=none; d=google.com; s=arc-20160816; b=Ku8jkIbkO38hLjIeDQPHGS3PkxIC3Plk6ywhkTbNB6Xrt+QYoFCYAFQ7z1qnqDuPz3 9iRQ9ka80Umg8nTVN38WnfGcmkcZ2k3JxolLU63B8wSzMIj45yQsSprkBeGiGncQs0+H B06ttdj1uwj2X/LUNGrmb8QsTZZqs7m3Ghl93/WPA/ZycccitzPGD2sUL43vNvGhe2az 0to1Xp3h4Gqbxqfo/DjTnxZgdYVR3tsoYrBW8L6k1g4dRdXIPlqCd4rJYYHt2uysjqGS 8nKYlIZqb3i29A++6rcFX4CROweecrixDcgcZleFwdgHLzUSf4bupjo2aJmkcCLx+XVD NT/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6numlv32oFc61TvwBF/tFURTaowj7NWGsOUf6c2rp/o=; b=MyJNTqS49WSCQejIz4++cXwU+HScvTVZlD1ApcpZVYpOOxxPCDxeX4m+3UudGGsX+k fLRLG8KV5EbW39yrPvdBZ0Fst2ozU+tf0ZW+hMcUpylLUgZLPS60bHV0lq9v5jnayQmB nkpqmhToFGhgYv37YAB5rhBT6Lnq1wujB6Bhb1weMm9xZ2i4ILcHmeqwecTVtuUoD3Ww lu9rIg8MAU85OrTp5rZzQ5F9R4Vj1zsewP6sfDlvYCw79XdwGYUIckSDC1wWrFIeyuBF 2xr88168g/Eo+u0szc4BhIPkGPOcDlC6pVxkeWinpUM15OvUWMZ4P/8VM4a0ywTD3AVt FT1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BTwhcUaI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce19si457725plb.13.2018.12.06.06.59.56; Thu, 06 Dec 2018 07:00:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BTwhcUaI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbeLFO7R (ORCPT + 99 others); Thu, 6 Dec 2018 09:59:17 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:45974 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730251AbeLFOle (ORCPT ); Thu, 6 Dec 2018 09:41:34 -0500 Received: by mail-lj1-f194.google.com with SMTP id s5-v6so589127ljd.12 for ; Thu, 06 Dec 2018 06:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6numlv32oFc61TvwBF/tFURTaowj7NWGsOUf6c2rp/o=; b=BTwhcUaIbnbSUdg6lMSvacD1LegaR64dNfl621JVVF/4DabiXGT5dem2gQRyZd/MvF ToWAkrR/z9r9qlW7dDHWNREjxM0I35TY1g4pj+ZpgQFTvByiQusgRwlJWiIiL5xWN7B8 MbS/B+anwYRh9Na9hwRYFQqzF7B57ZNIYje1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6numlv32oFc61TvwBF/tFURTaowj7NWGsOUf6c2rp/o=; b=RjBxFqCokAeHYVXdijl+4KailtETxERG3zwy8EmA2M/AGUxDW+3vyRo7cASjn9pBux Z2KC2/dpYFY5hhDFUEpZyK0ZY4b3OVHvMWpS2QS9rDUrJFoaul8fFt8aC7MieaApmdkm 2BVpYV3nI/sKwEYkQE1kRQAtTlM04YZVsKI+CrsiaK5/URjwBjs+duu+mIPeoPuzpovY DMWIpCo6+ndF90kdNvAtyCstN8kMY5YTyqxkqCAdk3dfmE7SivxOPGoQVqZw/bRF+uHH 4emLW5mB/keTSSp+fF7lpXq2WdE60vXvXQmuLXXtl72joc+R3ZNQZCLgcF4B+3Oo+7w7 A58w== X-Gm-Message-State: AA+aEWZlPhWHYkVdFNBJBIStHtI2NNYYlaOtJXxj0MDGs1q4+vxViMc6 B0wUbd9DyBbSwFjzS5Az/ETM6Crv+H24uS6DCcKqZA== X-Received: by 2002:a2e:29d7:: with SMTP id p84-v6mr18395459ljp.12.1544107292663; Thu, 06 Dec 2018 06:41:32 -0800 (PST) MIME-Version: 1.0 References: <20181206124351.10155-1-linus.walleij@linaro.org> <20181206134901.GJ16508@imbe.wolfsonmicro.main> In-Reply-To: <20181206134901.GJ16508@imbe.wolfsonmicro.main> From: Linus Walleij Date: Thu, 6 Dec 2018 15:41:20 +0100 Message-ID: Subject: Re: [PATCH 00/15 v4] Regulator ena_gpiod fixups To: Charles Keepax Cc: Marek Szyprowski , Liam Girdwood , Mark Brown , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 6, 2018 at 2:49 PM Charles Keepax wrote: > On Thu, Dec 06, 2018 at 02:27:03PM +0100, Marek Szyprowski wrote: > > On 2018-12-06 13:43, Linus Walleij wrote: > > One more thing - if I got everything right, gpiod_put() in > > *regulator_register() error path has to be removed also in > > wm8994-regulator.c and arizona-ldo1.c. > > Indeed yes, good spot. > > But apart from those additional two patches, series > also looks good to me: > > Reviewed-by: Charles Keepax Thanks a lot, I hope Mark can merge this for starters and then I can go in and fix the two outliers separately. Yours, Linus Walleij