Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10896975imu; Thu, 6 Dec 2018 08:25:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/WD+1/k8jBTZzVEtZssxoEWeL9vj4O5U2ICvheHd605gn4HJVGscG8Mqkir0qgK2c5e0XUD X-Received: by 2002:a17:902:2862:: with SMTP id e89mr29273930plb.158.1544113508190; Thu, 06 Dec 2018 08:25:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544113508; cv=none; d=google.com; s=arc-20160816; b=M+pohwvlPcQksqcvQjl3AHe5Fxl0OE3xGOPt4I2fRMIjWKHsblXxDYiPl00JeFnZzO t8vyawx0LTExDgrJnDLoMtMvgJAtVj9A5NUAoW3jDIMgGByECspNaOwcWlmsltpH9per j8+0dfN2rIyhLq5bVfUvaQeVTH3Nz8HYPlfwVIuyJjK1Aqzsxrd5iA3HIxGdTj9AyRBy W/QTf3DCKtOxFQw7ScU3u98b8bMr5CzdmBSkPVnfV0OoEc6VJYXvdqWvzRCnCQ8XI6GU jIh/329oJ7g9OAdxBr92s0bVXfl8pvh+fxxyzf7XLNkA2QufDTGp2I8V2EAmhcwho8SQ afSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=U+INbIpie+6Lzcdrf4FrduYZa16DKldz3JAaughrKhg=; b=B6cfSY0LLNbQafxBsyQUMZS31svlp1sA06AoroLtaAeQ6OrHPLVY2t4luNUq4rDgD4 8mD8MaBe9BlH5p11veb4Lbje4CP2IuXV/c5HaLZjK/p/65d+TKlHKbS86jVa2mJKBtAA EsfWhePR0YAEG+7j9ExoBpwrCeGYTqQf4hcF2x/ODcckrqVqy9ihS+NdA6bOcgsJT144 SGCWikP+SqDlv1cTkEn2atynf3vVPTwd96dplaeOgLUftCsAaWPJIiPIBTjoIJzu+B3u Fr2oo1KfpPzpOID6K0IrlhtXthAbO6hbTr/h4Cg4wmTrHfsjwFshdS/jWZmejIDqyP6l vo/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D3Mz1Fpi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si595781ple.185.2018.12.06.08.24.34; Thu, 06 Dec 2018 08:25:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D3Mz1Fpi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbeLFQXm (ORCPT + 99 others); Thu, 6 Dec 2018 11:23:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:37284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbeLFQXm (ORCPT ); Thu, 6 Dec 2018 11:23:42 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB0C920659; Thu, 6 Dec 2018 16:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544113422; bh=P2fIXxw8SA4TP0x0ycc2DiUzDEMtrWNJsRfrocsylcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D3Mz1FpiGsCWCoaJjr19rPGGTxuhlIImizYfNBhiwW7RBPEShyGQ03n1gewzHCvWW U92V7TO+/NNPl8NepbjoLwxiONKhqtWAzZ11WbM35XeCJwufGjRYi8umoG1l8MHRmH AjAtFmj7wM1DHS+0lcIZxz5zUaEIQ7b6aY9al60M= Date: Thu, 6 Dec 2018 17:23:40 +0100 From: Greg Kroah-Hartman To: Bryan O'Donoghue Cc: Sicilia Cristian , devel@driverdev.osuosl.org, Alex Elder , Johan Hovold , linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH 2/2] staging: greybus: Added space between string concatenated Message-ID: <20181206162340.GA12032@kroah.com> References: <5b215b50d4da9a7730450a83fb5e3a167b65e03a.1543956271.git.sicilia.cristian@gmail.com> <42632636-9b08-bd75-b789-88ef82f52c2c@nexus-software.ie> <20181205210034.GA24054@peano> <20181206150516.GA1774@kroah.com> <131a4c41-2c5f-a660-5190-52ce5d59e532@nexus-software.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <131a4c41-2c5f-a660-5190-52ce5d59e532@nexus-software.ie> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2018 at 04:14:53PM +0000, Bryan O'Donoghue wrote: > On 06/12/2018 15:05, Greg Kroah-Hartman wrote: > > On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote: > > > On 05/12/2018 21:00, Sicilia Cristian wrote: > > > > It doesn't change the result string > > > > > > So why do it then ? > > > > Because it is easier to read this way and odds are checkpatch is > > happier. > > Fine. > > Sicilia could you please amend your commit. > > 'This patch fixes the checkpatch error "CHECK: Concatenated strings should > use spaces between elements"' > > and then feel free to add my > > Acked-by: Bryan O'Donoghue It's already in my tree, no need to ammend it, sorry :) greg k-h