Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10898071imu; Thu, 6 Dec 2018 08:26:07 -0800 (PST) X-Google-Smtp-Source: AFSGD/U3tsJ0BJz/mOb5TuqaI6Ru4R4FWyHK8IdyAm3LTCn1BZkfFTD3Vtp2XulXKfVfF30oIxMh X-Received: by 2002:a17:902:6b0c:: with SMTP id o12mr29254293plk.291.1544113567443; Thu, 06 Dec 2018 08:26:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544113567; cv=none; d=google.com; s=arc-20160816; b=D6LerczIeFSlP67tMU1A2LE4pflzKeGkyO+ZbsYdhrZ2sVXcZ2kcAjEvLVxjByfDbA wrNOUTxb5P2oIwdV3ylLcw7lmyn9z0RsKZTFf9QS7of0EEcbOQeNINe528pQfZvrMoQZ 6gJNABQZjEo1i1cXwtRktbdbH+ZTv5IpiHSKvvdtjKvfcLqIUf6/oGmOZNB+sQ9mFeQM ojIXGro35XJlL+T7gc4IzP8oR43D+81Zr27WTCMmnlYoBlC1hH6x9IgFwrrf5aeEYOdA 0xdxh96Akp9ssdDKyi/rFDhN1cdY9wd5M1kPbWJDBZYoJZYDno1KaBzq/vETChZP2EQw 0sCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=TvzzSnEtxTz0N6W2I45ZFgRuzIMKqGGWKQ8IDFuvJk4=; b=gZXMCxiyjFxtXNUqf/NCBWRbdYNTAU1bCs9g1Uo79ZMjREtDmiN/3MfRpu18oxu3wR wnOE9B5XjeKQzbZjmnrr+RHnklnW6SyX9JpHXh7506c6Fy3diqCzwxj4biYhr/rWvOek z+dDQBsa9fToQep7g4tKHpLI0Ul+oeqYOx6VR8mbRRc85KGSxOBJ2OEpwOW5w7mccCka j/H6epRTPDSVQj89l1jZWNVpjk4bc88kkwLNzXkCJhkHMcrIUI9Zp4wfpETUvLUYP+cd xAVolOY22ysGAcfrtx94ixa+pkFTsGNkMgYRBIcOZhrggqsUCivaLPvCt4ETfof18PoH ut/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b="iwN8Lm/g"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si585528plt.4.2018.12.06.08.25.42; Thu, 06 Dec 2018 08:26:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b="iwN8Lm/g"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726044AbeLFQYZ (ORCPT + 99 others); Thu, 6 Dec 2018 11:24:25 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:36680 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbeLFQYY (ORCPT ); Thu, 6 Dec 2018 11:24:24 -0500 Received: by mail-ed1-f65.google.com with SMTP id f23so1271237edb.3 for ; Thu, 06 Dec 2018 08:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TvzzSnEtxTz0N6W2I45ZFgRuzIMKqGGWKQ8IDFuvJk4=; b=iwN8Lm/grLxeF4hBWuiXrxRUHTsoizvlUBmu5btveHxETYtu+HbbWFB7NpAgpG4dYC V2bx4bWg1gKqo14ETuqCwpJWy0USwHznIYjxnP3vIX4GbaF4+gT5SDIelbitpzZZGDl3 hJUF/6JZexWXatOW6eeLP/Ntidf0SiXA2zuzpeHl1613h1BPZPn+0u85SyyykwfLwJsG lita/GkcjSFkAC3QN7Zegf1kRB1CLc3ThVTOBNyeWLKT/kH6/Gyv11eAqzdjD9fsQcbz LiZJzlh1OoPQE87jOvs7njzkHl75Vs+yTpoe9jrlp8LARI8tFBzi9SVbk+84RN7pVVyL uOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TvzzSnEtxTz0N6W2I45ZFgRuzIMKqGGWKQ8IDFuvJk4=; b=FIwb7BPRvC+VLax4GnwtcMzeCKx87C+k+/Qt3DfGzcMtRFgAo/KudD8nUZq4FJtzu+ OrIUWeiAj2ttxAAy2DM6WRO0xVzqXI8hFBV2sBEJiLtuqdnnAOrqActPYL2zuuS4z3Rb BCIO8CQtutw61nBz7lswRfVb7QhidqCH7nibLeosbn/gZL5dxqmQv7AmTY/JAqBKtl6A Th/C0DoUGL6vxCNRtlmUCl2byiWi4YCtXj1HT59CTjAxtR3XlqT4LeviAk54hjs0Bo9/ 4U3uhAuLWBpSZcskYJuWjkaojb76s0BACntFXjgabT/VcSEHcoH033edfK3Ybo61fgAn fD8g== X-Gm-Message-State: AA+aEWajnyv7CbCjGkaDEAIfx0z4uZneJIv+AbDxeRMtV5Pi+Kem8otV spp0HogL+x/+Ia0n4zhE/WjogQ== X-Received: by 2002:a50:a9e5:: with SMTP id n92mr24841275edc.63.1544113463086; Thu, 06 Dec 2018 08:24:23 -0800 (PST) Received: from [192.168.192.38] ([80.111.179.123]) by smtp.gmail.com with ESMTPSA id w10sm281145eda.77.2018.12.06.08.24.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Dec 2018 08:24:22 -0800 (PST) Subject: Re: [PATCH 2/2] staging: greybus: Added space between string concatenated To: Greg Kroah-Hartman Cc: Sicilia Cristian , devel@driverdev.osuosl.org, Alex Elder , Johan Hovold , linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org References: <5b215b50d4da9a7730450a83fb5e3a167b65e03a.1543956271.git.sicilia.cristian@gmail.com> <42632636-9b08-bd75-b789-88ef82f52c2c@nexus-software.ie> <20181205210034.GA24054@peano> <20181206150516.GA1774@kroah.com> <131a4c41-2c5f-a660-5190-52ce5d59e532@nexus-software.ie> <20181206162340.GA12032@kroah.com> From: Bryan O'Donoghue Message-ID: <6c01fbe2-3263-c923-f246-2feaad7f20f3@nexus-software.ie> Date: Thu, 6 Dec 2018 16:24:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181206162340.GA12032@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2018 16:23, Greg Kroah-Hartman wrote: > On Thu, Dec 06, 2018 at 04:14:53PM +0000, Bryan O'Donoghue wrote: >> On 06/12/2018 15:05, Greg Kroah-Hartman wrote: >>> On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote: >>>> On 05/12/2018 21:00, Sicilia Cristian wrote: >>>>> It doesn't change the result string >>>> >>>> So why do it then ? >>> >>> Because it is easier to read this way and odds are checkpatch is >>> happier. >> >> Fine. >> >> Sicilia could you please amend your commit. >> >> 'This patch fixes the checkpatch error "CHECK: Concatenated strings should >> use spaces between elements"' >> >> and then feel free to add my >> >> Acked-by: Bryan O'Donoghue > > It's already in my tree, no need to ammend it, sorry :) > > greg k-h > thanks greg !