Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10935329imu; Thu, 6 Dec 2018 08:59:39 -0800 (PST) X-Google-Smtp-Source: AFSGD/WJxwosud7qJWTip8n1wpb0zOrfrf4PkKuWU2uEZQZ3x5bD427XfZJ4wSSy4J4FAMAyBSV4 X-Received: by 2002:a62:4e49:: with SMTP id c70mr28896801pfb.167.1544115579738; Thu, 06 Dec 2018 08:59:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544115579; cv=none; d=google.com; s=arc-20160816; b=vuhLB0EJXHf9wmzFk34MGNbq8jtJWXvgP/r/rq4nC4LUK5XtIo2d/PlS8PDaEwePdV Gezbgx70Nz3eWy8nxkznzyw7AkXnrxjT7pECr5U8d89v3grBNhNM9GNw4HLvAwQXZ7Rt ReEo7667oARgfkLWxNKO987PRtSaJq4YXOd8v2btyI7LUU2dDSdpo3Gz+wt/zyRjkBIt RI2rCDvbv0aH/TZGfBBcozZ39j6lcWDqBJYEk3jTxpJIvuiseyok6H9y4XXdVTh+W0AH ZPdRXB4WbifWMIQBUeZ7DWSImEkoJyynvGRng9EgY7FN6LHV4jqJU2PvLy6rGys9iZPy RG6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=eNZuyYduD+lBQRwrt1UaJrmmNjW2m4gH3036Be/wx4M=; b=IGtBTfmN2WHMqUowXpMVVe1cVkqRD++f/tzL2NnESFfbDBKat7eOojOMam6CmfFBkK idVtmhRpDyXxh8ZPR6VIeANpf8rfRGFLmGQzxNfbwt1jPqPa7pkSyf09ZCw5V8LLSycD Ou+VBKbsTJ33Un1Shfs9NYiwiMGPphBP1R5Sx/QqwbxuSc2UgpVRWZumw57YLkyBmbF2 IDzo7aS9BlHe6zQlQ0HFdsNqTNSAHVm6cs1Vxq5AqXD2c4zv+vpnLJDP1/eO42wNnleC 7WIfIPCcS9oaB+7ZgEvH5E5mODfOqaF9EzTWZs7xEVk9XyE+L0anc1VJUsQGwo9coI4Z 2P6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8si597100plq.345.2018.12.06.08.59.23; Thu, 06 Dec 2018 08:59:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbeLFQ6i convert rfc822-to-8bit (ORCPT + 99 others); Thu, 6 Dec 2018 11:58:38 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:50951 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726052AbeLFQ6f (ORCPT ); Thu, 6 Dec 2018 11:58:35 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 14804206-1500050 for multiple; Thu, 06 Dec 2018 16:58:31 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: jglisse@redhat.com, linux-kernel@vger.kernel.org From: Chris Wilson In-Reply-To: <20181206154704.5366-1-jglisse@redhat.com> Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , stable@vger.kernel.org, =?utf-8?q?St=C3=A9phane_Marchesin?= , =?utf-8?q?Christian_K=C3=B6nig?= , linux-media@vger.kernel.org References: <20181206154704.5366-1-jglisse@redhat.com> Message-ID: <154411550724.26970.8541642329782166943@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH] dma-buf: fix debugfs versus rcu and fence dumping v2 Date: Thu, 06 Dec 2018 16:58:27 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting jglisse@redhat.com (2018-12-06 15:47:04) > From: Jérôme Glisse > > The debugfs take reference on fence without dropping them. Also the > rcu section are not well balance. Fix all that ... Wouldn't the code be a lot simpler (and a consistent snapshot) if it used reservation_object_get_fences_rcu()? -Chris