Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 6 Dec 2018 18:36:21 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Andy Lutomirski <luto@amacapital.net>
Cc:     Sean Christopherson <sean.j.christopherson@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Rik van Riel <riel@surriel.com>,
        Yu-cheng Yu <yu-cheng.yu@intel.com>
Subject: Re: [PATCH] x86/mm/fault: Streamline the fault error_code decoder
 some more
Message-ID: <20181206173621.GA31884@gmail.com>
References: <20181205163624.1842-1-sean.j.christopherson@intel.com>
 <20181206073409.GA64887@gmail.com>
 <20181206155336.GC31263@linux.intel.com>
 <C1F7477E-70B1-4F26-9457-EA6D825501A6@amacapital.net>
 <20181206164710.GA119529@gmail.com>
 <EF7E7857-B4DF-4C14-85F5-114B03D5295D@amacapital.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <EF7E7857-B4DF-4C14-85F5-114B03D5295D@amacapital.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


* Andy Lutomirski <luto@amacapital.net> wrote:

> That’s why I suggested “read,” in lowercase, for reads.  Other than 
> that, most of the unset bits are uninteresting. An OOPS is so likely to 
> be a kernel fault that it’s barely worth mentioning, and I even added a 
> whole separate diagnostic for user oopses.  Similarly, I don’t think we 
> need to remind the reader that an oops wasn’t an SGX error or that it 
> wasn’t a PK error.  So I think my idea highlights the interesting bits 
> and avoids distraction from the uninteresting bits.

Ok - all good points.

Thanks,

	Ingo