Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp10997466imu; Thu, 6 Dec 2018 09:52:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vlq+O35e7ptW05BlTEuAIM/TTzD/lQbcL8yUldU7rUAwahr08/KiigyIi2+HWbmzYHRKyV X-Received: by 2002:a63:4a0a:: with SMTP id x10mr24742350pga.237.1544118753528; Thu, 06 Dec 2018 09:52:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544118753; cv=none; d=google.com; s=arc-20160816; b=vorplAMCD3G3+DcIHyh0aidBnwc0mQgRy3YaFNFD7vxXyq++EaS2j/yd/9Vzptlqb8 zy+MOo2yL4Ui0WQcEhAHXd0Nd26HIhyirx8H7FcWkPOHUYcSWxQgQ3zKo7JrX4VwVxYW 7HK+mLvk+sCwE1/5+5ZjFAFdQObGVfDesSs/ZVWAT9UaoSeqdR+wwidZ5T5fMnJiSCJD ZgFZxjMq0IRQZtNRMH4Nk0rjm+WQyPzaT2sWF29uzxUeIuLhfHhuYQkNulH53E+0OULU FPqGwkvqWY66JJEz7uVEiPelP8raXREXJ3RytnnrNfio/kyzjgfqHxe712R8ZNSH+Nm8 6BSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=p+Rx8CLlS6c401nqoIEnCpIsNrBL9fyp9Oc6jt1Tq/4=; b=uyu45UgJs/w+yty/VNSjvR762vBcEc2R8CPvQPb/Y8/p9eNxZ7ISIrCFJKkBlzz22j 8BlMO2pJ6gAQY2fsZF/X20tR7q62jmwR5Jy1aGgX9TQiUtsy7DyUETxLhzp6MYORPam3 vEqLDJ4dPMqUOW8q9U1nvNVGm3HRKK8mEo81j7lRxaztps2PSJNDcYQcELGUOdNXnE/d 9lylSyWJDfUBXnFKj2u+TfsXwjJNdXnr3nMH/t6lR+U9rEr6hhblci/hN75h4CrMusuH yt0rdhuCCjkfMe57CZPnpQI6h86ozyQd1EYMLsXYngKq9vdjbPn4yGfPIHF+EnDVbX9H aT8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VIqjwJKw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si744580pfh.229.2018.12.06.09.52.17; Thu, 06 Dec 2018 09:52:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VIqjwJKw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726006AbeLFRvf (ORCPT + 99 others); Thu, 6 Dec 2018 12:51:35 -0500 Received: from mail-io1-f50.google.com ([209.85.166.50]:41827 "EHLO mail-io1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbeLFRve (ORCPT ); Thu, 6 Dec 2018 12:51:34 -0500 Received: by mail-io1-f50.google.com with SMTP id s22so1049542ioc.8 for ; Thu, 06 Dec 2018 09:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=p+Rx8CLlS6c401nqoIEnCpIsNrBL9fyp9Oc6jt1Tq/4=; b=VIqjwJKw3smg1cWJh/wIPcBRMymm2SYM9WBebm5zk+ed2CV931tKYME84zMiLRDKnw 2bch/XEgYWaAwrnUvIJ4ACQu78vbStAl5PQeTiMGqHsrrW+3Icq/XqrX+ifLa9z/1Dry dmebjcev4p0DY/xiKbvHYg3iEGLtvdztXo5TxJLxQOHD1gCdOJOKi2dcoJshkkWZvUPj Ry3FmLaAEv4UepKn8AcBCPHb0NpriDDy9+mW1puyYI+a6HFpyEtwXgTL7sDuLcmiHthf RDGwxEbKdn5My2vwCNdH/v7xnYPrV7W0na49tHoYwZgcFgy1fvM3F+E4OJB1vzG9jHFn /Z2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p+Rx8CLlS6c401nqoIEnCpIsNrBL9fyp9Oc6jt1Tq/4=; b=MWb6uyG7uyDI8a/bHZqgOK38p+qIr883lZLjJJfOPEcxlkblywGegMl4EPCvNvYLXv LbvvkO1Hea2oBaauDnzLZNUIq+vl12THNP4dOZBK98kLr5ymiw0L13TpUZgTgpyGSHKB oapHoVwlqMRcfWn4wcJsbtPudRL8MTfV98aNXHx8p+HF6SP0uZMA2gZzzosTO8/NrYR2 pRC+6l8E1Zwu8kg7d6DkkQtpTztN7YhIZO1zP/xn0otDvGO9SN5kR4dUPLuTVdfcGLIu ULrYdKERtxyZoO//AwRCplfVBq1AW2Rs6RgB3GnQCXKe/La4kd7mqTLZLDr6JiK98U6P uAbQ== X-Gm-Message-State: AA+aEWaF2fOel5DFc1jXObvhqNU7o7+2YGwHx3xu05ADdYRZhK34UWc9 UWM+B0u0OiF6TLTkz7FhVo6meQK06KQ= X-Received: by 2002:a6b:c402:: with SMTP id y2mr1302259ioa.77.1544118693023; Thu, 06 Dec 2018 09:51:33 -0800 (PST) Received: from [192.168.1.56] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id w13sm692421itb.10.2018.12.06.09.51.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Dec 2018 09:51:32 -0800 (PST) Subject: Re: [PATCH] blkcg: put back rcu lock in blkcg_bio_issue_check() To: Dennis Zhou , Tejun Heo , Johannes Weiner , Josef Bacik Cc: kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181206174938.2326-1-dennis@kernel.org> From: Jens Axboe Message-ID: Date: Thu, 6 Dec 2018 10:51:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181206174938.2326-1-dennis@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/18 10:49 AM, Dennis Zhou wrote: > I was a little overzealous in removing the rcu_read_lock() call from > blkcg_bio_issue_check() and it broke blk-throttle. Put it back. Applied, thanks Dennis. -- Jens Axboe