Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181025110530.22826-1-muvarov@gmail.com> <20181025230611.GE6276@lunn.ch>
In-Reply-To: <20181025230611.GE6276@lunn.ch>
From:   Maxim Uvarov <muvarov@gmail.com>
Date:   Thu, 6 Dec 2018 21:27:24 +0300
Message-ID: <CAJGZr0+fJR1uF8H=sH6FgHxt6xP1cc=FHdGpbqPjqJOuZZ8P8Q@mail.gmail.com>
Subject: Re: [PATCH] dp83867: fix speed 10 in sgmii mode
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     kernel list <linux-kernel@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=D0=BF=D1=82, 26 =D0=BE=D0=BA=D1=82. 2018 =D0=B3. =D0=B2 02:06, Andrew Lunn=
 <andrew@lunn.ch>:
>
> On Thu, Oct 25, 2018 at 02:05:30PM +0300, Max Uvarov wrote:
>
> Hi Max
>
> > For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit
>
> speed.
>
> > of DP83867_10M_SGMII_CFG register has to be cleared by software.
> > That does not affect speeds 100 and 1000 so can be done on init.
>
> It would be good to add a Fixes: tag. Has this always been broken?
>

I somehow skipped this reply. I guess that was always broken. More
likely 10M is not the speed what people use nowadays. But anyway it
will be great to fix anyway.

Max.

> Thanks
>         Andrew