Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp11157922imu; Thu, 6 Dec 2018 12:30:39 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wn6qgoHWNaAaBszUG04xRwZN2d7YEXC36/RH7D9XXDYjvc4qluBGmZ9eJDXS2CKNFvDapj X-Received: by 2002:a17:902:714c:: with SMTP id u12mr29271000plm.234.1544128239395; Thu, 06 Dec 2018 12:30:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544128239; cv=none; d=google.com; s=arc-20160816; b=ZYGIOvUHNhFWZD1EY5HkrDUvzvxQwShGfqDskeQXwx/LmyqFOf2pJidEBIkSKH2z1o 5BNzwGLxZLk9ZrXbO7/AepffGmnDV5FCMMvFzBvgoQitl2Y1e2A4RAVUqd+6GKUU+hRB aKPbAHnoxK/F6PJQn2pyzF7YJPpvtQaeO00dyCwXK3DHy2jdGFhSIc4X67mBXgs4qePK f4VVpjxjAscFeHCUst0D5hX6YNzNkV5br4NOuzRdfRBdR8JA/o05WQbCB1NNmNRov7Uu 4OmlvSLjUHQ2wi0gkN6NuP7+rZ6iDJ1Hxbf9bGaup5TbFVQuJXkLc7Q7Ypr9HRVe+u0R keoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:spamdiagnosticmetadata:spamdiagnosticoutput :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=c9ed/hUz8eb3D+zblBS2isNOzVGirA0w4iF6bw2cMqA=; b=uM0TmNUFrqVaD4vIto+0HxhFrbyM6/Ef8nL1OYtrvheCRl7FJ3lryYuuRGVEDbtb36 BkkqUgn3obj+cQtMXI9aPSJzYbES4eRneFpUx7c9f4izb5FyDZ8G1qYDVoBk7rgWUCKO hrBzJooezuDaw+GbEuWev1O5hFQZnAcU4/rBKnfGQUcQOzj1jk8H85fAvdsKpE6eBOtD OXognNGC9eJi5azdglvDWdnXXAE+KtpV90q4l0Ehp7PqtmTJRvI0CWas1zef9cgamFy+ hD8E7A0LP41qSsOEp/XRbMaBdzTxsPKwjnlOQCF2zMu6cKnaMWw8wm4UuF4u6yfKXjp2 VNcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@vmware.com header.s=selector1 header.b=cpOkkGEy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si994301ply.421.2018.12.06.12.30.22; Thu, 06 Dec 2018 12:30:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@vmware.com header.s=selector1 header.b=cpOkkGEy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726056AbeLFU3p (ORCPT + 99 others); Thu, 6 Dec 2018 15:29:45 -0500 Received: from mail-eopbgr800057.outbound.protection.outlook.com ([40.107.80.57]:12320 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725994AbeLFU3p (ORCPT ); Thu, 6 Dec 2018 15:29:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9ed/hUz8eb3D+zblBS2isNOzVGirA0w4iF6bw2cMqA=; b=cpOkkGEy/aUb799GfJzk2aqPy0O/Zh9RUpZUJTd6K2cDRSWwDhR4U4xj85m90yRXrS+ERhTynQnLoudw3D2NY8GYP7ivymeEgbmCaFGvInIcQMSPPe+px/57hNT2Smh95sVqIMaVEdexoBL1skXLi5x9WB9MCstOcOSeAKCuJhc= Received: from BYAPR05MB4776.namprd05.prod.outlook.com (52.135.233.146) by BYAPR05MB5127.namprd05.prod.outlook.com (20.177.231.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.14; Thu, 6 Dec 2018 20:29:37 +0000 Received: from BYAPR05MB4776.namprd05.prod.outlook.com ([fe80::9155:fea7:9c0c:68c7]) by BYAPR05MB4776.namprd05.prod.outlook.com ([fe80::9155:fea7:9c0c:68c7%3]) with mapi id 15.20.1425.006; Thu, 6 Dec 2018 20:29:37 +0000 From: Nadav Amit To: "Edgecombe, Rick P" CC: "luto@kernel.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "linux-integrity@vger.kernel.org" , "tglx@linutronix.de" , "dave.hansen@linux.intel.com" , "linux-security-module@vger.kernel.org" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "linux_dti@icloud.com" , "will.deacon@arm.com" , "bp@alien8.de" Subject: Re: [PATCH v7 13/14] module: Do not set nx for module memory before freeing Thread-Topic: [PATCH v7 13/14] module: Do not set nx for module memory before freeing Thread-Index: AQHUjHgCm5HQo9wG+kmVhMEM5+sZ86VyEK8AgAAZDICAAAIjAA== Date: Thu, 6 Dec 2018 20:29:37 +0000 Message-ID: <1B1C066C-04B2-4DD0-A28B-71BA7CDDD658@vmware.com> References: <20181205013408.47725-1-namit@vmware.com> <20181205013408.47725-14-namit@vmware.com> <55a4fb61164d7ecf5950e29d1fa2aea52a1b958f.camel@intel.com> In-Reply-To: <55a4fb61164d7ecf5950e29d1fa2aea52a1b958f.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=namit@vmware.com; x-originating-ip: [208.91.2.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BYAPR05MB5127;20:gzj0mEGqbs1HhU+NYhfKKwwVF7NChrSIS9MEOxTtqoc6Pgng7PLSU1LkKHVKgQHf1dirTjQEO6Pc3ReIoYsycWWykoVEMVV/BSPhs1K3S56JzyTooT09MZvv2DBn/UPz06zWQMC+jcXNt6k0ZUjtqS+SD+XtuwjOQBFY3/bapSU= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: fd3c22d5-4e0c-49b2-75a7-08d65bb98ae7 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:BYAPR05MB5127; x-ms-traffictypediagnostic: BYAPR05MB5127: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231455)(999002)(944501520)(52105112)(10201501046)(3002001)(93006095)(93001095)(148016)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095);SRVR:BYAPR05MB5127;BCL:0;PCL:0;RULEID:;SRVR:BYAPR05MB5127; x-forefront-prvs: 087894CD3C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(39860400002)(366004)(376002)(346002)(136003)(199004)(189003)(6116002)(102836004)(11346002)(86362001)(82746002)(3846002)(6506007)(316002)(2906002)(68736007)(66066001)(53546011)(76176011)(33656002)(36756003)(99286004)(54906003)(83716004)(53936002)(6436002)(4326008)(71190400001)(106356001)(6512007)(6486002)(229853002)(39060400002)(105586002)(6246003)(14444005)(256004)(478600001)(2616005)(25786009)(6916009)(446003)(26005)(476003)(186003)(14454004)(486006)(8676002)(8936002)(81166006)(81156014)(71200400001)(305945005)(7736002)(5660300001)(93886005)(7416002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR05MB5127;H:BYAPR05MB4776.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OOYIsDHF7gExtm9lZBfPLkOXTX8DDRUsRRTdORU6HTEDUwKefGYo7lAZUr/jQ0AS8PuadTWIMSTbtGFVRu+3oE3zBOJM40r7lrh7rYSsk+rQPQZ3WKFPP673j2T68ZRjGa0QrFeD8hQEYrXTFXQRDZ18imL5t/cWujM4UKip24fL1nelUqQIOHCn0EPI7YVHRxWLU3r70WEsIL5ItsgXsUqhYysX0BUpsA2VVVfIs7NTQn3sp7CUHhIEIXyHQZHtXN5x5d2X65sxPaarGMiqiOcEMRW6PoLl+73oEpvtCXFdyP/L3yJdNVLqvbxgi/SdWec6IX81MQ9aF171Cy1pQ+unvHurgfdHBa+4eADkf5o= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <0B5CCE7B367EC949A3DE056C47FFFE00@namprd05.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd3c22d5-4e0c-49b2-75a7-08d65bb98ae7 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2018 20:29:37.4974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB5127 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBPbiBEZWMgNiwgMjAxOCwgYXQgMTI6MjEgUE0sIEVkZ2Vjb21iZSwgUmljayBQIDxyaWNrLnAu ZWRnZWNvbWJlQGludGVsLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBUaHUsIDIwMTgtMTItMDYgYXQg MTA6NTIgLTA4MDAsIEFuZHkgTHV0b21pcnNraSB3cm90ZToNCj4+IE9uIFdlZCwgRGVjIDUsIDIw MTggYXQgMTI6NTIgQU0gTmFkYXYgQW1pdCA8bmFtaXRAdm13YXJlLmNvbT4gd3JvdGU6DQo+Pj4g V2hlbiBtb2R1bGUgbWVtb3J5IGlzIGFib3V0IHRvIGJlIGZyZWVkLCB0aGVyZSBpcyBubyBhcHBh cmVudCByZWFzb24gdG8NCj4+PiBtYWtlIGl0IChhbmQgaXRzIGRhdGEpIGV4ZWN1dGFibGUsIGJ1 dCB0aGF0J3MgZXhhY3RseSB3aGF0IGlzIGRvbmUNCj4+PiB0b2RheS4gVGhpcyBpcyBub3QgZWZm aWNpZW50IGFuZCBub3Qgc2VjdXJlLg0KPj4+IA0KPj4+IFRoZXJlIGFyZSB2YXJpb3VzIHRoZW9y aWVzIHdoeSBpdCB3YXMgZG9uZSwgYnV0IG5vbmUgb2YgdGhlbSBzZWVtIGFzDQo+Pj4gc29tZXRo aW5nIHRoYXQgcmVhbGx5IHJlcXVpcmUgaXQgdG9kYXkuIG5pb3MyIHVzZXMga21hbGxvYyBmb3Ig bW9kdWxlDQo+Pj4gbWVtb3J5LCBidXQgYW55aG93IGl0IGRvZXMgbm90IGNoYW5nZSB0aGUgUFRF cyBvZiB0aGUgbW9kdWxlIG1lbW9yeS4gIEluDQo+Pj4geDg2LCBjaGFuZ2luZyB2bWFsbG9jJ2Qg bWVtb3J5IG1hcHBpbmdzIGFsc28gbW9kaWZpZXMgdGhlIGRpcmVjdCBtYXBwaW5nDQo+Pj4gYWxp YXMsIGJ1dCB0aGUgTlgtYml0IGlzIG5vdCBtb2RpZmllZCBpbiBzdWNoIHdheS4NCj4+PiANCj4+ PiBTbyBsZXQncyByZW1vdmUgaXQuIEFuZHkgc3VnZ2VzdGVkIHRoYXQgdGhlIGNoYW5nZXMgb2Yg dGhlIFBURXMgY2FuIGJlDQo+Pj4gYXZvaWRlZCAoZXhjbHVkaW5nIHRoZSBkaXJlY3QtbWFwcGlu ZyBhbGlhcyksIHdoaWNoIGlzIHRydWUuIEhvd2V2ZXIsDQo+Pj4gaW4geDg2IGl0IHJlcXVpcmVz IHNvbWUgY2xlYW51cCBvZiB0aGUgY29udGlndW91cyBwYWdlIGFsbG9jYXRvciwgd2hpY2gNCj4+ PiBpcyBvdXRzaWRlIG9mIHRoZSBzY29wZSBvZiB0aGlzIHBhdGNoLXNldC4NCj4+IA0KPj4gDQo+ PiBJJ20gb2theSB3aXRoIHRoaXMsIGJ1dCBJJ2QgbGlrZSB0byBzZWUgUmljaydzIHN0dWZmIGdl dCByZWJhc2VkIG9uDQo+PiB0b3Agb2YgaXQgYW5kIGNsZWFuIGl0IHVwIGZvciByZWFsLg0KPiAN Cj4gTmFkYXYsDQo+IA0KPiBIbW0sIHNpbmNlIHlvdSBhcmUgdHJ5aW5nIHRvIG1vdmUgdGhpbmdz IGZvcndhcmQgYW5kIG5vdCBjbG9zZSBhbGwgY2FzZXMgaW4gb25lDQo+IHN3b29wLCB3b3VsZCBp dCBtYWtlIHNlbnNlIHRvIHNwbGl0IHRoZSBtb2R1bGVzIFdeWCBtaXNzaW9uIGZyb20gdGhpcyBw YXRjaHNldD8NCg0KVGhhdOKAmXMgd2hhdCBJIHRyaWVkIHRvIOKAnGhpbnTigJ0uIFRnbHggYXNr ZWQgZm9yIHRoZSBtb2R1bGUgc3R1ZmYgaW4gb25lIG9mIHRoZQ0KcHJldmlvdXMgdmVyc2lvbnMu DQoNCg==